From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01C6C340401; Fri, 28 Aug 2026 06:37:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787899060; cv=none; b=Sjb+Lj+Fyteh8ORgFgHEyNKh/Zg6CRk6GcZt1phzwvL7aSIoGgzIOPlNMfiCNa37TqHuXvAtZ8ro7dG1ocWU9B9jzEsuCMuZ+XLjwJ+EA8sPwyhq36AuD2ZrHGa0SPkLf9Hevu+YfC7HDUZjBU896sI3QwC/4euJ82PZldlIduY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787899060; c=relaxed/simple; bh=4lTjn++J8zQS3iUxuL05tEh+l5195RqVkf27xkVE2i0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iLAR4KZn2Itv0XB5+XclyEPHK3yydTlxAZ+mr8lN7HN9T3buruc71/TdCrWIzspQE6ncf8FD3R7y6Fn5jdKFX7omYOTeaqzpVl/Sd8PJkjKalfceLV2B3DcZl9I5JBmJM8ZL7lNpjqvQHs1RvhJhWFqIej0PY0BJsbocxxFU/zw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AZ+WrHq1; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AZ+WrHq1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CAF61F000E9; Fri, 28 Aug 2026 06:37:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787899058; bh=3H4EoVXJ4IMJ0GbBjlrwyyJVCkd+CZt4ut1EDis3HKE=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=AZ+WrHq17G6HVcBIKNjONnllcjj9O6qpNkmw0PAr3zntbuOCg1zyzat5PHpipgoik YtoBFkqr7AP3AAxnfKBi+Fw7E87Vw1TWVc4QILLwtlvJ2PVQAHP2hD2QBMgw2WPoiw L8nw0RCnGHm+T0Tw2iiwtzb8ZQpJ2juEDqDVGUN5miSg8/EU+Brrh5K0YTmYNlGZdc kiQ/TtP2bo+DorqBE85dkOP9I3RwuKOQdSrEH9KjdPwhPbiYx1tPKuBrQhGig11Yzm xWpZg+F4lLqDBmowccVXvVS6TNCOQ+IQknEmqK49hvjgJWlV8TFGA23KuCdXdpA2hT fe5k2ZK8AD6dg== Message-ID: Date: Fri, 28 Aug 2026 08:37:27 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/9] dt-bindings: phy: Document ST STM32MP25 USB2-FEMTO PHY To: Marek Vasut , linux-usb@vger.kernel.org Cc: fabrice.gasnier@foss.st.com, Pankaj Dev , Rahul Kumar , =?UTF-8?Q?Cl=C3=A9ment_Le_Goffic?= , Alexandre Torgue , Christian Bruel , Conor Dooley , Greg Kroah-Hartman , Krzysztof Kozlowski , Maxime Coquelin , Neil Armstrong , Rob Herring , Rosen Penev , Thinh Nguyen , Vinod Koul , devicetree@vger.kernel.org, kernel@dh-electronics.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com References: <20260822074816.548662-1-marex@nabladev.com> <20260822074816.548662-2-marex@nabladev.com> <7a16614a-bd1b-462a-be13-4a9c22aa588e@kernel.org> <34c48ff1-524f-4d24-b53f-99e7171d08db@nabladev.com> <25e10cfe-40dc-45f4-8a92-cd81263420ea@kernel.org> <84bd4b0b-69c3-451e-9e0b-690191f52537@nabladev.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <84bd4b0b-69c3-451e-9e0b-690191f52537@nabladev.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 28/08/2026 01:14, Marek Vasut wrote: > On 8/27/26 11:33 PM, Krzysztof Kozlowski wrote: >> On 27/08/2026 16:53, Marek Vasut wrote: >>> On 8/27/26 2:54 PM, Krzysztof Kozlowski wrote: >>>> On 22/08/2026 09:46, Marek Vasut wrote: >>>>> +description: >>>>> + USB2 PHY block in STM32 is attached to USB 2.0 Host controller and >>>>> + USB 2.0 side of DWC3 DRD controller, and provides the USB LS/FS/HS >>>>> + connectivity. Both PHYs are the FEMTO-PHY, but their configuration >>>>> + bits in the system control register are different for each variant. >>>>> + >>>>> +maintainers: >>>>> + - Fabrice Gasnier >>>>> + - Marek Vasut >>>>> + - Pankaj Dev >>>>> + >>>>> +properties: >>>>> + compatible: >>>>> + enum: >>>>> + - st,stm32mp25-usb2phy1 >>>>> + - st,stm32mp25-usb2phy2 >>>>> + >>>>> + "#clock-cells": >>>>> + const: 1 >>>>> + >>>> >>>> As pointed out by different patchset built on top of it, this is wrong. >>> >>> What is wrong in this (V3) of the patchset ? I think the ST patches were >>> fixing up V2 and what they were fixing up is already fixed here in V3. >> >> Probably I got confused... but I had impression the ST patches were >> adding here "reg" property, no? > It is there in V3: > > " > + "#clock-cells": > + const: 1 > + > + "#phy-cells": > + const: 0 > + > + reg: <------------------ HERE > + maxItems: 1 > + Ah, indeed. BTW, reg usually follows compatible. Best regards, Krzysztof