From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 753D9C6FD1C for ; Wed, 22 Mar 2023 18:16:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230038AbjCVSQx (ORCPT ); Wed, 22 Mar 2023 14:16:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229996AbjCVSQx (ORCPT ); Wed, 22 Mar 2023 14:16:53 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 775E06505A for ; Wed, 22 Mar 2023 11:16:51 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id x17so24559775lfu.5 for ; Wed, 22 Mar 2023 11:16:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679509010; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0Jvs1xrLwrNQQ4RSyjH1t+/FTl15pE2eQYewVtTpktU=; b=SYtHlAy116u32i5WTaiPvBLFHjuG+UC/JIXcyNIA5v3x5L8U+7BfXyA52lsU0jyvkX bXpaQMeDgLLEWn6zz5v7OZqy3cj5QR/xsSSeSR16v5NFIFvt55c/64v/MJD0R+OIZWyn KDcO7M3zB2hDgGfQsvqNjoSMQJ+kkLi1MhCsJAGusz/IejVRu7qEkI0MFVIWwzTeBh9/ JCxSfUHYEjjjKjg/6dZIe5LzeDeyCBT7n5gOiXeQnMiACSK1kyy6EZ6+pqJKpeJfWj/X Jzad58Skp3ldyTpUhdvNw1VAo/4ZY/J2zZmxfOBkWJjyRKmWfbEzlgfT5TlMyZNoi11E E1hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679509010; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0Jvs1xrLwrNQQ4RSyjH1t+/FTl15pE2eQYewVtTpktU=; b=jzzNq68XSXGovIFMcmeRiTQyVG5fzDR3j91vDyFesqn6ix0zhiVZwgniiI1SQVm3WY kcghfuwobfNBnLObbQHna8zca2Rp4iz4fEE8j7FdbwW/hIgrX3qXWnIzUyIRHo9VHd+s LghUf9Dbfwd8idzjb9Wmb0xzHfwcfXLVVzGCfgcukptn/4IjKAT7i/7qVftZtrX3WWmC lsV9hpBnVfzlOuNaOUezC0Rozo/zp6jtxB+m6KlHxdRVIISDzRzoHLY6mpiBg4HZWqVH HulzTG4j+q4WojED61McA/T7M9esv4u8NKddpSeSqUHD9JbNxVS3Y+pRuCYBGbBibc9b vhBg== X-Gm-Message-State: AO0yUKXXniuQVOoO906iWwLwDsOZnt7Au6hg3tewysMf+WQ6VcSPaPyn EUudvlQzKkdgd/WXx7rbnDZb8w== X-Google-Smtp-Source: AK7set+fLoVTA6hr132qva8LSEj0pfzjQ3CRhGCxuMohwD7zHa35QrFFPQu9QKQddw8F89iiNrfcxw== X-Received: by 2002:ac2:4310:0:b0:4dd:af76:d3c with SMTP id l16-20020ac24310000000b004ddaf760d3cmr2012118lfh.48.1679509009739; Wed, 22 Mar 2023 11:16:49 -0700 (PDT) Received: from [192.168.1.101] (abym238.neoplus.adsl.tpnet.pl. [83.9.32.238]) by smtp.gmail.com with ESMTPSA id y2-20020ac24202000000b004b53eb60e3csm2651938lfh.256.2023.03.22.11.16.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 11:16:49 -0700 (PDT) Message-ID: Date: Wed, 22 Mar 2023 19:16:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: sm8250-xiaomi-elish: Add mdss and dsi node Content-Language: en-US To: Jianhua Lu , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20230322171555.2154-1-lujianhua000@gmail.com> <20230322171555.2154-2-lujianhua000@gmail.com> From: Konrad Dybcio In-Reply-To: <20230322171555.2154-2-lujianhua000@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22.03.2023 18:15, Jianhua Lu wrote: > xiaomi-elish uses dual dsi mode panel and dsi phy type is cphy. > > Signed-off-by: Jianhua Lu > --- > Changes in v2: > - Include missing for phy-type property. > > .../dts/qcom/sm8250-xiaomi-elish-common.dtsi | 73 +++++++++++++++++++ > 1 file changed, 73 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > index a43d4b73ffca..4ff8454d4abe 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include 'p' < 'r' > #include "sm8250.dtsi" > #include "pm8150.dtsi" > #include "pm8150b.dtsi" > @@ -469,6 +470,74 @@ &cdsp { > status = "okay"; > }; > > +&dsi0 { > + vdda-supply = <&vreg_l9a_1p2>; > + qcom,dual-dsi-mode; > + qcom,master-dsi; Keep the master property after qcom,sync-dual-dsi so that we get a nice reverse-Christmas-tree. > + qcom,sync-dual-dsi; > + status = "okay"; > + > + display_panel: panel@0 { > + reg = <0>; > + vddio-supply = <&vreg_l14a_1p88>; > + reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>; > + backlight = <&backlight>; > + > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; Please add newlines before subnodes. Konrad > + panel_in_0: endpoint { > + remote-endpoint = <&dsi0_out>; > + }; > + }; > + > + port@1{ > + reg = <1>; > + panel_in_1: endpoint { > + remote-endpoint = <&dsi1_out>; > + }; > + }; > + > + }; > + }; > +}; > + > +&dsi0_out { > + data-lanes = <0 1 2>; > + remote-endpoint = <&panel_in_0>; > +}; > + > +&dsi0_phy { > + vdds-supply = <&vreg_l5a_0p88>; > + phy-type = ; > + status = "okay"; > +}; > + > +&dsi1 { > + vdda-supply = <&vreg_l9a_1p2>; > + qcom,dual-dsi-mode; > + qcom,sync-dual-dsi; > + /* DSI1 is slave, so use DSI0 clocks */ > + assigned-clock-parents = <&dsi0_phy 0>, <&dsi0_phy 1>; > + status = "okay"; > +}; > + > +&dsi1_out { > + data-lanes = <0 1 2>; > + remote-endpoint = <&panel_in_1>; > +}; > + > +&dsi1_phy { > + vdds-supply = <&vreg_l5a_0p88>; > + phy-type = ; > + status = "okay"; > +}; > + > &gmu { > status = "okay"; > }; > @@ -533,6 +602,10 @@ fuel-gauge@55 { > }; > }; > > +&mdss { > + status = "okay"; > +}; > + > &pcie0 { > status = "okay"; > };