From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DBE3627EF for ; Thu, 21 Dec 2023 17:27:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aCjqJnmx" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-552ff8d681aso3925127a12.1 for ; Thu, 21 Dec 2023 09:27:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703179635; x=1703784435; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=E9fZnvcr17iWEnEDx/jO4bNozX7Sbo2SKEDCBqZmguQ=; b=aCjqJnmx198yitgpWmgyz+ISbzltomzyIfFvoOVgHLZp7tXXOF3nQSAwR9fP5JXhug UPjKGslqpVvWT+S7NgCnFkqaTqPiUZzP82xh57vIG7aCGgHXR/kEuNjnJDECKjsktPVR TDvuhy6gIjoYQxU3/VlNuTcqbxW8h0P7gj0exJwBVK5WoqQ720vdC2ZQVGppTIaHAch5 Ai7jP7fsJCGVx7fsCb3c2K+1hCAKuA5akGx2nbC3JLG15QuTDqqW2uoEGfldoYeiF6NZ AeJfHV71mDgfCN2dvTf42c5eq0qE6QG/gz9il1m7jxTEChiV626RaHHtoMDXR98zv/UA 1LTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703179635; x=1703784435; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E9fZnvcr17iWEnEDx/jO4bNozX7Sbo2SKEDCBqZmguQ=; b=mgIACcQAxSwBdq+rVqyolPR6c9Wg1pLzQufp2Mnydr+AC7SWN8NFcRLt5hSzp40ez6 ShM6kHoZIyEsbKqRsXSQl5hPrvdLsc/3aGSFnmuaIGyCYaTksn4n4xD70WadyZjVbKBV l8NrEQa0too0/LwmI9T+wHBYQxyCDFyTd6FPBLe1Ri0mW20UYYO9g8o9Lw06P46BK4Qy aQOWvNzti4mFN076PuXFgqRNRaweDy6Wa2Oc5Q5k3llmcRyg4714/3YVpZ4F3QsM7eSe fp3j716XzRHWrvWkHiM2W0kTOWKLXBlmi+d1E8XLxB5+C+yZRBq1OgIeDRp3qc/yv5c3 ud9A== X-Gm-Message-State: AOJu0YxiLJySWDKdk/Eu339S2tUWeW1OsnP+5OisyH4vlB9sVdfqRQ6z mxffoVdpo2Rh8D4njL7bTlZsuCqAT7Ohgw== X-Google-Smtp-Source: AGHT+IH2vTxRhlOEolIghnp/12hUc4XPl/V+sTUI3T7RdIIuDCcBJV7zVip8AxYZZVVY/HQzwWMGrA== X-Received: by 2002:a17:906:df52:b0:a19:a409:37dc with SMTP id if18-20020a170906df5200b00a19a40937dcmr23369ejc.53.1703179635603; Thu, 21 Dec 2023 09:27:15 -0800 (PST) Received: from [192.168.0.22] ([78.10.206.178]) by smtp.gmail.com with ESMTPSA id mf8-20020a1709071a4800b00a26a4b935b0sm919298ejc.166.2023.12.21.09.27.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Dec 2023 09:27:15 -0800 (PST) Message-ID: Date: Thu, 21 Dec 2023 18:27:12 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/8] dt-bindings: display: add dt-bindings for STM32 LVDS device To: Raphael Gallais-Pou , Laurent Pinchart , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Yannick Fertre , Philippe Cornu , Philipp Zabel , Lad Prabhakar , Thierry Reding Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org References: <20231221122843.418650-1-raphael.gallais-pou@foss.st.com> <20231221122843.418650-3-raphael.gallais-pou@foss.st.com> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231221122843.418650-3-raphael.gallais-pou@foss.st.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21/12/2023 13:28, Raphael Gallais-Pou wrote: > Add dt-binding file for "st,stm32-lvds" compatible. > A nit, subject: drop second/last, redundant "dt-bindings for". The "dt-bindings" prefix is already stating that these are bindings. > Signed-off-by: Raphael Gallais-Pou > --- > .../bindings/display/st,stm32-lvds.yaml | 114 ++++++++++++++++++ > 1 file changed, 114 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/st,stm32-lvds.yaml > ... > +properties: > + "#clock-cells": > + const: 0 > + > + compatible: > + const: st,stm32-lvds Please put compatible as first. > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: APB peripheral clock > + - description: Reference clock for the internal PLL > + > + clock-names: > + items: > + - const: pclk > + - const: ref > + > + resets: > + maxItems: 1 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: | > + LVDS input port node, connected to the LTDC RGB output port. > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: | > + LVDS output port node, connected to a panel or bridge input port. Ports are not required? I would assume it won't work without input and output. > + > +required: > + - "#clock-cells" > + - compatible > + - reg > + - clocks > + - clock-names > + - resets > + - ports > + > +unevaluatedProperties: false additionalProperties instead... or did I miss some $ref anywhere? > + > +examples: > + - | > + #include > + #include > + #include > + > + lvds: lvds@48060000 { > + #clock-cells = <0>; > + compatible = "st,stm32-lvds"; compatible is always the first property. > + reg = <0x48060000 0x2000>; put clock-cells here > + clocks = <&rcc CK_BUS_LVDS>, <&rcc CK_KER_LVDSPHY>; > + clock-names = "pclk", "ref"; > + resets = <&rcc LVDS_R>; Best regards, Krzysztof