From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84550EB64DC for ; Tue, 27 Jun 2023 10:50:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231317AbjF0KuI (ORCPT ); Tue, 27 Jun 2023 06:50:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230449AbjF0KuH (ORCPT ); Tue, 27 Jun 2023 06:50:07 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 414E010EC for ; Tue, 27 Jun 2023 03:50:05 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2b6a0e36d42so24737311fa.0 for ; Tue, 27 Jun 2023 03:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687863003; x=1690455003; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JQv8jcNHh6YGNnlPQUGLzOBcoLFIikNnZeDEV9jIllE=; b=I1/SnR+94qSszD2rk39YnXZ8XbSPuKL50mLsB+pFFJiP2M2LxPPvjBQbnaMMD6iUq9 S6ftvJIYGDSSyH4LVT0UGta88GFlNVZAopStGwpsXEXyBn5ZEW7BFVughnH35fTOOVfq BOxbPyr3dKdi9zJ+jVJ72j4OKTkbNqtJGK9GEz7ByeEHf7KDn4DeWvlGHymavEqgHw3z 49AI3ZPkYkdVtwtSW/xNYDZP6+jbTlukcAV08qa779h9qzPKs1vYKgJj+SX/UbNS7MG2 VlAhKrz+4iiZm7fw/alKUZANqjS9jOSO44gBDulpUVnodCDUd4zBC5Fmvya4u3UAA/3v suPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687863003; x=1690455003; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JQv8jcNHh6YGNnlPQUGLzOBcoLFIikNnZeDEV9jIllE=; b=QIapHJE5AkasN+VFWq1C4eS9nm48rA5LenMvGw6VRzmMoKcMrEgQY8GPrQoruOezSs oC+3aSCA13k5Fyi+JBBoxuDSTg72a2MXK2lanIb5X5vNq16QPDTPQBEQwM6gVBBWuBzT CLfikXxJYfk9YpJQbD5RQ+vj0C4BrK961hL8B+EDjUivWH3cmYMjGUiQiPXVUuAj/D6n ymXQ4KWuvbTaZqfJJSeIVcTtLzFq7rrKw7i1V0UZBGTAYm2yPRk/ctQTQ16suXwWFgdo q2CbLYNJfUELWVPEb4+3k3fNWwSbwc2EHpiVde+2cDJrepW1aCbTYHhmsKskZG9UrC9g CuKg== X-Gm-Message-State: AC+VfDw8GFIAD1smgxdvpXmjfbPtciyYXxvQncLOvxrwY5xWyXxwSMYe 3Xmhzu2b4FLV5huGwqme09kBuA== X-Google-Smtp-Source: ACHHUZ6t6l7fOHIrIW46zWuLD2Iu76LSS65MwKBWE+RVz74CzT7mQvevBJCJrn7gsgmdnwErwsyJ3w== X-Received: by 2002:a05:651c:1184:b0:2b6:a662:b874 with SMTP id w4-20020a05651c118400b002b6a662b874mr1465095ljo.21.1687863003476; Tue, 27 Jun 2023 03:50:03 -0700 (PDT) Received: from [192.168.1.101] (abxj103.neoplus.adsl.tpnet.pl. [83.9.3.103]) by smtp.gmail.com with ESMTPSA id d9-20020a2e96c9000000b002b6988ca476sm1479046ljj.101.2023.06.27.03.50.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jun 2023 03:50:03 -0700 (PDT) Message-ID: Date: Tue, 27 Jun 2023 12:50:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v5 5/5] arm64: dts: qcom: sm8450: Use standalone ICE node for UFS Content-Language: en-US To: Luca Weiss , Andy Gross , Bjorn Andersson , Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Manivannan Sadhasivam , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20221209-dt-binding-ufs-v5-0-c9a58c0a53f5@fairphone.com> <20221209-dt-binding-ufs-v5-5-c9a58c0a53f5@fairphone.com> From: Konrad Dybcio In-Reply-To: <20221209-dt-binding-ufs-v5-5-c9a58c0a53f5@fairphone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27.06.2023 10:28, Luca Weiss wrote: > With the ICE driver now merged let's convert the ufs node to use the new > style. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/sm8450.dtsi | 22 +++++++++++++--------- > 1 file changed, 13 insertions(+), 9 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > index 5cd7296c7660..79627117a776 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > @@ -4120,9 +4120,7 @@ system-cache-controller@19200000 { > ufs_mem_hc: ufshc@1d84000 { > compatible = "qcom,sm8450-ufshc", "qcom,ufshc", > "jedec,ufs-2.0"; > - reg = <0 0x01d84000 0 0x3000>, > - <0 0x01d88000 0 0x8000>; > - reg-names = "std", "ice"; > + reg = <0 0x01d84000 0 0x3000>; > interrupts = ; > phys = <&ufs_mem_phy_lanes>; > phy-names = "ufsphy"; > @@ -4147,8 +4145,7 @@ ufs_mem_hc: ufshc@1d84000 { > "ref_clk", > "tx_lane0_sync_clk", > "rx_lane0_sync_clk", > - "rx_lane1_sync_clk", > - "ice_core_clk"; > + "rx_lane1_sync_clk"; > clocks = > <&gcc GCC_UFS_PHY_AXI_CLK>, > <&gcc GCC_AGGRE_UFS_PHY_AXI_CLK>, > @@ -4157,8 +4154,7 @@ ufs_mem_hc: ufshc@1d84000 { > <&rpmhcc RPMH_CXO_CLK>, > <&gcc GCC_UFS_PHY_TX_SYMBOL_0_CLK>, > <&gcc GCC_UFS_PHY_RX_SYMBOL_0_CLK>, > - <&gcc GCC_UFS_PHY_RX_SYMBOL_1_CLK>, > - <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; > + <&gcc GCC_UFS_PHY_RX_SYMBOL_1_CLK>; > freq-table-hz = > <75000000 300000000>, > <0 0>, > @@ -4167,8 +4163,9 @@ ufs_mem_hc: ufshc@1d84000 { > <75000000 300000000>, > <0 0>, > <0 0>, > - <0 0>, > - <75000000 300000000>; > + <0 0>; > + qcom,ice = <&ice>; > + > status = "disabled"; > }; > > @@ -4198,6 +4195,13 @@ ufs_mem_phy_lanes: phy@1d87400 { > }; > }; > > + ice: crypto@1d88000 { > + compatible = "qcom,sm8450-inline-crypto-engine", > + "qcom,inline-crypto-engine"; > + reg = <0 0x01d88000 0 0x8000>; > + clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; > + }; > + > cryptobam: dma-controller@1dc4000 { > compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0"; > reg = <0 0x01dc4000 0 0x28000>; >