From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CA9BC4332F for ; Fri, 21 Oct 2022 08:39:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230026AbiJUIjJ (ORCPT ); Fri, 21 Oct 2022 04:39:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230221AbiJUIjI (ORCPT ); Fri, 21 Oct 2022 04:39:08 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 890BE21B3 for ; Fri, 21 Oct 2022 01:38:52 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id a10so3225359wrm.12 for ; Fri, 21 Oct 2022 01:38:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=sbUO6Dk9wacjXHXZ2vzksSa8OSWDNuLkK+4lOLdOmPc=; b=NP/wWIdsBuvCI4fur1IEWKky461bIFRG7op7qLKecW2XkT8gvMZ2E0XgDk876FN01H lxSBW4R2JRWQLFq2AZwXQyQMSu53ExurT5Ye+oIQSdX3Nxa9ZC3haROrivTZVDSzcUq2 TGF0AoTS+QXdfkmofuvn/CkNn6Kxs/xeiCDBLUDXMKOKlLS9dqtnqNmZIAtWjYdRW6WO PL0QwIA3BgtRNED6BpJunhlO8VwL7GB0J5q0kfElsbDqVrstIklgg2k9Ahdlo2hTvf61 DhZb5IXpiBBEsnBu3cQuvJ2BJwXMrpSKANyDnxa3NZsolu6QgV6YhAlomRgIb1LNbJxd gKkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sbUO6Dk9wacjXHXZ2vzksSa8OSWDNuLkK+4lOLdOmPc=; b=OkRjBeMtScpyyIs5oxRKfmzi+ld+SwxxVzbLhKPvqK8iYuyARzyNPCid3h0A9gs40G KnmGffCbkARgOrbrEGU13TA/ODqNwht+Yod5ZXS9vzp9WMa4Tqo0sdEIYJO+7ZB7C50T k+bBfKNGaYQP0MLrPaH3pPXE9tjnVm5gCl0M6CDQ+AdprhmbVXYXrQ42wNI+ZB8Aey86 Uz93GuTLQ7QTA/b9KJOCumszRzbXjK7VnFHV7qyX21R1DV+sXQUv6+rckKH+4AF4zM3v LV7jcuWPpFoIDLkCB+J0XU6TpZ6GUcovIyp6b5GPShapKKOMVu2ok1GW0M56qPI1x3KL f64A== X-Gm-Message-State: ACrzQf3Tp/hF7taKg5J18UdvSju+MZVUMOVkAPXPgEoKVwHO7uVtWIv2 RJqQDWaSkK4NkY9g3dSpgOZ6Gw== X-Google-Smtp-Source: AMsMyM7k1nPOKOFdlc7vwxPWLFbFhF4RxUJr5xqjxVc0GYiDzbCYzF2K9vcTPnLs/uYo92+HPlMnzg== X-Received: by 2002:adf:d0c3:0:b0:22e:6ce8:f7a1 with SMTP id z3-20020adfd0c3000000b0022e6ce8f7a1mr11353672wrh.287.1666341529694; Fri, 21 Oct 2022 01:38:49 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:8104:adb4:5d77:2050? ([2a01:e0a:982:cbb0:8104:adb4:5d77:2050]) by smtp.gmail.com with ESMTPSA id i18-20020a5d5232000000b00236576c8eddsm329556wra.12.2022.10.21.01.38.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Oct 2022 01:38:49 -0700 (PDT) Message-ID: Date: Fri, 21 Oct 2022 10:38:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH] arm64: dts: meson: Enable active coling using gpio-fan on Odroid N2/N2+ To: Anand Moon , Martin Blumenstingl Cc: Rob Herring , Krzysztof Kozlowski , Kevin Hilman , Jerome Brunet , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221018195122.8877-1-linux.amoon@gmail.com> <402500e8-b4fe-9b8f-d634-e329191af1b8@linaro.org> Content-Language: en-US Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/10/2022 07:07, Anand Moon wrote: > Hi Martin / Neil, > > On Thu, 20 Oct 2022 at 02:10, Martin Blumenstingl > wrote: >> >> Hi Anand, >> >> On Wed, Oct 19, 2022 at 7:17 PM Anand Moon wrote: >> [...] >>>>> +&pwm_AO_ab { >>>> >>>> &pwm_AO_cd not _ab >>>> >>> No it has a conflict with CPU_B (vddcpu_b) PWM >> Uh, you're right. That's probably why the Hardkernel team uses a >> software based PWM implementation: [0] >> In hindsight they should have used a different pad either for VDDCPU_B >> or the fan. >> >> I think the most pragmatic approach (since the "GPIO PWM" driver is >> not upstream and I don't know if something like that would be accepted >> upstream) is to use a GPIO based fan as you did in your initial patch. >> Not sure what others think though. >> > > When I use gpio-fan I get the following output with gpioinfo > Feature it woks as expected. > > $ .sudo gpioinfo > .... > gpiochip1 - 15 lines: > line 0: unnamed unused input active-high > line 1: unnamed unused input active-high > line 2: unnamed "enable" output active-high [used] > line 3: unnamed unused input active-high > line 4: unnamed unused output active-high > line 5: unnamed unused input active-high > line 6: unnamed unused input active-high > line 7: unnamed unused input active-high > line 8: unnamed "regulator-tflash_vdd" output active-high [used] > line 9: unnamed "TF_IO" output active-high [used] > line 10: unnamed "gpio-fan" output active-high [used] > line 11: unnamed "n2:blue" output active-high [used] > line 12: unnamed unused input active-high > line 13: unnamed unused input active-high > line 14: unnamed unused input active-high > > When I am using pwm-fan using *pwm_ao_d_10_pins* pin is not getting > registered below hence it is not working on my end. It's expected because it's not used as a GPIO but another function, you should look in the pinctrl debugfs files to see it. > > $ .sudo gpioinfo > .... > gpiochip1 - 15 lines: > line 0: unnamed unused input active-high > line 1: unnamed unused input active-high > line 2: unnamed "enable" output active-high [used] > line 3: unnamed unused input active-high > line 4: unnamed unused output active-high > line 5: unnamed unused input active-high > line 6: unnamed unused input active-high > line 7: unnamed unused input active-high > line 8: unnamed "regulator-tflash_vdd" output active-high [used] > line 9: unnamed "TF_IO" output active-high [used] > line 10: unnamed unused output active-high > line 11: unnamed "n2:blue" output active-high [used] > line 12: unnamed unused input active-high > line 13: unnamed unused input active-high > line 14: unnamed unused input active-high > > Thanks > -Anand > > > > >> >> Best regards, >> Martin >> >> >> [0] https://github.com/hardkernel/linux/blob/c109dec94e7e819554830acfac4b6ed96e230179/arch/arm64/boot/dts/amlogic/meson64_odroidn2.dtsi#L356-L359