From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44442EB64D8 for ; Wed, 21 Jun 2023 14:37:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232161AbjFUOhk (ORCPT ); Wed, 21 Jun 2023 10:37:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232364AbjFUOhe (ORCPT ); Wed, 21 Jun 2023 10:37:34 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4E131BC1 for ; Wed, 21 Jun 2023 07:37:22 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3f9b4a71623so26858425e9.1 for ; Wed, 21 Jun 2023 07:37:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687358241; x=1689950241; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=E2nzgFJ0UcKKhFdBcJW4Qki5Cr7fODwtX2iLYSvqDVI=; b=ccwzO4T+YWCh07XgozjTsTDf6U+GyCB6iEINFXDkJru7rGYxyzEC83v6QXMbpJL4zb rjG2sP4D8l4afWsa3EDe7SahZUfGIFOljh9IREcgP8KD7orEyFnpwrsBwjpa3xrDseRC ulYIKU6IU7JF1Z8+5ohONTZ6y+/X/Nfq9snF3ryjM2sEHaOrUVc7o5lCA+nlTahwnKZ+ QWrP8rJgbyObPYW8V73KMWdBu9PopvzORu8aKcxnsUVYu2kG4KE9IBZltppkhi67+imn xVLd5BJrRIfDhrkMhya0DYFnGGlnPzwlOmbs1kdXvLmZAfsj2iTnRStXH2yxKYtPPO3a gRZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687358241; x=1689950241; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E2nzgFJ0UcKKhFdBcJW4Qki5Cr7fODwtX2iLYSvqDVI=; b=io1ctyqx/j8S0hrrH1jD/Ro3R1QPqmcs1/KhGVTXtRs3/ImYHEHS3pHraSE929pWt7 6XbDdMXCadVL9qvW1zcH1c1ikVrTzZSvsHAKJV/1DEehEjA5VDx3waYp1q5gRkhKGAYJ +lDmGlk1sAVxdcsO/RJpFxK0gMP/0p9/A9tpBr530V27yeZN3iPl8d6rhnm5sqK/apBx NerkuNtTT5xyxFkSHyKGVL3iPWNK40onMejiHc0sM2coNk3dO/5lhIFqkR+VWXO7IBwv 6lJmydcII+Qll2+S0FldtOih3d9aLD+A7mk2LGqfjz1hdzHEJ3U/ElNSFVV8rvUUjdCK IaUg== X-Gm-Message-State: AC+VfDzefyN7QtCygI+9r2wd3ISKrNSv891PhXuJ4QQheLvC6SpkHYYN LiI34NJ6noq8LDYbE0ltkHv98A== X-Google-Smtp-Source: ACHHUZ5Vmh48i0hExJ+5VdjCgnuo8egMvW9ckVo9v1TF1zTT3rT8zTjlJPeKKjV/+tC426+MW5Wi8g== X-Received: by 2002:a05:600c:22c6:b0:3f9:b1e7:8a4b with SMTP id 6-20020a05600c22c600b003f9b1e78a4bmr5652292wmg.21.1687358241393; Wed, 21 Jun 2023 07:37:21 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id r19-20020a05600c285300b003f605566610sm16131212wmb.13.2023.06.21.07.37.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jun 2023 07:37:20 -0700 (PDT) Message-ID: Date: Wed, 21 Jun 2023 16:37:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] arm64: dts: qcom: sm8350: fix BAM DMA crash and reboot Content-Language: en-US To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bhupesh Sharma , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Manivannan Sadhasivam References: <20230621143627.189134-1-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230621143627.189134-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/06/2023 16:36, Krzysztof Kozlowski wrote: > SM8350 HDK and MTP boards were silently dying and rebooting during BAM > DMA probe: > > [ 1.574304] vreg_bob: Setting 3008000-3960000uV > [ 1.576918] bam-dFormat: Log Type - Time(microsec) - Message - > Optional Info > Log Type: B - Since Boot(Power On Reset), D - Delta, S - Statistic > S - QC_IMAGE_VERSION_STRING=BOOT.MXF.1.0-00637.1-LAHAINA-1 > S - IMAGE_VARIANT_STRING=SocLahainaLAA > S - OEM_IMAGE_VERSION_STRING=crm-ubuntu77 > S - Boot Interface: UFS > > It seems that BAM DMA is locally controller (not by firmware) and > requires proper initialization by the driver prior to use, at least on > HDK8350 and MTP8350, but probably on all boards. > > Fixes: f1040a7fe8f0 ("arm64: dts: qcom: sm8350: Add Crypto Engine support") > Signed-off-by: Krzysztof Kozlowski > > --- > > Cc: Manivannan Sadhasivam > --- #regzbot fix: f1040a7fe8f069d2259ab3dab9190210005ceb33 Best regards, Krzysztof