From: tessolveupstream@gmail.com
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
andersson@kernel.org, konradybcio@kernel.org
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH v12 2/3] arm64: dts: qcom: talos/qcs615-ride: Fix inconsistent USB PHY node naming
Date: Thu, 15 Jan 2026 11:30:40 +0530 [thread overview]
Message-ID: <fce9ee85-bd84-4e5f-a2ef-81095b071895@gmail.com> (raw)
In-Reply-To: <444b2e30-5675-4a17-89dc-ca24ca3910d9@oss.qualcomm.com>
On 14-01-2026 15:49, Konrad Dybcio wrote:
> On 1/14/26 11:00 AM, Sudarshan Shetty wrote:
>> The USB PHY nodes has inconsistent labels as 'usb_1_hspy'
>> and 'usb_hsphy_2' across talos.dtsi and qcs615-ride.dts.
>> This patch renames them to follow a consistent naming
>> scheme.
>
> Sorry for only noticing this now, but usb_hsphy_x is wrong..
>
> *every* other dtsi uses usb_x_hsphy, please flip it around
>
> $ rg 'usb_1_hsphy' arch -l | wc -l
> 93
>
> $ rg 'usb_hsphy_1' arch -l | wc -l
> 0
>
I've updated the patch to use usb_x_hsphy naming
convention to match the rest of the devicetree files
as below:
diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
index 0ca6b50a6de1..a5f763cf1a55 100644
--- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
@@ -609,7 +609,7 @@ bluetooth {
};
};
-&usb_hsphy_1 {
+&usb_1_hsphy {
vdd-supply = <&vreg_l5a>;
vdda-pll-supply = <&vreg_l12a>;
vdda-phy-dpdm-supply = <&vreg_l13a>;
@@ -632,7 +632,7 @@ &usb_1_dwc3 {
dr_mode = "peripheral";
};
-&usb_hsphy_2 {
+&usb_2_hsphy {
vdd-supply = <&vreg_l5a>;
vdda-pll-supply = <&vreg_l12a>;
vdda-phy-dpdm-supply = <&vreg_l13a>;
diff --git a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
index 95ed335bcb08..a236f8a65937 100644
--- a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
+++ b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
@@ -556,7 +556,7 @@ &usb_1_dwc3 {
dr_mode = "host";
};
-&usb_hsphy_1 {
+&usb_1_hsphy {
vdd-supply = <&vreg_l5a>;
vdda-pll-supply = <&vreg_l12a>;
vdda-phy-dpdm-supply = <&vreg_l13a>;
@@ -572,7 +572,7 @@ &usb_2_dwc3 {
dr_mode = "host";
};
-&usb_hsphy_2 {
+&usb_2_hsphy {
vdd-supply = <&vreg_l5a>;
vdda-pll-supply = <&vreg_l12a>;
vdda-phy-dpdm-supply = <&vreg_l13a>;
diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi
index c7dc507a50b5..cb32bfe732fb 100644
--- a/arch/arm64/boot/dts/qcom/talos.dtsi
+++ b/arch/arm64/boot/dts/qcom/talos.dtsi
@@ -4304,7 +4304,7 @@ osm_l3: interconnect@18321000 {
#interconnect-cells = <1>;
};
- usb_hsphy_1: phy@88e2000 {
+ usb_1_hsphy: phy@88e2000 {
compatible = "qcom,qcs615-qusb2-phy";
reg = <0x0 0x88e2000 0x0 0x180>;
@@ -4319,7 +4319,7 @@ usb_hsphy_1: phy@88e2000 {
status = "disabled";
};
- usb_hsphy_2: phy@88e3000 {
+ usb_2_hsphy: phy@88e3000 {
compatible = "qcom,qcs615-qusb2-phy";
reg = <0x0 0x088e3000 0x0 0x180>;
@@ -4412,7 +4412,7 @@ usb_1_dwc3: usb@a600000 {
iommus = <&apps_smmu 0x140 0x0>;
interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
- phys = <&usb_hsphy_1>, <&usb_qmpphy>;
+ phys = <&usb_1_hsphy>, <&usb_qmpphy>;
phy-names = "usb2-phy", "usb3-phy";
snps,dis-u1-entry-quirk;
@@ -4476,7 +4476,7 @@ usb_2_dwc3: usb@a800000 {
iommus = <&apps_smmu 0xe0 0x0>;
interrupts = <GIC_SPI 664 IRQ_TYPE_LEVEL_HIGH>;
- phys = <&usb_hsphy_2>;
+ phys = <&usb_2_hsphy>;
phy-names = "usb2-phy";
snps,dis_u2_susphy_quirk;
(END)
};
- usb_hsphy_1: phy@88e2000 {
+ usb_1_hsphy: phy@88e2000 {
compatible = "qcom,qcs615-qusb2-phy";
reg = <0x0 0x88e2000 0x0 0x180>;
@@ -4319,7 +4319,7 @@ usb_hsphy_1: phy@88e2000 {
status = "disabled";
};
- usb_hsphy_2: phy@88e3000 {
+ usb_2_hsphy: phy@88e3000 {
compatible = "qcom,qcs615-qusb2-phy";
reg = <0x0 0x088e3000 0x0 0x180>;
@@ -4412,7 +4412,7 @@ usb_1_dwc3: usb@a600000 {
iommus = <&apps_smmu 0x140 0x0>;
interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
- phys = <&usb_hsphy_1>, <&usb_qmpphy>;
+ phys = <&usb_1_hsphy>, <&usb_qmpphy>;
phy-names = "usb2-phy", "usb3-phy";
snps,dis-u1-entry-quirk;
@@ -4476,7 +4476,7 @@ usb_2_dwc3: usb@a800000 {
iommus = <&apps_smmu 0xe0 0x0>;
interrupts = <GIC_SPI 664 IRQ_TYPE_LEVEL_HIGH>;
- phys = <&usb_hsphy_2>;
+ phys = <&usb_2_hsphy>;
phy-names = "usb2-phy";
snps,dis_u2_susphy_quirk;
Could you please confirm if this change aligns with your
expectation.
> Konrad
next prev parent reply other threads:[~2026-01-15 6:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 10:00 [PATCH v12 0/3] Add Qualcomm Technologies, Inc. Talos EVK SMARC support Sudarshan Shetty
2026-01-14 10:00 ` [PATCH v12 1/3] dt-bindings: arm: qcom: talos-evk: Add QCS615 Talos EVK SMARC platform Sudarshan Shetty
2026-01-14 10:00 ` [PATCH v12 2/3] arm64: dts: qcom: talos/qcs615-ride: Fix inconsistent USB PHY node naming Sudarshan Shetty
2026-01-14 10:19 ` Konrad Dybcio
2026-01-15 6:00 ` tessolveupstream [this message]
2026-01-16 10:06 ` Konrad Dybcio
2026-01-14 10:00 ` [PATCH v12 3/3] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board Sudarshan Shetty
2026-01-15 2:24 ` Jie Gan
2026-01-16 5:55 ` tessolveupstream
2026-01-16 7:54 ` Dmitry Baryshkov
2026-01-29 9:11 ` tessolveupstream
2026-02-04 2:58 ` Dmitry Baryshkov
2026-02-11 4:39 ` tessolveupstream
2026-01-15 8:23 ` yuanjiey
2026-01-28 11:59 ` Konrad Dybcio
2026-02-09 11:26 ` tessolveupstream
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fce9ee85-bd84-4e5f-a2ef-81095b071895@gmail.com \
--to=tessolveupstream@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox