From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Murphy Subject: Re: [PATCH 1/2] ARM: dts: exynos: Add dwc3 SUSPHY quirk Date: Tue, 19 Sep 2017 19:10:00 +0100 Message-ID: References: <1505728934-6200-1-git-send-email-andrzej.p@samsung.com> <1505728934-6200-2-git-send-email-andrzej.p@samsung.com> <20170919174038.2sspjvadt6ggka65@kozik-lap> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170919174038.2sspjvadt6ggka65@kozik-lap> Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Krzysztof Kozlowski , Andrzej Pietrasiewicz Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Bartlomiej Zolnierkiewicz , Greg Kroah-Hartman , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , Rob Herring , Kishon Vijay Abraham I , Kukjin Kim , Felipe Balbi , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Marek Szyprowski List-Id: devicetree@vger.kernel.org On 19/09/17 18:40, Krzysztof Kozlowski wrote: > On Mon, Sep 18, 2017 at 12:02:13PM +0200, Andrzej Pietrasiewicz wrote: >> Odroid XU4 board does not enumerate SuperSpeed devices. >> This patch makes exynos5 series chips use USB SUSPHY quirk, >> which solves the problem. >> >> Signed-off-by: Andrzej Pietrasiewicz >> --- >> arch/arm/boot/dts/exynos54xx.dtsi | 2 ++ >> 1 file changed, 2 insertions(+) > > Makes sense to me... was it tested also on XU3 and XU? Well, it at least doesn't make USB3 on my XU any more or less broken than it was before ;) (both ports still report an over-current condition even with nothing plugged in - I suspect there's probably still some pinctrl/regulator stuff missing) Robin. > > Best regards, > Krzysztof > >> >> diff --git a/arch/arm/boot/dts/exynos54xx.dtsi b/arch/arm/boot/dts/exynos54xx.dtsi >> index 0389e8a..8ca4fef 100644 >> --- a/arch/arm/boot/dts/exynos54xx.dtsi >> +++ b/arch/arm/boot/dts/exynos54xx.dtsi >> @@ -134,6 +134,7 @@ >> interrupts = ; >> phys = <&usbdrd_phy0 0>, <&usbdrd_phy0 1>; >> phy-names = "usb2-phy", "usb3-phy"; >> + snps,dis_u3_susphy_quirk; >> }; >> }; >> >> @@ -154,6 +155,7 @@ >> reg = <0x12400000 0x10000>; >> phys = <&usbdrd_phy1 0>, <&usbdrd_phy1 1>; >> phy-names = "usb2-phy", "usb3-phy"; >> + snps,dis_u3_susphy_quirk; >> }; >> }; >> >> -- >> 1.9.1 >> > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html