From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30B3EC77B7C for ; Thu, 4 May 2023 09:49:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229780AbjEDJtJ (ORCPT ); Thu, 4 May 2023 05:49:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229681AbjEDJtI (ORCPT ); Thu, 4 May 2023 05:49:08 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1D8F527C; Thu, 4 May 2023 02:48:34 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 418258016; Thu, 4 May 2023 17:48:22 +0800 (CST) Received: from EXMBX062.cuchost.com (172.16.6.62) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 4 May 2023 17:48:22 +0800 Received: from [192.168.125.107] (183.27.99.121) by EXMBX062.cuchost.com (172.16.6.62) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 4 May 2023 17:48:21 +0800 Message-ID: Date: Thu, 4 May 2023 17:48:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RESEND v2 1/6] dt-bindings: power: Add JH7110 AON PMU support Content-Language: en-US To: Krzysztof Kozlowski , Conor Dooley CC: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Paul Walmsley , Palmer Dabbelt , Albert Ou , Walker Chen , Hal Feng , , , , , References: <20230419-labored-camper-644d51a7ca96@spud> <1a5b15fa-4f20-51c2-2ba1-a04a2911a694@starfivetech.com> <20230424-baffle-punch-ec73098f2b6a@spud> <20230425-unquote-eligible-09f743d81981@wendy> <68cb565d-bf39-10b0-9e3e-35ba7f54b90b@linaro.org> <0988495f-b87a-7f69-f222-37c67d6eae23@starfivetech.com> <20230425-resale-footrest-de667778c4fe@wendy> <663e9933-b9b3-a48f-98b6-2207215a8ed7@starfivetech.com> <20230425-commotion-prewashed-876247bed4ab@spud> <0b0f9187-ad6b-a1d9-6ec4-beb8989ca731@starfivetech.com> <3ed72340-accc-4ad1-098f-4a2eb6448828@linaro.org> <482e812a-05dd-105c-189c-e926b4be9d28@starfivetech.com> <089e24d1-588a-4a56-f00b-0b35d1d99295@linaro.org> <1ac26c1a-1726-515d-6598-849a07ed0b86@linaro.org> <5adda0ad-965c-fbf0-878c-9d41d28b5c39@starfivetech.com> <86693969-59bf-5bcc-42a3-b6e94a0d6f3e@linaro.org> From: Changhuang Liang In-Reply-To: <86693969-59bf-5bcc-42a3-b6e94a0d6f3e@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.99.121] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX062.cuchost.com (172.16.6.62) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/5/4 17:36, Krzysztof Kozlowski wrote: > On 04/05/2023 10:43, Changhuang Liang wrote: >> >> >> On 2023/5/4 15:26, Krzysztof Kozlowski wrote: >>> On 04/05/2023 09:20, Changhuang Liang wrote: >>>>>> >>>>>> Krzysztof, >>>>>> >>>>>> I am confused about what to do next. How to add this power-controller's >>>>>> node in device tree? >>>>>> >>>>> >>>>> You just move power-domain-cells up. >>>>> >>>>> Best regards, >>>>> Krzysztof >>>>> >>>> >>>> Like this? >>>> >>>> aon_syscon: syscon@17010000 { >>>> compatible = "starfive,jh7110-aon-syscon", "syscon", "starfive,jh7110-aon-pmu"; >>>> reg = <0x0 0x17010000 0x0 0x1000>; >>>> #power-domain-cells = <1>; >>>> }; >>>> >>>> If right? I will tell the syscon patch's owner delete the "simple-mfd" in aon_syscon node. >>> >>> Yes, but your compatibles are now wrong. Just compatible = >>> "starfive,jh7110-aon-syscon", "syscon". >>> >> >> If compatible = "starfive,jh7110-aon-syscon", "syscon". My pmu drivers need use >> "starfive,jh7110-aon-syscon" to match. > > And how it would even work with your proposal > "starfive,jh7110-aon-syscon", "syscon", "starfive,jh7110-aon-pmu"? > > Try... > >> And my pmu series will add this >> aon_syscon in yaml and device tree, so the syscon patch's owner don't need >> to add the aon_syscon in its yaml and device tree? > > I don't understand. But if you need to drop syscon, sure, drop it. > Yes, I think it can drop aon_syscon node in syscon patch series. And maybe my compatible = "starfive,jh7110-aon-pmu", "syscon"; is better. aon_syscon: syscon@17010000 { compatible = "starfive,jh7110-aon-pmu", "syscon"; reg = <0x0 0x17010000 0x0 0x1000>; #power-domain-cells = <1>; }; Best regards, Krzysztof