From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C67B5C4332F for ; Mon, 12 Dec 2022 09:12:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231793AbiLLJMc (ORCPT ); Mon, 12 Dec 2022 04:12:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231795AbiLLJM2 (ORCPT ); Mon, 12 Dec 2022 04:12:28 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7B2BAE64 for ; Mon, 12 Dec 2022 01:12:26 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id g7so17488769lfv.5 for ; Mon, 12 Dec 2022 01:12:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qajxMeWKx//tvnIrgwzb8+4ROl0SWERL+/53UrfDDE0=; b=ctcaPhjow1/M/34rEWePItWNlAs0nKRgg0qb3cEaYlERzlNUB4s2ryTfVnMQVrk46r RBmlJvEvGMg7twPz8OfwJYL34wCCBjkhQPEkNd/tmTexMw77xsmC7ud/ESmKUgrChfK0 y4waJry3LzQaNsj5DnNNRI8zf1g+L4qYk0av70H+6dPMQiE5vebZfHQJcfPDZYcEqBBH 1jtr2yG1Iu6xtxzhhSvBZ9FbWXnN9KbY0weS7gJ/qU4n06DEtEW9azFZA+MOIG3OPjLO dl1Wt+CeMlaG8z775szojsBNzC75pVkxy/cTKXRXY9qzXnwC9fGva0f12vbEvqJdQkRS 2lNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qajxMeWKx//tvnIrgwzb8+4ROl0SWERL+/53UrfDDE0=; b=tOSRetwR8y+Ze9HmxU79NWNTSYSYkWyOz2DBktJnj0Dv7gvUzxArJMGQs4Rzwk+TEp bdD3/ZlqOc5o+/I3cyGRT1+oZ96u0Ct//v455MdNay9rqPOMXeowKI8HNw/6fM7lEE+z eIjCUIdzOWri3Gn1m/IyiiNO4NWzefd+7VyD0rdWYls9l8NlJLOgvmgGL3D1fp2mGpdf ZhtmUKqRmhZvV8NmpIOtRXFrRdrGRUb24do4pn7uUyaPhTriW9JrMyX6h8M+ICZE09bW ZeuoKaWRDifKRjXtubNbDX2qfe0K9izTweG5xFBRdYUCrUHZiQSAYTkLaA6v2Xg61anh iHBg== X-Gm-Message-State: ANoB5plfZzRGlvhXeuVWccx9UTGZVg+Pvs52zeNLZEL1yIE11VQb3IHM r68Fs/sZI5Myw5qcF0ewOJHJZ+3nxGBb050B X-Google-Smtp-Source: AA0mqf5Qe4dRffSeJqDkP1/xjf9TrqptQyuVwJp2GcprSREEEf69TdbzcAukywqo9X+dSH9zTx+kvA== X-Received: by 2002:a05:6512:2511:b0:4b6:ea42:de0d with SMTP id be17-20020a056512251100b004b6ea42de0dmr1122780lfb.39.1670836345337; Mon, 12 Dec 2022 01:12:25 -0800 (PST) Received: from [192.168.1.101] (abxh44.neoplus.adsl.tpnet.pl. [83.9.1.44]) by smtp.gmail.com with ESMTPSA id h3-20020a056512054300b004b551cdfe13sm1541670lfl.279.2022.12.12.01.12.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 01:12:24 -0800 (PST) Message-ID: Date: Mon, 12 Dec 2022 10:12:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 4/4] arm64: dts: qcom: sm8250: move sound and codec nodes out of soc Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221210115704.97614-1-krzysztof.kozlowski@linaro.org> <20221210115704.97614-4-krzysztof.kozlowski@linaro.org> <61b4b894-2c49-881f-c2eb-107e8e558232@linaro.org> From: Konrad Dybcio In-Reply-To: <61b4b894-2c49-881f-c2eb-107e8e558232@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11.12.2022 21:13, Krzysztof Kozlowski wrote: > On 10/12/2022 13:31, Konrad Dybcio wrote: >> >> >> On 10.12.2022 12:57, Krzysztof Kozlowski wrote: >>> The sound and codec nodes are not a property of a soc, but rather board >>> as it describes the sound configuration. >> * in this case, there exist SoC-internal codecs > > wcd9380 is not SoC internal, so to which codec you refer to? Sound node > is for sound configuration, not codec, and sound configuration is board > specific. Your patch is correct, this was a nit pertaining to the commit message, as it could suggest that all codecs should be moved out of /soc, which would not be the case for MMIO-mapped ones. Konrad > >> >> It also does not have unit >>> address: >>> >>> sm8250-hdk.dtb: soc@0: sound: {} should not be valid under {'type': 'object'} >>> >>> Signed-off-by: Krzysztof Kozlowski >>> --- >> Reviewed-by: Konrad Dybcio > > Best regards, > Krzysztof >