From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys wakeup again
Date: Tue, 11 Jul 2023 13:49:08 +0200 [thread overview]
Message-ID: <fd262c97-29fe-ecd3-52d4-9fcf1d9b63f2@linaro.org> (raw)
In-Reply-To: <20230711063011.16222-1-krzysztof.kozlowski@linaro.org>
On 11.07.2023 08:30, Krzysztof Kozlowski wrote:
> gpio-keys,wakeup is a deprecated property:
>
> m8250-sony-xperia-edo-pdx206.dtb: gpio-keys: key-camera-focus: Unevaluated properties are not allowed ('gpio-key,wakeup' was unexpected)
>
> Fixes: a422c6a91a66 ("arm64: dts: qcom: sm8250-edo: Rectify gpio-keys")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> It's a damn Groundhog day. I already fixed all the occurences in
> 77a7e3942871 ("arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys
> wakeup")!
> ---
Sorry.. this was an old lingering patch that I failed to retest.
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> index cd27794739a5..ecdc20bc10f5 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> @@ -60,7 +60,7 @@ key-camera-focus {
> gpios = <&pm8150b_gpios 2 GPIO_ACTIVE_LOW>;
> debounce-interval = <15>;
> linux,can-disable;
> - gpio-key,wakeup;
> + wakeup-source;
> };
>
> key-camera-snapshot {
> @@ -69,7 +69,7 @@ key-camera-snapshot {
> gpios = <&pm8150b_gpios 1 GPIO_ACTIVE_LOW>;
> debounce-interval = <15>;
> linux,can-disable;
> - gpio-key,wakeup;
> + wakeup-source;
> };
>
> key-vol-down {
next prev parent reply other threads:[~2023-07-11 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 6:30 [PATCH] arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys wakeup again Krzysztof Kozlowski
2023-07-11 11:49 ` Konrad Dybcio [this message]
2023-07-14 5:34 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd262c97-29fe-ecd3-52d4-9fcf1d9b63f2@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).