From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9347C0015E for ; Tue, 11 Jul 2023 11:49:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230494AbjGKLtO (ORCPT ); Tue, 11 Jul 2023 07:49:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230490AbjGKLtN (ORCPT ); Tue, 11 Jul 2023 07:49:13 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4011DE74 for ; Tue, 11 Jul 2023 04:49:12 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2b702319893so88717631fa.3 for ; Tue, 11 Jul 2023 04:49:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689076150; x=1691668150; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=syIX5f3BVplskvsPj2jqIH8Yzy7BC8OkHkFGG82RJ/w=; b=koGH/spMREVvPSOADIGliABI0/jUQmqUi2xVTQaOZHmwCn8DcsEmNa6zK3YAV1Sx5o ccjW1egfchB3GbYkCuEfiowAaHvqAD6jNeMornYuh6r+HfUMUuT0MsvkbdzEQCTATupi +vixRXoDNV2h7cnFvTzMe7nHWxAdpH78HG3flVMpueVFh4Bln5gkFK7XNrUwQ0qporeu BuZ7NDV3PQLfLP5ABgs9Ul9+KoO6WDBONCPkfET6g67oPZS/K4QhRsudmWAIenV0rssc n/nQKSgZIwh1Yfe/t55+EFSkqbHQgcIBnMRoAz6+xw6PNNgwRv6yeXfPlUxyd3Ibnus1 N0WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689076150; x=1691668150; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=syIX5f3BVplskvsPj2jqIH8Yzy7BC8OkHkFGG82RJ/w=; b=CcwYRrKsnhM6bEukdiKLqZudoJcBeApGgrI9YTYuJanJzCEvjfadiZ8ZNtFtl6HI72 jciF879rtStlQzlv5eTTCaYZ7q25rARfrVfdtkAC32JBZE/y3wkJqnYNIO4TD1r7GXRl 5vZ9I3MpAILy7eOUGivq/V7qDO/9s8XpjOTSck5btjt+7yzNndCQb2W/swhdDOCUMFGs 80NE43f3wMdxZHLMC1UDxGSV4roghPqKf3T2Jkya+EX8ho0zuych9XuzGLIE/aSzUaHR Dbg3zGqHYbv875xPqXcqpNygqG/uc/ZD0nVgaX6E2O/x7vo70Rxl+bBRFUIfd4V1NLWl oTxQ== X-Gm-Message-State: ABy/qLbW0upKmvXeI1oZdABtF0jl1era1qtXwGkPfgoxjhE7P/tgDLuI erURDKZMykKmupvEhtvTVexQySAfEBcb1M5RhosBNw== X-Google-Smtp-Source: APBJJlGrZarNyQ0bfbOBxKSRI1o5UGsXz+/5i/jS3Wsvlq23VlMMaZsOEkXx7H0ZYJWGj9E9P0Mrlg== X-Received: by 2002:a2e:9e58:0:b0:2b6:e12f:267 with SMTP id g24-20020a2e9e58000000b002b6e12f0267mr3092406ljk.5.1689076150497; Tue, 11 Jul 2023 04:49:10 -0700 (PDT) Received: from [192.168.1.101] (abyl96.neoplus.adsl.tpnet.pl. [83.9.31.96]) by smtp.gmail.com with ESMTPSA id j9-20020a2e8249000000b002b69f44646bsm425540ljh.17.2023.07.11.04.49.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jul 2023 04:49:10 -0700 (PDT) Message-ID: Date: Tue, 11 Jul 2023 13:49:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys wakeup again Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230711063011.16222-1-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20230711063011.16222-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11.07.2023 08:30, Krzysztof Kozlowski wrote: > gpio-keys,wakeup is a deprecated property: > > m8250-sony-xperia-edo-pdx206.dtb: gpio-keys: key-camera-focus: Unevaluated properties are not allowed ('gpio-key,wakeup' was unexpected) > > Fixes: a422c6a91a66 ("arm64: dts: qcom: sm8250-edo: Rectify gpio-keys") > Signed-off-by: Krzysztof Kozlowski > > --- > > It's a damn Groundhog day. I already fixed all the occurences in > 77a7e3942871 ("arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys > wakeup")! > --- Sorry.. this was an old lingering patch that I failed to retest. Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi > index cd27794739a5..ecdc20bc10f5 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi > @@ -60,7 +60,7 @@ key-camera-focus { > gpios = <&pm8150b_gpios 2 GPIO_ACTIVE_LOW>; > debounce-interval = <15>; > linux,can-disable; > - gpio-key,wakeup; > + wakeup-source; > }; > > key-camera-snapshot { > @@ -69,7 +69,7 @@ key-camera-snapshot { > gpios = <&pm8150b_gpios 1 GPIO_ACTIVE_LOW>; > debounce-interval = <15>; > linux,can-disable; > - gpio-key,wakeup; > + wakeup-source; > }; > > key-vol-down {