* [PATCH] arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys wakeup again
@ 2023-07-11 6:30 Krzysztof Kozlowski
2023-07-11 11:49 ` Konrad Dybcio
2023-07-14 5:34 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-11 6:30 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Marijn Suijten, linux-arm-msm,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
gpio-keys,wakeup is a deprecated property:
m8250-sony-xperia-edo-pdx206.dtb: gpio-keys: key-camera-focus: Unevaluated properties are not allowed ('gpio-key,wakeup' was unexpected)
Fixes: a422c6a91a66 ("arm64: dts: qcom: sm8250-edo: Rectify gpio-keys")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
It's a damn Groundhog day. I already fixed all the occurences in
77a7e3942871 ("arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys
wakeup")!
---
arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
index cd27794739a5..ecdc20bc10f5 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
@@ -60,7 +60,7 @@ key-camera-focus {
gpios = <&pm8150b_gpios 2 GPIO_ACTIVE_LOW>;
debounce-interval = <15>;
linux,can-disable;
- gpio-key,wakeup;
+ wakeup-source;
};
key-camera-snapshot {
@@ -69,7 +69,7 @@ key-camera-snapshot {
gpios = <&pm8150b_gpios 1 GPIO_ACTIVE_LOW>;
debounce-interval = <15>;
linux,can-disable;
- gpio-key,wakeup;
+ wakeup-source;
};
key-vol-down {
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys wakeup again
2023-07-11 6:30 [PATCH] arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys wakeup again Krzysztof Kozlowski
@ 2023-07-11 11:49 ` Konrad Dybcio
2023-07-14 5:34 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2023-07-11 11:49 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Marijn Suijten, linux-arm-msm,
devicetree, linux-kernel
On 11.07.2023 08:30, Krzysztof Kozlowski wrote:
> gpio-keys,wakeup is a deprecated property:
>
> m8250-sony-xperia-edo-pdx206.dtb: gpio-keys: key-camera-focus: Unevaluated properties are not allowed ('gpio-key,wakeup' was unexpected)
>
> Fixes: a422c6a91a66 ("arm64: dts: qcom: sm8250-edo: Rectify gpio-keys")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> It's a damn Groundhog day. I already fixed all the occurences in
> 77a7e3942871 ("arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys
> wakeup")!
> ---
Sorry.. this was an old lingering patch that I failed to retest.
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> index cd27794739a5..ecdc20bc10f5 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
> @@ -60,7 +60,7 @@ key-camera-focus {
> gpios = <&pm8150b_gpios 2 GPIO_ACTIVE_LOW>;
> debounce-interval = <15>;
> linux,can-disable;
> - gpio-key,wakeup;
> + wakeup-source;
> };
>
> key-camera-snapshot {
> @@ -69,7 +69,7 @@ key-camera-snapshot {
> gpios = <&pm8150b_gpios 1 GPIO_ACTIVE_LOW>;
> debounce-interval = <15>;
> linux,can-disable;
> - gpio-key,wakeup;
> + wakeup-source;
> };
>
> key-vol-down {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys wakeup again
2023-07-11 6:30 [PATCH] arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys wakeup again Krzysztof Kozlowski
2023-07-11 11:49 ` Konrad Dybcio
@ 2023-07-14 5:34 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2023-07-14 5:34 UTC (permalink / raw)
To: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Marijn Suijten, linux-arm-msm, devicetree,
linux-kernel, Krzysztof Kozlowski
On Tue, 11 Jul 2023 08:30:11 +0200, Krzysztof Kozlowski wrote:
> gpio-keys,wakeup is a deprecated property:
>
> m8250-sony-xperia-edo-pdx206.dtb: gpio-keys: key-camera-focus: Unevaluated properties are not allowed ('gpio-key,wakeup' was unexpected)
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys wakeup again
commit: b8fbeea0253211d97c579eae787274633d3eaf0d
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-14 5:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-11 6:30 [PATCH] arm64: dts: qcom: sm8250-sony-xperia: correct GPIO keys wakeup again Krzysztof Kozlowski
2023-07-11 11:49 ` Konrad Dybcio
2023-07-14 5:34 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).