From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9CF9ECAAA3 for ; Fri, 26 Aug 2022 17:40:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241831AbiHZRk2 (ORCPT ); Fri, 26 Aug 2022 13:40:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344930AbiHZRkX (ORCPT ); Fri, 26 Aug 2022 13:40:23 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FA7FE0E6 for ; Fri, 26 Aug 2022 10:40:17 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id q7so2888541lfu.5 for ; Fri, 26 Aug 2022 10:40:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=OTdc27ee6jSrb6BUWefWgtonG87QJUY3qmhGjbQcM9o=; b=RXmV26SRp6JLrCtA+SI6m7ulgY5sVdkzCAeNCuwfF+qmPjgknJENdubUmhtapnYta+ P4aEeukQwfu2z6s2CP+hHyAE+ft4N9uWPhv1Ta84x/KsOCv2WYmyf/B0E1PsBMuBw0xZ Ci1aPK9D7DPbsAczrbVCmb/2govUqFOBsZl3pnsa0f2tgsUYsBD5PtDBMCBg31Mq9B5o DjgFFcKZxBq7D8nA9vk5bPvVgCexttrcbYrEqa8UEiRDtn+SLA8kS+O5m6utB1NZqYqx rvuAWtnj2uZkTETPDZ5G8G9uuCaxFfW9vRm2XAH+uTPfCWPY8Zrvwvl2ilH/uJn+yBhk yJlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=OTdc27ee6jSrb6BUWefWgtonG87QJUY3qmhGjbQcM9o=; b=hR81Q0auucMT416eGfCqA8ZDD+pWqFRoBfLrCpn9FKkqwR7Bj9qTsnxMw53xaJm1CZ uMMbZG03q/31mryI7IOcI3/8lHqnr9i3c3z0emQREUwqFL3OdmpYI1cMkcpA8hyg16Wa vEix18C6oL8LkPNtdNBaVeNEuDATzQWJOyZK7gKqRYQeENADGTfvGdz9AcYHDxkGZT8K ifAHBoPIBF5EFePbSwcmrlucsGEY18LLVEYJOyCy3QgWAYJKz7YtifsWAq+lFyDOQvis pzQbrbtXOrDiaX6b4c8RlbyH9BXgiLrwQ27NUy/E1gCF8qEesALn7jgeMIA9GAa3Dj2x VONA== X-Gm-Message-State: ACgBeo1tblkkEg+61efBhSxaEBV88tgJjH5S5YOYgxFtNqqnxDmkRtkO rYziONoNahofO7iogDl4yZG4uQ== X-Google-Smtp-Source: AA6agR7LN4RGaM5qPxnsCAzc7OIKFH1FnfWKbhbLHWggszDp6UWrWAHHSAubsHoPD0z7IhpDHQRdpg== X-Received: by 2002:a19:9149:0:b0:492:cb89:ecc4 with SMTP id y9-20020a199149000000b00492cb89ecc4mr2619171lfj.447.1661535614991; Fri, 26 Aug 2022 10:40:14 -0700 (PDT) Received: from [192.168.0.71] (82.131.98.15.cable.starman.ee. [82.131.98.15]) by smtp.gmail.com with ESMTPSA id o10-20020ac24e8a000000b0048b08124139sm431721lfr.177.2022.08.26.10.40.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Aug 2022 10:40:14 -0700 (PDT) Message-ID: Date: Fri, 26 Aug 2022 20:40:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2] arm64: dts: meson-s4: include meson-s4-gpio.h Content-Language: en-US To: Huqiang Qin , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, narmstrong@baylibre.com, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220826122338.2452433-1-huqiang.qin@amlogic.com> From: Krzysztof Kozlowski In-Reply-To: <20220826122338.2452433-1-huqiang.qin@amlogic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/08/2022 15:23, Huqiang Qin wrote: > In the future, meson-s4.dtsi will have some nodes that need > to use the meson-s4-gpio.h file. > > e.g. > * Bluetooth enable pin: > bt_en-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>; > * Audio mute pin: > spk_mute-gpios = <&gpio GPIOH_8 GPIO_ACTIVE_LOW>; > * ... Then the header should be added when the need is implemented. Do not add unused headers to files. Best regards, Krzysztof