From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from shout11.mail.de (shout11.mail.de [62.201.172.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71BC71E886; Sun, 16 Jun 2024 22:15:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.201.172.57 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718576159; cv=none; b=aAT9nVN4YC9gHKS2EcNhen+v4jAVtytdKZA9JRV9Ka+MwfUyx16/6pBTj9GXgPYGfCrt8f1vPt4x2i3BLLzjWXqF1+0dsbTdATqkCbL9Q5EhY64xxR9EZSYdnvFjzRrFA+IRAKFASpPYhEV2lz0tMzgqwgB3eu29mE9CEU2JneE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718576159; c=relaxed/simple; bh=rPKyJRPNQHEri6DUYtwLA2PV9+52zslI4JC0bsjOPsQ=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=Ude4+2E91m/THJN8gLhaCl7UQSmEg+7lqqU2QNQM6U9B8LRbHrVDPbwA3+jhTYxlOvMSIfAHK0qemgTNAWnysuS0JYxAidcAIwuFRasqAQ0Dw/zs2m6CVpoUucNw+uEXV9SH7P8brXv7H7fDwEJyBCWzP+Ox1ROBkKP5hXH6qYU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mail.de; spf=pass smtp.mailfrom=mail.de; dkim=pass (2048-bit key) header.d=mail.de header.i=@mail.de header.b=7GQbT9Sk; arc=none smtp.client-ip=62.201.172.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mail.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mail.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mail.de header.i=@mail.de header.b="7GQbT9Sk" Received: from shout02.mail.de (unknown [10.0.120.222]) by shout11.mail.de (Postfix) with ESMTPS id 88A70240BD1; Mon, 17 Jun 2024 00:15:55 +0200 (CEST) Received: from postfix01.mail.de (postfix01.bt.mail.de [10.0.121.125]) by shout02.mail.de (Postfix) with ESMTP id 6C679240BC7; Mon, 17 Jun 2024 00:15:55 +0200 (CEST) Received: from smtp01.mail.de (smtp02.bt.mail.de [10.0.121.212]) by postfix01.mail.de (Postfix) with ESMTP id 4C924801B2; Mon, 17 Jun 2024 00:15:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mail.de; s=mailde202009; t=1718576155; bh=rPKyJRPNQHEri6DUYtwLA2PV9+52zslI4JC0bsjOPsQ=; h=Message-ID:Date:Subject:From:To:Cc:From:To:CC:Subject:Reply-To; b=7GQbT9Sk2GkiUaYehTt0B0nbQpIuKnRTk/ZgBTts8tH7l6aOTqWBidPwkY7z+TbV5 fHq0eaRWpkBTOg6JGqRhQcC1DCWPxiPkM9oJ+1TEYALrKr60gUIH50MPhnVcD3fkgi TqhQ65SaVB3nCSazMkkQhlnUqVV0xIMxQkYqiinQDeSMuJkp3NWfNTmgO4CSSbooHS 4kxwil1aboGibj79OnC1n/pnQpmRYCCd6NvG7hz066TlGQTiAkOj4pHnHgYAIzyfho 7ZF5gILFkHXFd8TE6jhfDpTYr4kLXqtqbeLOxSEEp1tEXWXmyerzE2Q45Ssp1DAvP8 LJJZR27jM/x6A== Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp01.mail.de (Postfix) with ESMTPSA id B1C65240A21; Mon, 17 Jun 2024 00:15:54 +0200 (CEST) Message-ID: Date: Mon, 17 Jun 2024 00:15:54 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH 0/2] RK3588: FriendlyElec CM3588 NAS board support From: Sebastian Kropatsch To: Heiko Stuebner Cc: linux-rockchip@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240616215354.40999-1-seb-dev@mail.de> In-Reply-To: <20240616215354.40999-1-seb-dev@mail.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate: clean X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate: clean X-purgate-size: 4287 X-purgate-ID: 154282::1718576155-9252C878-2F03AADF/0/0 Apologies for any confusions, this patch series is v4. The correct subject line is: [PATCH v4 0/2] RK3588: FriendlyElec CM3588 NAS board support Apparently "git send-email -v4" doesn't add the version tag if you haven't already added it with "git format-patch" :) Cheers, Sebastian Am 16.06.2024 um 23:48 schrieb Sebastian Kropatsch: > Hello! > > This adds support for the FriendlyElec CM3588 NAS board. > The board's device tree makes use of the latest upstream advances on the > RK3588 like USB3 DRD and GPU support as well as the latest Rockchip PCIe > driver bifurcation fixes, but some features such as thermal management > and HDMI will have to be added later when SoC support for these features > is merged. > > Issues: > 1) pcie3x4 BAR 1 fails to assign, see dmesg: > pci 0000:00:00.0: BAR 0 [mem 0x900000000-0x93fffffff]: assigned > pci 0000:00:00.0: BAR 1 [mem size 0x40000000]: can't assign; no space > pci 0000:00:00.0: BAR 1 [mem size 0x40000000]: failed to assign > > 2) The device enumeration of NVMe SSDs plugged into the four PCIe M.2 > slots does not follow the order of the slots on the board: The slots are > physically named from 1 to 4, top to bottom. However, they do not show > up in this same order in Linux when all slots are polulated: > - SSD in physical slot 1 shows up as nvme0 > - SSD in physical slot 2 shows up as nvme2 > - SSD in physical slot 3 shows up as nvme1 > - SSD in physical slot 4 shows up as nvme3 > This is the same order in which the data lanes are mapped for PCIe > bifurcation (dts property: data-lanes = <1 3 2 4>). > I could not solve this by using aliases for the PCIe nodes in the device > tree. Perhaps this is something that can only be solved at driver level? > I am not sure if this behaviour is even considered a bug or if this is > intended behaviour by design. > > Devicetree validation: > `make CHECK_DTBS=y rockchip/rk3588-cm3588-nas.dtb` does not give any > warnings or errors, tested on Linux next-20240613. > > Cheers, > Sebastian > > --- > > Changes v3 -> v4: > - add pwm-beeper node > - add ir-receiver node > - leds: remove deprecated label props > - usbdp_phy0: add mode-switch prop > - minor fixes/comments > - collect r-b tag for patch 2 > - v3: https://lore.kernel.org/linux-rockchip/20240609222428.134977-1-seb-dev@mail.de/ > > Changes v2 -> v3: > - add vmmc-supply and vqmmc-supply to &sdhci > - remove duplicate combphys > - add 4 times the same regulator for PCIe to reflect the schematics > - fix USB vcc_5v0_host_30_p2 to use 5V as per schematics > - usb-c-connector: disable sink power delivery, enable only source mode > - &u2phy0_otg: add phy-supply > - rename some nodes > - minor fixes and some additional helpful comments (some sugg. by Space Mayer) > - collect a-b tag for patch 1 > - v2: https://lore.kernel.org/linux-rockchip/20240602211901.237769-1-seb-dev@mail.de/ > > Changes v1 -> v2: > - split dts into two files (CM and carrier board) > - rename fixed regulators with preferred 'regulator-' prefix > - use preferred 'gpios' property instead of 'gpio' > - add 'pinctrl-names' property for every pinctrl > - add several pwm nodes > - drop HMDI PHY and VOP support > - drop unneeded &wdt node > - remove i2c4 since it's not availabe according to the schematics > - &sdhci: drop 'full-pwr-cycle-in-suspend' flag > - &sdmmc: drop 'cap-mmc-highspeed' flag because of no-mmc > - &sdmmc: drop 'cd-gpios' property, unneeded w/ using sdmmc_det pinctrl > - &usb_host0_xhci, &usb_host2_xhci: remove default 'dr_mode' property > > --- > > Sebastian Kropatsch (2): > dt-bindings: arm: rockchip: Add FriendlyElec CM3588 NAS > arm64: dts: rockchip: Add FriendlyElec CM3588 NAS board > > .../devicetree/bindings/arm/rockchip.yaml | 7 + > arch/arm64/boot/dts/rockchip/Makefile | 1 + > .../rk3588-friendlyelec-cm3588-nas.dts | 778 ++++++++++++++++++ > .../rockchip/rk3588-friendlyelec-cm3588.dtsi | 653 +++++++++++++++ > 4 files changed, 1439 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588-nas.dts > create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-friendlyelec-cm3588.dtsi >