From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alina Yu <alina_yu@richtek.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC
Date: Thu, 20 Jul 2023 10:38:16 +0200 [thread overview]
Message-ID: <fd37e408-34d2-8fd3-31b7-b3a07dfb9817@linaro.org> (raw)
In-Reply-To: <20230720080728.GA10433@linuxcarl2.richtek.com>
On 20/07/2023 10:07, Alina Yu wrote:
> Hi,
> Krzysztof:
>
> On Wed, Jul 19, 2023 at 11:44:45AM +0200, Krzysztof Kozlowski wrote:
>> On 19/07/2023 11:24, alina_yu@richtek.com wrote:
>>> From: alinayu <alina_yu@richtek.com>
>>>
>>> Add bindings for Richtek RTQ2208 IC controlled SubPMIC
>>>
>>> Signed-off-by: Alina Yu <alina_yu@richtek.com>
>>> ---
>>> v4
>>> - Modify filename to "richtek,rtq2208"
>>> - Add more desciptions for "regulator-allowed-modes"
>
> ...
>
>>> +
>>> + regulator-mode:
>>> + enum: [0, 1]
>>> + description:
>>> + describe buck initial operating mode in suspend state.
>>
>> There is no such property on this level. Aren't you mixing initial one?
>
> It's the initial mode in suspend-mem state, should I modify that like this ?
> patternProperties:
> "^regulator-state-(standby|mem|disk)$":
> type: object
> $ref: regulator.yaml#
> properties:
> regulator-mode:
> enum: [0, 1]
> description:
> describe byck initial operating mode in suspend state.
Please check how other bindings do it.
> ...
>
>>
>>> + enum: [ 900000, 1200000, 1800000, 3300000 ]
>>> + description:
>>> + the fixed voltage in micro volt which is decided at the factory.
>>
>> I don't understand this property. Why this is different from min/max
>
>
> Because ldo has fixed voltage, so I thinks I could use a property to
> represent the fixed voltage directly. Do you suggest me modifying that like this:
>
> regulator-min-microvolt = <900000>;
> regulator-max-microvolt = <900000>;
>
> Using min voltage equals to max voltage to represent fixed voltage, instead of self-defined property ?
Yes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-20 8:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 9:24 [PATCH v4 0/2] Add Richtek RTQ2208 SubPMIC support alina_yu
2023-07-19 9:24 ` [PATCH v4 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC alina_yu
2023-07-19 9:44 ` Krzysztof Kozlowski
2023-07-20 8:07 ` Alina Yu
2023-07-20 8:38 ` Krzysztof Kozlowski [this message]
2023-07-21 6:27 ` Alina Yu
2023-07-24 2:23 ` Alina Yu
2023-07-19 10:43 ` Rob Herring
2023-07-19 9:24 ` [PATCH v4 2/2] regulator: rtq2208: Add Richtek RTQ2208 SubPMIC driver alina_yu
2023-07-19 17:08 ` Mark Brown
2023-07-20 17:55 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd37e408-34d2-8fd3-31b7-b3a07dfb9817@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alina_yu@richtek.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).