From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 390E2C04E69 for ; Thu, 20 Jul 2023 08:57:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230450AbjGTI5a (ORCPT ); Thu, 20 Jul 2023 04:57:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229589AbjGTIiV (ORCPT ); Thu, 20 Jul 2023 04:38:21 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1563B19BE for ; Thu, 20 Jul 2023 01:38:20 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-98e011f45ffso85861466b.3 for ; Thu, 20 Jul 2023 01:38:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689842298; x=1692434298; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=E0hr0LCgc9WMn+CUZSv9Kigz3HQbdZYh5sDSa/c1lIE=; b=v4qQBUsFbsxa+hbb4GT0mu/nuEWQGV2Q6oUe7R8IC5Tvk3rtWLT2aUmAd8lqBECEtF YEmry70ZZmiiMYc0wqk2iZmav2sWjLctiY35Ib2IL7+UKrmU3fkTGeAEKTjGVbOA/ljJ 1cIYCkWVq+lZ479MLw2ouQzjnDGxfdZWWsV6fUQpJGLjh2rG+NaRV2fsmzrqNBpelc4H ixQ1HBCxqP6mObNlDPoWuNxlMvgnt9iOdllNwJSoVvv3LSub32S4xgU0mGBX+Dc8EAkJ a+xHcasnC5My0AcPIAvGSlw0hxmOoMc15kzd2LvvsL9OblV+NaA33rcnasHaGO9Gi7+5 U0+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689842298; x=1692434298; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E0hr0LCgc9WMn+CUZSv9Kigz3HQbdZYh5sDSa/c1lIE=; b=Rrk8ANJgqKNkk+tWpEHUHRsIJbzCZuqAara8gEfldANN7nCcbPS2gMQNufC7aF0Xeu Tk76g6Fq5UxC+kkKxhhQPPjHfjOCjPix6csoSjpNDxv+1WoNDt5BEB7IT6TnbkyggJv7 bkn+fSJwtgEJZ0hTpHJFqZzD1MGlmsQ262yMg5wJVSfkuM1JvmXd0/CSwfNfT/TOT7Dc 2jWK2wnAOoQW1YV7OhpNKej5Rw0co6I/wpS9XbTaz3IZceXRgKJl9UH9H7SJU7+k7NHt zQjKygGGx7VcN0rAt/UuZMvXaWNwlAMnD5SGb7sINHkZpWxHrosK6jTt3kqjQxmPsZ87 B4lw== X-Gm-Message-State: ABy/qLbk07+Usiuar5Ms+ORkvtPziqhbygYkcXlCmCfKrBHm15qGP6tq cGXUBSum3SR74QpxVw0ighywxA== X-Google-Smtp-Source: APBJJlHaF+MqFiiKhZpFpwKmpcOzsc8zeLgUPDCYXCDkleXcF8WUygHP6/jdhKAq0bv18qDtUWIg9Q== X-Received: by 2002:a17:906:1091:b0:993:8d16:4c22 with SMTP id u17-20020a170906109100b009938d164c22mr4693862eju.75.1689842298563; Thu, 20 Jul 2023 01:38:18 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id va6-20020a17090711c600b00992c4103cb5sm347683ejb.129.2023.07.20.01.38.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jul 2023 01:38:18 -0700 (PDT) Message-ID: Date: Thu, 20 Jul 2023 10:38:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC Content-Language: en-US To: Alina Yu Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <1689758686-14409-1-git-send-email-alina_yu@richtek.com> <1689758686-14409-2-git-send-email-alina_yu@richtek.com> <44b50616-a6ee-76e4-21b8-3e39b1a2ccd1@linaro.org> <20230720080728.GA10433@linuxcarl2.richtek.com> From: Krzysztof Kozlowski In-Reply-To: <20230720080728.GA10433@linuxcarl2.richtek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/07/2023 10:07, Alina Yu wrote: > Hi, > Krzysztof: > > On Wed, Jul 19, 2023 at 11:44:45AM +0200, Krzysztof Kozlowski wrote: >> On 19/07/2023 11:24, alina_yu@richtek.com wrote: >>> From: alinayu >>> >>> Add bindings for Richtek RTQ2208 IC controlled SubPMIC >>> >>> Signed-off-by: Alina Yu >>> --- >>> v4 >>> - Modify filename to "richtek,rtq2208" >>> - Add more desciptions for "regulator-allowed-modes" > > ... > >>> + >>> + regulator-mode: >>> + enum: [0, 1] >>> + description: >>> + describe buck initial operating mode in suspend state. >> >> There is no such property on this level. Aren't you mixing initial one? > > It's the initial mode in suspend-mem state, should I modify that like this ? > patternProperties: > "^regulator-state-(standby|mem|disk)$": > type: object > $ref: regulator.yaml# > properties: > regulator-mode: > enum: [0, 1] > description: > describe byck initial operating mode in suspend state. Please check how other bindings do it. > ... > >> >>> + enum: [ 900000, 1200000, 1800000, 3300000 ] >>> + description: >>> + the fixed voltage in micro volt which is decided at the factory. >> >> I don't understand this property. Why this is different from min/max > > > Because ldo has fixed voltage, so I thinks I could use a property to > represent the fixed voltage directly. Do you suggest me modifying that like this: > > regulator-min-microvolt = <900000>; > regulator-max-microvolt = <900000>; > > Using min voltage equals to max voltage to represent fixed voltage, instead of self-defined property ? Yes. Best regards, Krzysztof