From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECBAF1C7B82 for ; Fri, 6 Sep 2024 09:12:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725613973; cv=none; b=R+/XhaLsWEyodV9OrJujPaBSKmGA1Una/w1umIGFvQmFN+jvCkhaaduFOdMmdrgIxqS0uHxQxL2n5bwQH0fQNLH7rQbsCk3jdeUwUqoLcb6x7Jol9dSWamMaluS0yVUM8MfFF3CbBUVVp/1Z7MFM+Tz2sTIAjaOEkywG4ck7I20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725613973; c=relaxed/simple; bh=3P4U2c/xG3RMaKJu/FZmMqv7gk2YDpQyenJgLHL65qY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tZji/2BumjMT2kHZrDgVV6db8A5VMsZn6RE+jTFw0pkVQyJeo9ei1Tb+oXzVar1uQiKaVD7ikVvHwguxQwm5t+EBnyEhmPte1P3Vft7b25MrGvvPj5dEQENugCLFvHuga4G8b/L5UHchqo1wgmsjvqJo+iQ/lBw5SFc9cTCLcXA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Yb8Oxr65; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Yb8Oxr65" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-371941bbfb0so1122744f8f.0 for ; Fri, 06 Sep 2024 02:12:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1725613969; x=1726218769; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8s+UppKbAeqOL7Uk1qqGcQjsJvrUCCT+GeLwSOaPGy8=; b=Yb8Oxr659fNszjDv80UTSEkMADBUHAq4S6pyztDn/p1j3W6tmS5vwkb63yzL+YzacQ zWWfR78zykAv+9BG8MELVfq4CMFk7BNZlMDjjREquFAmhfe6ZKrW8TmF9+InA7554VLI C/pUsNxnDenTDX5dc1/haFcoGhPtG8Law6dov8X+9XPmcWn248NlJygArB6lNaA5/GXH liLfIgV4Y5eM1woBkJ+cWClESoj+XTwe94Zc5WLbg7gcwZsQgCD9Cz8mpDwVbVhe6Ino 1gjFhAnSmWpjsCb9vx2sOW/zZF/L/Ax2TyjuzM5RfoB9qACLwY36+Q7zKQeaaRHGKa9f 2LyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725613969; x=1726218769; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8s+UppKbAeqOL7Uk1qqGcQjsJvrUCCT+GeLwSOaPGy8=; b=Rd+hAXpbMmt8tBnX+t5CYmXQPtwz+HP57HNH9mKjtHiKUVtqMtwMkxKM5F0SVap/H+ 56ax+PfXNPiH4wX4vG03ORiuqrbuqJIgHpHxDmg0eudubqYjbuzbRBtF7g2/h562s+ja JCQKl/rRKbUek4qnx3nNliI7Im9v7P7OIxxqx8+j/XF/4ehmBNmvc5bDMsEAFT//wloz HYFw3+rvd4kztyxjxKenBYEqMuHmO4MOFLlBkgxHz9RuJzICf3ghxcLCQg7npWJFTpd+ gflVe8I0iiTlwcGjKh1Ce4PgF6EuK3PwGBw1LUUM21HxP3ggxvsu3seiFGBTJDl31pxh C/Pg== X-Forwarded-Encrypted: i=1; AJvYcCVZA5CqniV9tyhqa9I6aKaeVhPp1psQ1tbbWKehkNNy9dPiSjMF7/zCtfCG3qAMK6FPQkGiU4XW45On@vger.kernel.org X-Gm-Message-State: AOJu0YyRCxq+A60Goe01O/+rfg18xRYk7tgB0AM4Cwy+MktPVPUnBIHI ts54QX3YZYzV80sVxPw8L3RvaVhI+Usi9Rc/BNniD1QzlD97m+cI19nK5u0v0EtGn1PC3pEYQmZ s X-Google-Smtp-Source: AGHT+IFb8h9Am+OxujV9k6mxhWxZfBdfSFD5yvzHGeIL2yjli1dhEsNM1lVw5wVFjsaybqLmFMEcNg== X-Received: by 2002:a05:6000:1fa7:b0:374:c847:85e with SMTP id ffacd0b85a97d-374c8470bbamr14020255f8f.13.1725613969139; Fri, 06 Sep 2024 02:12:49 -0700 (PDT) Received: from [192.168.0.2] (host-95-233-232-76.retail.telecomitalia.it. [95.233.232.76]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3749ef81146sm21321686f8f.82.2024.09.06.02.12.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Sep 2024 02:12:48 -0700 (PDT) Message-ID: Date: Fri, 6 Sep 2024 11:11:36 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/9] dt-bindings: iio: dac: add ad3552r axi-dac compatible To: Krzysztof Kozlowski Cc: Lars-Peter Clausen , Michael Hennerich , =?UTF-8?Q?Nuno_S=C3=A1?= , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Olivier Moysan , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner References: <20240905-wip-bl-ad3552r-axi-v0-iio-testing-v2-0-87d669674c00@baylibre.com> <20240905-wip-bl-ad3552r-axi-v0-iio-testing-v2-5-87d669674c00@baylibre.com> Content-Language: en-US From: Angelo Dureghello In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Krzysztof, On 06/09/24 9:22 AM, Krzysztof Kozlowski wrote: > On Thu, Sep 05, 2024 at 05:17:35PM +0200, Angelo Dureghello wrote: >> From: Angelo Dureghello >> >> Add a new compatible for the ad3552r variant of the generic DAC IP. >> >> The ad3552r DAC IP variant is very similar to the generic DAC IP, >> register map is the same, but some register fields are specific to >> this IP, and also, a DDR QSPI bus has been included in the IP. >> >> Signed-off-by: Angelo Dureghello >> --- >> Documentation/devicetree/bindings/iio/dac/adi,axi-dac.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,axi-dac.yaml b/Documentation/devicetree/bindings/iio/dac/adi,axi-dac.yaml >> index a55e9bfc66d7..c0cccb7a99a4 100644 >> --- a/Documentation/devicetree/bindings/iio/dac/adi,axi-dac.yaml >> +++ b/Documentation/devicetree/bindings/iio/dac/adi,axi-dac.yaml >> @@ -24,6 +24,7 @@ properties: >> compatible: >> enum: >> - adi,axi-dac-9.1.b >> + - adi,axi-dac-ad3552r > I am sorry, but what is the product here? It looks like either wrong > order or even completely redundant. What is ad3552r? > > And why versions are mixed with real products but without any > compatibility. What does the version express in such case? dac-ad3552r IP (fpga) is a variant of the dac IP, very similar, about the version, it still reads as 9.1.b so i can eventually change it to: adi,axi-dac-ad3552-9.1.b Should be more correct. > Best regards, > Krzysztof > -- ,,, Angelo Dureghello :: :. BayLibre -runtime team- Developer :`___: `____: