From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Devi Priya <quic_devipriy@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, lee@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
thierry.reding@gmail.com, ndesaulniers@google.com,
trix@redhat.com, baruch@tkos.co.il,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
linux-pwm@vger.kernel.org, nathan@kernel.org
Subject: Re: [PATCH V15 0/4] Add PWM support for IPQ chipsets
Date: Wed, 18 Oct 2023 23:05:46 +0200 [thread overview]
Message-ID: <fd64faf0-a149-400d-8cb7-244253c917d7@linaro.org> (raw)
In-Reply-To: <20231018205232.p5d4xaqsd5fcbvfi@pengutronix.de>
On 18/10/2023 22:52, Uwe Kleine-König wrote:
> Hello,
>
> On Wed, Oct 18, 2023 at 06:29:30PM +0200, Krzysztof Kozlowski wrote:
>> On 05/10/2023 18:05, Devi Priya wrote:
>>> Add PWM driver and binding support for IPQ chipsets.
>>> Also, add support for pwm node in ipq6018.
>>>
>>
>> You need to clearly mark dependencies.
>
> This is something I wouldn't blame Devi for. The dependency is not very
> obvious and its kind of normal and expected for a patch series to have
> dependencies. *shrug*
>
>> Next is now broken because of this patchset.
>
> If I understand correctly this affects "only" the dtb check targets,
> right? Is this bad enough that it needs an urgent fix? I would expect it
> doesn't hurt much, am I right here?
>
> I just looked into patch #2 and had a few comments for it.
Check/Tests of bindings (make dt_binding_check) has warnings because of
missing PWM schema.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-10-18 21:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 16:05 [PATCH V15 0/4] Add PWM support for IPQ chipsets Devi Priya
2023-10-05 16:05 ` [PATCH V15 1/4] pwm: driver for qualcomm ipq6018 pwm block Devi Priya
2023-10-19 8:29 ` Uwe Kleine-König
2023-10-05 16:05 ` [PATCH V15 2/4] dt-bindings: pwm: add IPQ6018 binding Devi Priya
2023-10-18 20:46 ` Uwe Kleine-König
2023-10-20 15:14 ` Rob Herring
2023-10-20 15:29 ` Kathiravan Thirumoorthy
2023-10-20 15:39 ` Uwe Kleine-König
2023-10-05 16:05 ` [PATCH V15 3/4] dt-bindings: mfd: qcom,tcsr: Add simple-mfd support for IPQ6018 Devi Priya
2023-10-12 10:06 ` (subset) " Lee Jones
2023-10-19 21:06 ` Rob Herring
2023-10-23 9:50 ` Lee Jones
2023-10-05 16:05 ` [PATCH V15 4/4] arm64: dts: qcom: ipq6018: add pwm node Devi Priya
2023-10-12 10:06 ` [PATCH V15 0/4] Add PWM support for IPQ chipsets Lee Jones
2023-10-12 10:25 ` Lee Jones
2023-10-18 16:29 ` Krzysztof Kozlowski
2023-10-18 20:52 ` Uwe Kleine-König
2023-10-18 21:05 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd64faf0-a149-400d-8cb7-244253c917d7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=baruch@tkos.co.il \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=quic_devipriy@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=trix@redhat.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).