From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema
Date: Tue, 27 Dec 2022 12:22:49 +0100 [thread overview]
Message-ID: <fd6fbdba-12e9-724f-8e0d-ac60035bd19d@linaro.org> (raw)
In-Reply-To: <20221224154255.43499-1-krzysztof.kozlowski@linaro.org>
On 24.12.2022 16:42, Krzysztof Kozlowski wrote:
> The node names should be generic and the bindings expect "bus" for
> simple-bus nodes:
>
> msm8996-mtp.dtb: agnoc@0: $nodename:0: 'agnoc@0' does not match '^bus(@[0-9a-f]+)?$'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index c53018ca81d7..cf2f5b74a4c2 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -1814,7 +1814,7 @@ spmi_bus: spmi@400f000 {
> #interrupt-cells = <4>;
> };
>
> - agnoc@0 {
> + bus@0 {
> power-domains = <&gcc AGGRE0_NOC_GDSC>;
> compatible = "simple-pm-bus";
Mind sending a separate patch to move compatible up on this one?
Konrad
> #address-cells = <1>;
next prev parent reply other threads:[~2022-12-27 11:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-24 15:42 [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema Krzysztof Kozlowski
2022-12-24 15:42 ` [PATCH 2/5] arm64: dts: qcom: sm6125: re-order USB2 phy clocks Krzysztof Kozlowski
2022-12-25 22:16 ` Marijn Suijten
2022-12-24 15:42 ` [PATCH 3/5] arm64: dts: qcom: sm8250: drop unused clock-frequency from va-macro Krzysztof Kozlowski
2022-12-27 11:21 ` Konrad Dybcio
2022-12-24 15:42 ` [PATCH 4/5] arm64: dts: qcom: sm8450: re-order GCC clocks Krzysztof Kozlowski
2022-12-27 11:21 ` Konrad Dybcio
2022-12-24 15:42 ` [PATCH 5/5] arm64: dts: qcom: use generic node name for CS35L41 speaker Krzysztof Kozlowski
2022-12-27 11:22 ` Konrad Dybcio
2022-12-27 11:22 ` Konrad Dybcio [this message]
2022-12-29 17:23 ` (subset) [PATCH 1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd6fbdba-12e9-724f-8e0d-ac60035bd19d@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).