devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Matthias Brugger" <matthias.bgg@gmail.com>,
	"Bernhard Rosenkränzer" <bero@baylibre.com>,
	devicetree@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org, khilman@baylibre.com,
	mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com
Subject: Re: [PATCH 0/9] Remove the pins-are-numbered DT property
Date: Mon, 21 Nov 2022 13:37:50 +0100	[thread overview]
Message-ID: <fd714745-ea9f-fba5-3154-7c4babfc7ba9@linaro.org> (raw)
In-Reply-To: <2cc7a3c5-563d-cdf6-f49b-5e0a9852fb54@gmail.com>

On 21/11/2022 13:31, Matthias Brugger wrote:
> Hi Bernhard,
> 
> On 21/11/2022 02:54, Bernhard Rosenkränzer wrote:
>> During the review of my MT8365 support patchset
>> (https://lore.kernel.org/linux-mediatek/20221117210356.3178578-1-bero@baylibre.com/),
>> the issue of the "pins-are-numbered" DeviceTree property has come up.
>>
>> This property is unique to Mediatek MT65xx and STM32 pinctrls, and
>> doesn't seem to serve any purpose (both the Mediatek and STM32 drivers
>> simply refuse to deal with a device unless pins-are-numbered is set to
>> true).
>>
>> There is no other use of this property in the kernel or in other projects
>> using DeviceTrees (checked u-boot and FreeBSD -- in both of those, the
>> flag is present in Mediatek and STM devicetrees, but not used anywhere).
>>
>> There is also no known use in userspace (in fact, a userland application
>> relying on the property would be broken because it would get true on
>> any Mediatek or STM chipset and false on all others, even though other
>> chipsets use numbered pins).
>>
>> This patchset removes all uses of pins-are-numbered.
>>
>>
> 
> My personal preference is to add a summary of the files touched by the series in 
> the cover letter (the tools will do that for you). This allows maintainers to 
> easier understand if they have to look deeper into the series or can ignore it.
> 
> No need to send again, just saying for the future.

Yep. And git format-patch does it automatically in both common cases -
writing cover letter manually or taking it from branch description
(which is absolutely cool, IMHO).

Best regards,
Krzysztof


      reply	other threads:[~2022-11-21 12:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21  1:54 [PATCH 0/9] Remove the pins-are-numbered DT property Bernhard Rosenkränzer
2022-11-21  1:54 ` [PATCH 1/9] pinctrl: mediatek: common: Remove check for pins-are-numbered Bernhard Rosenkränzer
2022-11-21  9:00   ` AngeloGioacchino Del Regno
2022-11-21 12:33   ` Matthias Brugger
2022-11-21 12:35   ` Krzysztof Kozlowski
2022-11-21 18:20   ` Kevin Hilman
2022-11-21  1:54 ` [PATCH 2/9] pinctrl: stm32: " Bernhard Rosenkränzer
2022-11-21 12:34   ` Matthias Brugger
2022-11-21 12:35   ` Krzysztof Kozlowski
2022-11-21  1:54 ` [PATCH 3/9] dt-bindings: pinctrl: mediatek,mt65xx: Make pins-are-numbered optional Bernhard Rosenkränzer
2022-11-21  8:00   ` Krzysztof Kozlowski
2022-11-21 12:32     ` Matthias Brugger
2022-11-21 12:36       ` Matthias Brugger
2022-11-21  1:54 ` [PATCH 4/9] dt-bindings: pinctrl: st,stm32: Don't list pins-are-numbered as required Bernhard Rosenkränzer
2022-11-21  1:54 ` [PATCH 5/9] arm64: dts: mediatek: Remove pins-are-numbered property Bernhard Rosenkränzer
2022-11-21  9:00   ` AngeloGioacchino Del Regno
2022-11-21 18:21   ` Kevin Hilman
2022-11-21  1:54 ` [PATCH 6/9] ARM: " Bernhard Rosenkränzer
2022-11-21  9:00   ` AngeloGioacchino Del Regno
2022-11-21 18:21   ` Kevin Hilman
2022-11-21  1:54 ` [PATCH 7/9] ARM: dts: stm32: Remove the " Bernhard Rosenkränzer
2022-11-21  1:54 ` [PATCH 8/9] dt-bindings: pinctrl: mediatek,mt65xx: Drop " Bernhard Rosenkränzer
2022-11-21 12:36   ` Krzysztof Kozlowski
2022-11-21  1:54 ` [PATCH 9/9] dt-bindings: pinctrl: st,stm32: Remove " Bernhard Rosenkränzer
2022-11-21 12:31 ` [PATCH 0/9] Remove the pins-are-numbered DT property Matthias Brugger
2022-11-21 12:37   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd714745-ea9f-fba5-3154-7c4babfc7ba9@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=bero@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mcoquelin.stm32@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).