From: Dmitry Osipenko <digetx@gmail.com>
To: Akhil R <akhilrajeev@nvidia.com>,
devicetree@vger.kernel.org, dmaengine@vger.kernel.org,
jonathanh@nvidia.com, kyarlagadda@nvidia.com,
ldewangan@nvidia.com, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, p.zabel@pengutronix.de,
rgumasta@nvidia.com, robh+dt@kernel.org,
thierry.reding@gmail.com, vkoul@kernel.org
Cc: Pavan Kunapuli <pkunapuli@nvidia.com>
Subject: Re: [PATCH v19 2/4] dmaengine: tegra: Add tegra gpcdma driver
Date: Tue, 8 Feb 2022 00:50:15 +0300 [thread overview]
Message-ID: <fd8ba6fc-b389-3e8e-2671-51656d3d8e5c@gmail.com> (raw)
In-Reply-To: <1644246094-29423-3-git-send-email-akhilrajeev@nvidia.com>
07.02.2022 18:01, Akhil R пишет:
> Adding GPC DMA controller driver for Tegra. The driver supports dma
> transfers between memory to memory, IO peripheral to memory and
> memory to IO peripheral.
>
> Co-developed-by: Pavan Kunapuli <pkunapuli@nvidia.com>
> Signed-off-by: Pavan Kunapuli <pkunapuli@nvidia.com>
> Co-developed-by: Rajesh Gumasta <rgumasta@nvidia.com>
> Signed-off-by: Rajesh Gumasta <rgumasta@nvidia.com>
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/dma/Kconfig | 11 +
> drivers/dma/Makefile | 1 +
> drivers/dma/tegra186-gpc-dma.c | 1505 ++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 1517 insertions(+)
> create mode 100644 drivers/dma/tegra186-gpc-dma.c
Looks okay to me. Thank you for the effort!
Coding style isn't ideal:
- inconsistent alignment of the code
- unnecessary whitespaces and parens
- inconsistent variables type signes
- all abbreviation should be capitalized in comments and commit msg
but this is not critical and could be improved later on.
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
next prev parent reply other threads:[~2022-02-07 21:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 15:01 [PATCH v19 0/4] Add NVIDIA Tegra GPC-DMA driver Akhil R
2022-02-07 15:01 ` [PATCH v19 1/4] dt-bindings: dmaengine: Add doc for tegra gpcdma Akhil R
2022-02-07 15:01 ` [PATCH v19 2/4] dmaengine: tegra: Add tegra gpcdma driver Akhil R
2022-02-07 21:50 ` Dmitry Osipenko [this message]
2022-02-08 17:22 ` Akhil R
2022-02-07 15:01 ` [PATCH v19 3/4] arm64: defconfig: tegra: Enable GPCDMA Akhil R
2022-02-07 15:01 ` [PATCH v19 4/4] arm64: tegra: Add GPCDMA node for tegra186 and tegra194 Akhil R
2022-02-18 5:01 ` [PATCH v19 0/4] Add NVIDIA Tegra GPC-DMA driver Akhil R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd8ba6fc-b389-3e8e-2671-51656d3d8e5c@gmail.com \
--to=digetx@gmail.com \
--cc=akhilrajeev@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pkunapuli@nvidia.com \
--cc=rgumasta@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).