From: Krzysztof Kozlowski <krzk@kernel.org>
To: Igor Belwon <igor.belwon@mentallysanemainliners.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
david@mainlining.org
Subject: Re: [PATCH v1 5/7] dt-bindings: pinctrl: samsung: add exynos990-wakeup-eint compatible
Date: Tue, 15 Oct 2024 08:34:25 +0200 [thread overview]
Message-ID: <fd97d92c-7999-4206-b8dd-7b79f9a84bcb@kernel.org> (raw)
In-Reply-To: <3539f6e1-fb64-4a43-ba16-5f30d99c9ea2@kernel.org>
On 15/10/2024 08:33, Krzysztof Kozlowski wrote:
> On 15/10/2024 08:27, Igor Belwon wrote:
>> Add a dedicated compatible for the exynos990-wakeup-eint node.
>>
>> Signed-off-by: Igor Belwon <igor.belwon@mentallysanemainliners.org>
>> ---
>> .../bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>> index 91516fedc872..cda5bf4cee4a 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml
>> @@ -43,6 +43,7 @@ properties:
>> - samsung,exynos7885-wakeup-eint
>> - samsung,exynos850-wakeup-eint
>> - samsung,exynos8895-wakeup-eint
>
> There is no such line. You must document all dependencies and explain
> why. So far I don't see any reasons for external dependencies. This only
> will restrict the testing and make your patchset wait for very long...
I was wrong, 8895 was already merged.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-15 6:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 6:27 [PATCH v1 0/7] Add minimal Exynos990 SoC and SM-N981B support Igor Belwon
2024-10-15 6:27 ` [PATCH v1 1/7] dt-bindings: arm: cpus: Add Samsung Mongoose M5 Igor Belwon
2024-10-15 20:37 ` Rob Herring (Arm)
2024-10-15 6:27 ` [PATCH v1 2/7] dt-bindings: hwinfo: exynos-chipid: Add compatible for Exynos 990 chipid Igor Belwon
2024-10-15 6:27 ` [PATCH v1 3/7] dt-bindings: arm: samsung: samsung-boards: Add bindings for Exynos 990 boards Igor Belwon
2024-10-15 6:27 ` [PATCH v1 4/7] dt-bindings: pinctrl: samsung: Add exynos990-pinctrl compatible Igor Belwon
2024-10-15 6:27 ` [PATCH v1 5/7] dt-bindings: pinctrl: samsung: add exynos990-wakeup-eint compatible Igor Belwon
2024-10-15 6:33 ` Krzysztof Kozlowski
2024-10-15 6:34 ` Krzysztof Kozlowski [this message]
2024-10-15 6:27 ` [PATCH v1 6/7] arm64: dts: exynos: Add initial support for the Exynos 990 SoC Igor Belwon
2024-10-15 7:02 ` Krzysztof Kozlowski
2024-10-15 6:27 ` [PATCH v1 7/7] arm64: boot: dts: Add initial support for Samsung Galaxy Note20 5G (c1s) Igor Belwon
2024-10-15 7:03 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd97d92c-7999-4206-b8dd-7b79f9a84bcb@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=david@mainlining.org \
--cc=devicetree@vger.kernel.org \
--cc=igor.belwon@mentallysanemainliners.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).