From: Lukasz Luba <lukasz.luba@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com,
rafael@kernel.org, daniel.lezcano@linaro.org, nm@ti.com,
sboyd@kernel.org, mka@chromium.org, dianders@chromium.org,
robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 3/4] OPP: Add support of "opp-microwatt" for advanced EM registration
Date: Wed, 2 Mar 2022 07:01:35 +0000 [thread overview]
Message-ID: <fd9b6b6e-9258-b7e3-fbbe-404cd49b26dd@arm.com> (raw)
In-Reply-To: <20220302045301.fq6nolscdfd5wvyo@vireshk-i7>
On 3/2/22 04:53, Viresh Kumar wrote:
> On 01-03-22, 09:35, Lukasz Luba wrote:
>> The Energy Model (EM) can be created based on DT entry:
>> 'dynamic-power-coefficient'. It's a 'simple' EM which is limited to the
>> dynamic power. It has to fit into the math formula which requires also
>> information about voltage. Some of the platforms don't expose voltage
>> information, thus it's not possible to use EM registration using DT.
>>
>> This patch aims to fix it. It introduces new implementation of the EM
>> registration callback. The new mechanism relies on the new OPP feature
>> allowing to get power (which is coming from "opp-microwatt" DT property)
>> expressed in micro-Watts.
>>
>> The patch also opens new opportunity to better support platforms, which
>> have a decent static power. It allows to register 'advanced' EM (based
>> on real power measurements) which models total power (static + dynamic),
>> so better reflects real HW.
>
> Advanced :(
>
You're right, here these words sneak in. I'm going to resent this patch
because it has this reported build issue for !EM. I'll update the words
there as well.
BTW, for the build fix, I'm going for the v3 approach:
------------8<--------------
if (_of_has_opp_microwatt_property(dev)) {
struct em_data_callback em_cb_dt =
EM_DATA_CB(_get_dt_power);
return em_dev_register_perf_domain(dev, nr_opp, &em_cb_dt,
cpus, true);
}
----------->8---------------
I don't want to introduce another dual-macro mechanism, since
the type em_data_callback is not defined in !EM.
I hope you are OK with this approach, if not please let me know.
next prev parent reply other threads:[~2022-03-02 7:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 9:35 [PATCH v4 0/4] Introduce "opp-microwatt" and Energy Model from DT Lukasz Luba
2022-03-01 9:35 ` [PATCH v4 1/4] dt-bindings: opp: Add "opp-microwatt" entry in the OPP Lukasz Luba
2022-03-01 9:35 ` [PATCH v4 2/4] OPP: Add "opp-microwatt" supporting code Lukasz Luba
2022-03-01 9:35 ` [PATCH v4 3/4] OPP: Add support of "opp-microwatt" for advanced EM registration Lukasz Luba
2022-03-01 16:58 ` kernel test robot
2022-03-01 17:53 ` Lukasz Luba
2022-03-02 4:53 ` Viresh Kumar
2022-03-02 7:01 ` Lukasz Luba [this message]
2022-03-02 7:45 ` Viresh Kumar
2022-03-02 8:50 ` Lukasz Luba
2022-03-02 9:30 ` Viresh Kumar
2022-03-02 9:37 ` Lukasz Luba
2022-03-01 9:35 ` [PATCH v4 4/4] Documentation: EM: Describe new registration method using DT Lukasz Luba
2022-03-02 4:53 ` [PATCH v4 0/4] Introduce "opp-microwatt" and Energy Model from DT Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd9b6b6e-9258-b7e3-fbbe-404cd49b26dd@arm.com \
--to=lukasz.luba@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox