From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Nikita Travkin <nikita@trvn.ru>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 1/3] dt-bindings: mfd: qcom,spmi-pmic: Add pm8916 vm-bms and lbc
Date: Sun, 17 Sep 2023 11:13:53 +0200 [thread overview]
Message-ID: <fd9f9cc2-bf56-8046-1b15-ff0ffe30304a@linaro.org> (raw)
In-Reply-To: <27adb905b990398989b4c13f03339ae9@trvn.ru>
On 17/09/2023 10:54, Nikita Travkin wrote:
>>>>> + "^battery@[0-9a-f]+$":
>>>>> + type: object
>>>>> + oneOf:
>>>>> + - $ref: /schemas/power/supply/qcom,pm8916-bms-vm.yaml#
>>>>
>>>> That's just ref, so no need for oneOf... unless you already think this
>>>> will grow with different schemas like the charger below?
>>>>
>>>
>>> Yes, I think some other PMICs have different battery/fuel-gauge
>>> blocks too so I'd like to have some room for expansion here.
>>
>> There is always room. Which other device will have different battery
>> charger?
>>
>
> I know of non-"VM" BMS block in PM8226. It's used on some Nokia
> devices that people were working on so I expect it to appear in
> the future.
>
> There is also some BMS block in more modern PM6150 that I've
> seen being looked at by people interested in bringing sm7125
> phones upstream.
>
> Both of those, to my knowledge, are completely different from
> this VM-BMS block, which I believe was present in the generation
> of pm8916, pm8909 and was abandoned again shortly after...
OK, sounds good.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-17 9:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 13:57 [PATCH 0/3] pm8916: Add BMS and charger Nikita Travkin
2023-09-16 13:57 ` [PATCH 1/3] dt-bindings: mfd: qcom,spmi-pmic: Add pm8916 vm-bms and lbc Nikita Travkin
2023-09-16 14:18 ` Rob Herring
2023-09-17 7:58 ` Krzysztof Kozlowski
2023-09-17 8:26 ` Nikita Travkin
2023-09-17 8:32 ` Krzysztof Kozlowski
2023-09-17 8:54 ` Nikita Travkin
2023-09-17 9:13 ` Krzysztof Kozlowski [this message]
2023-09-16 13:57 ` [PATCH 2/3] arm64: dts: qcom: pm8916: Add BMS and charger Nikita Travkin
2023-09-16 13:57 ` [PATCH 3/3] arm64: dts: qcom: msm8916-longcheer-l8150: Add battery " Nikita Travkin
2023-09-20 14:50 ` Konrad Dybcio
2023-09-20 15:01 ` Nikita Travkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd9f9cc2-bf56-8046-1b15-ff0ffe30304a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).