Re: [PATCH v3 1/3] dt-bindings: hwmon: Add Microchip emc2305 yaml schema

Krzysztof Kozlowski
2025-03-04T16:32:59Z

On 04/03/2025 17:31, Krzysztof Kozlowski wrote:
> On 04/03/2025 17:29, Conor Dooley wrote:
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - microchip,emc2301
>>> + - microchip,emc2302
>>> + - microchip,emc2303
>>> + - microchip,emc2305
>>
>> Driver has no match data etc, suggesting all of these are compatible.
>> Please pick one as a fallback compatible.
>>
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>
>> Missing descriptions of the fans, no?
>> See max6639 for an example.
>
> Yes and missing $ref to fan-controller schema.
About which I asked at v2...

Best regards,
Krzysztof