Re: [PATCH v3 1/3] dt-bindings: hwmon: Add Microchip emc2305 yaml schema

Frank Li
2025-03-04T16:27:20Z

On Tue, Mar 04, 2025 at 06:21:34PM +0200, florin.leotescu@oss.nxp.com wrote:
> From: Florin Leotescu <florin.leotescu@nxp.com>
>
> Introduce yaml schema for Microchip emc2305 pwm fan controller.
>
> Signed-off-by: Florin Leotescu <florin.leotescu@nxp.com>
> ---
> .../bindings/hwmon/microchip,emc2305.yaml | 43 +++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml b/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml
> new file mode 100644
> index 000000000000..cac0075a65bb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/microchip,emc2305.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/microchip,emc2305.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip EMC2305 SMBus compliant PWM fan controller
> +
> +maintainers:
> + - Michael Shych <michaelsh@nvidia.com>

who is it? look like not Microchip and hwmon maintainer.

> +
> +description: |

Needn't |

> + Microchip EMC2301/2/3/5 pwm controller which supports up
> + to five programmable fan control circuits
> +
> +properties:
> + compatible:
> + enum:
> + - microchip,emc2301
> + - microchip,emc2302
> + - microchip,emc2303
> + - microchip,emc2305

According to your driver code look like all compatible with microchip,emc2301

oneOf:
- enum:
- microchip,emc2301
- items:
- enum:
- microchip,emc2302
- microchip,emc2303
- microchip,emc2305
- const: microchip,emc2301

So your driver just need one "microchip,emc2301" compatible string.

> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + emc2301: pwm@2f {
> + compatible = "microchip,emc2301";
> + reg = <0x2f>;

If only one reg:
You can go through trivial-devices.yaml

Frank

> + };
> + };
> --
> 2.34.1
>