* Re: [Patch v2 02/11] ASoC: qcom: Add device tree binding docs
@ 2014-12-11 8:23 Kenneth Westfield
2014-12-11 13:15 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Kenneth Westfield @ 2014-12-11 8:23 UTC (permalink / raw)
To: Mark Brown
Cc: Kenneth Westfield, Takashi Iwai, Liam Girdwood, David Brown,
Bryan Huntsman, Rob Herring, Greg KH, Patrick Lai,
Banajit Goswami, ALSA Mailing List, Device Tree Mailing List,
MSM Mailing List
On Tue, December 9, 2014 7:37 am, Mark Brown wrote:
> On Mon, Dec 08, 2014 at 02:01:04PM -0800, Kenneth Westfield wrote:
>> From: Kenneth Westfield <kwestfie@codeaurora.org>
>> Add documentation to the sound directory of the
>> device-tree bindings for IPQ806x audio drivers.
> Please don't send multiple separate changes in a single patch. One change per patch.
In an effort to reduce the number of patches, would it be possible to package the DT doc with its
respective driver in one patch? Or does the DT doc need to be in a patch by itself? I've seen
examples of both.
Also, I will combine the partial addition of each driver to its respective Kconfig/Makefile
entries. For this, I believe I need to start with an empty Kconfig/Makefile in the first patch?
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation
Collaborative Project
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch v2 02/11] ASoC: qcom: Add device tree binding docs
2014-12-11 8:23 [Patch v2 02/11] ASoC: qcom: Add device tree binding docs Kenneth Westfield
@ 2014-12-11 13:15 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2014-12-11 13:15 UTC (permalink / raw)
To: Kenneth Westfield
Cc: Takashi Iwai, Liam Girdwood, David Brown, Bryan Huntsman,
Rob Herring, Greg KH, Patrick Lai, Banajit Goswami,
ALSA Mailing List, Device Tree Mailing List, MSM Mailing List
[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]
On Thu, Dec 11, 2014 at 12:23:55AM -0800, Kenneth Westfield wrote:
> On Tue, December 9, 2014 7:37 am, Mark Brown wrote:
> > Please don't send multiple separate changes in a single patch. One change per patch.
Please fix your mail client to both word wrap within paragraphs and
avoid corrupting the mails you're replying to. As things stand your
messages are excessively hard to read.
> In an effort to reduce the number of patches, would it be possible to package the DT doc with its
> respective driver in one patch? Or does the DT doc need to be in a patch by itself? I've seen
> examples of both.
You're supposed to send the documentation in a separate patch.
> Also, I will combine the partial addition of each driver to its respective Kconfig/Makefile
> entries. For this, I believe I need to start with an empty Kconfig/Makefile in the first patch?
No, you never need to create an empty file like that - what would the
value be? If you are going to add the Makefile components independently
within the Qualcomm directory please remember to pay attention to
bisection.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Patch v2 00/11] ASoC: QCOM: Add support for ipq806x SOC
@ 2014-12-08 22:01 Kenneth Westfield
2014-12-08 22:01 ` [Patch v2 02/11] ASoC: qcom: Add device tree binding docs Kenneth Westfield
0 siblings, 1 reply; 4+ messages in thread
From: Kenneth Westfield @ 2014-12-08 22:01 UTC (permalink / raw)
To: Mark Brown, Takashi Iwai, Liam Girdwood, David Brown,
Bryan Huntsman, Rob Herring, Greg KH, Patrick Lai,
Banajit Goswami
Cc: ALSA Mailing List, Device Tree Mailing List, MSM Mailing List,
Kenneth Westfield
From: Kenneth Westfield <kwestfie@codeaurora.org>
This set of patches adds support for audio on the Qualcomm Technologies ipq806x SOC.
The ipq806x SOC has audio-related hardware blocks in its low-power audio subsystem (or LPASS). One of the relevant blocks in the LPASS is its low-power audio interface (or LPAIF). This encapsulates the MI2S port, which is what these drivers are configured to use. The I2S pins are connected to an external DAC/amp chip. In addition, a single GPIO is connected to the same DAC/amp, which gives the SOC enable/disable control.
The specific drivers added are:
- a Codec DAI driver that controls the SOC external pins
- a CPU DAI driver for controlling the LPASS-LPAIF block
- a PCM MI2S platform driver
- a machine driver that ties the three drivers together
Corresponding additions to the device tree for the ipq806x and its documentation has also been added. Also, as this is a new directory, the MAINTAINERS file has been updated as well.
== Updates from my previous post:
[PATCH 00/9] ASoC: QCOM: Add support for ipq806x SOC
http://thread.gmane.org/gmane.linux.ports.arm.msm/10701
- remove the native LPAIF driver, and move its functionality to the CPU DAI driver
- add a codec driver to manage the pins going to the external DAC (previously managed by the machine driver)
- use devm_* and dev_* where possible
- ISR only handles relevant DMA channel now
- update device tree documentation to reflect changes
- general code cleanup
== Additional patch series upon which this patch series has device-tree dependencies (lcc)
[PATCH v2 0/8] qcom audio clock control drivers
http://thread.gmane.org/gmane.linux.ports.arm.msm/10793
Kenneth Westfield (11):
MAINTAINERS: Add QCOM audio ASoC maintainer
ASoC: qcom: Add device tree binding docs
ASoC: ipq806x: add LPAIF header file
ASoC: codec: Add Maxim codec driver
ASoC: ipq806x: Add LPASS CPU DAI driver
ASoC: ipq806x: Add I2S PCM platform driver
ASoC: ipq806x: Add machine driver for IPQ806X SOC
ASoC: codec: Add ability to build QCOM codec
ASoC: qcom: Add ability to build QCOM drivers
ASoC: Allow for building QCOM drivers
ARM: dts: Model IPQ LPASS audio hardware
.../bindings/sound/qcom,ipq806x-snd-card.txt | 25 ++
.../bindings/sound/qcom,lpass-cpu-dai.txt | 32 ++
.../bindings/sound/qcom,lpass-pcm-mi2s.txt | 12 +
.../bindings/sound/qcom,max98357a-codec.txt | 23 ++
MAINTAINERS | 7 +
arch/arm/boot/dts/qcom-ipq8064.dtsi | 33 ++
sound/soc/Kconfig | 1 +
sound/soc/Makefile | 1 +
sound/soc/codecs/Kconfig | 4 +
sound/soc/codecs/Makefile | 2 +
sound/soc/codecs/max98357a.c | 267 ++++++++++++
sound/soc/qcom/Kconfig | 25 ++
sound/soc/qcom/Makefile | 11 +
sound/soc/qcom/ipq806x.c | 127 ++++++
sound/soc/qcom/lpass-cpu-mi2s.c | 374 +++++++++++++++++
sound/soc/qcom/lpass-cpu-mi2s.h | 48 +++
sound/soc/qcom/lpass-lpaif.h | 154 +++++++
sound/soc/qcom/lpass-pcm-mi2s.c | 452 +++++++++++++++++++++
18 files changed, 1598 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/qcom,ipq806x-snd-card.txt
create mode 100644 Documentation/devicetree/bindings/sound/qcom,lpass-cpu-dai.txt
create mode 100644 Documentation/devicetree/bindings/sound/qcom,lpass-pcm-mi2s.txt
create mode 100644 Documentation/devicetree/bindings/sound/qcom,max98357a-codec.txt
create mode 100644 sound/soc/codecs/max98357a.c
create mode 100644 sound/soc/qcom/Kconfig
create mode 100644 sound/soc/qcom/Makefile
create mode 100644 sound/soc/qcom/ipq806x.c
create mode 100644 sound/soc/qcom/lpass-cpu-mi2s.c
create mode 100644 sound/soc/qcom/lpass-cpu-mi2s.h
create mode 100644 sound/soc/qcom/lpass-lpaif.h
create mode 100644 sound/soc/qcom/lpass-pcm-mi2s.c
--
1.8.2.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Patch v2 02/11] ASoC: qcom: Add device tree binding docs
2014-12-08 22:01 [Patch v2 00/11] ASoC: QCOM: Add support for ipq806x SOC Kenneth Westfield
@ 2014-12-08 22:01 ` Kenneth Westfield
2014-12-09 15:37 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Kenneth Westfield @ 2014-12-08 22:01 UTC (permalink / raw)
To: Mark Brown, Takashi Iwai, Liam Girdwood, David Brown,
Bryan Huntsman, Rob Herring, Greg KH, Patrick Lai,
Banajit Goswami
Cc: ALSA Mailing List, Device Tree Mailing List, MSM Mailing List,
Kenneth Westfield
From: Kenneth Westfield <kwestfie@codeaurora.org>
Add documentation to the sound directory of the
device-tree bindings for IPQ806x audio drivers.
Signed-off-by: Kenneth Westfield <kwestfie@codeaurora.org>
Acked-by: Banajit Goswami <bgoswami@codeaurora.org>
---
.../bindings/sound/qcom,ipq806x-snd-card.txt | 25 +++++++++++++++++
.../bindings/sound/qcom,lpass-cpu-dai.txt | 32 ++++++++++++++++++++++
.../bindings/sound/qcom,lpass-pcm-mi2s.txt | 12 ++++++++
.../bindings/sound/qcom,max98357a-codec.txt | 23 ++++++++++++++++
4 files changed, 92 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/qcom,ipq806x-snd-card.txt
create mode 100644 Documentation/devicetree/bindings/sound/qcom,lpass-cpu-dai.txt
create mode 100644 Documentation/devicetree/bindings/sound/qcom,lpass-pcm-mi2s.txt
create mode 100644 Documentation/devicetree/bindings/sound/qcom,max98357a-codec.txt
diff --git a/Documentation/devicetree/bindings/sound/qcom,ipq806x-snd-card.txt b/Documentation/devicetree/bindings/sound/qcom,ipq806x-snd-card.txt
new file mode 100644
index 0000000000000000000000000000000000000000..10178737b4bdc6108475f48726bdbf40b6b044b5
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/qcom,ipq806x-snd-card.txt
@@ -0,0 +1,25 @@
+* Qualcomm Technologies IPQ806x SoundCard
+
+This node models the Qualcomm Technologies IPQ806x LPASS Audio SoundCard,
+with a connection between the CPU MI2S DAI and the external DAC.
+
+Required properties:
+- compatible : "qcom,ipq806x-snd-card"
+- qcom,model : The user-visible name of this sound card
+ * <any string is valid>
+- platform : This is a phandle reference to platform device driver node (for the soundcard dai-link)
+- cpu : This is a phandle reference to CPU DAI device driver node (for the soundcard dai-link)
+- codec : This is a phandle reference to codec DAI device driver node (for the soundcard dai-link)
+- codec-dai : This is a string that names the codec DAI device (for the soundcard dai-link)
+ * max98357a-codec-dai
+
+Example:
+
+sound {
+ compatible = "qcom,ipq806x-snd-card";
+ model = "ipq806x-snd-card";
+ platform = <&lpass_pcm_mi2s>;
+ cpu = <&lpass_cpu_mi2s>;
+ codec = <&max98357a_codec>;
+ codec-dai = "max98357a-codec-dai";
+};
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu-dai.txt b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu-dai.txt
new file mode 100644
index 0000000000000000000000000000000000000000..ee94af49f90aedb0889f1ddf043780a80e585f62
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu-dai.txt
@@ -0,0 +1,32 @@
+* Qualcomm Technologies IPQ806x LPASS DAI
+
+This node models the Qualcomm Technologies IPQ806x LPASS MI2S DAI port.
+
+Required properties:
+- compatible : "qcom,lpass-cpu-mi2s"
+- reg : Address space for the LPASS audio interface registers
+- reg-names : The name of the LPASS audio interface register address space
+ * lpass-lpaif-mem
+- clocks : A list of clock specifiers for the audio interface
+ * AHBIX bus clock
+ * MI2S OSR clock
+ * MI2S Bit clock
+- clock-names : A list of audio interface clock names
+ * ahbix_clk
+ * mi2s_osr_clk
+ * mi2s_bit_clk
+- interrupts : Phandle to the LPASS audio interface interrupt
+- interrupt-names : The name of the LPASS audio interface interrupt
+ * lpass-lpaif-irq
+
+Example:
+
+lpass-cpu-mi2s {
+ compatible = "qcom,lpass-cpu-dai";
+ reg = <0x28100000 0x10000>;
+ reg-names = "lpass-lpaif-mem";
+ clocks = <&lcc AHBIX_CLK>, <&lcc MI2S_OSR_CLK>, <&lcc MI2S_BIT_CLK>;
+ clock-names = "ahbix_clk", "mi2s_osr_clk", "mi2s_bit_clk";
+ interrupts = <0 85 1>;
+ interrupt-names = "lpass-lpaif-irq";
+};
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-pcm-mi2s.txt b/Documentation/devicetree/bindings/sound/qcom,lpass-pcm-mi2s.txt
new file mode 100644
index 0000000000000000000000000000000000000000..09c04b7f37b51076860f1df10114e0a47b921404
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-pcm-mi2s.txt
@@ -0,0 +1,12 @@
+* Qualcomm Technologies IPQ806x PCM audio interface
+
+This node models the Qualcomm Technologies IPQ806x PCM audio interface.
+
+Required properties:
+- compatible : "qcom,lpass-pcm-mi2s"
+
+Example:
+
+lpass-pcm-mi2s {
+ compatible = "qcom,lpass-pcm-mi2s";
+};
diff --git a/Documentation/devicetree/bindings/sound/qcom,max98357a-codec.txt b/Documentation/devicetree/bindings/sound/qcom,max98357a-codec.txt
new file mode 100644
index 0000000000000000000000000000000000000000..14bc14b1049f4138123db8fd17e8926545cbb218
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/qcom,max98357a-codec.txt
@@ -0,0 +1,23 @@
+* Maxim MAX98357A DAC
+
+This node models the Maxim MAX98357A DAC as a codec DAI.
+This is for audio on the Qualcomm IPQ806x SOC.
+
+Required properties:
+- compatible : "qcom,max98357a-codec"
+- dac-gpios : Phandle to the GPIO specifier for the GPIO -> DAC SDMODE pin
+- pinctrl-names : A list of names indicating the state of the MI2S pins
+ * mi2s-disabled
+ * mi2s-enabled
+- pinctrl-0 : The disabled state of the MI2S pins
+- pinctrl-1 : The enabled state of the MI2S pins
+
+Example:
+
+max98357a-codec {
+ compatible = "qcom,max98357a-codec";
+ dac-gpios = <&qcom_pinmux 25 0>;
+ pinctrl-names = "mi2s-disabled", "mi2s_enabled";
+ pinctrl-0 = <&mi2s_disabled>;
+ pinctrl-1 = <&mi2s_enabled>;
+};
--
1.8.2.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Patch v2 02/11] ASoC: qcom: Add device tree binding docs
2014-12-08 22:01 ` [Patch v2 02/11] ASoC: qcom: Add device tree binding docs Kenneth Westfield
@ 2014-12-09 15:37 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2014-12-09 15:37 UTC (permalink / raw)
To: Kenneth Westfield
Cc: Takashi Iwai, Liam Girdwood, David Brown, Bryan Huntsman,
Rob Herring, Greg KH, Patrick Lai, Banajit Goswami,
ALSA Mailing List, Device Tree Mailing List, MSM Mailing List
[-- Attachment #1: Type: text/plain, Size: 571 bytes --]
On Mon, Dec 08, 2014 at 02:01:04PM -0800, Kenneth Westfield wrote:
> From: Kenneth Westfield <kwestfie@codeaurora.org>
>
> Add documentation to the sound directory of the
> device-tree bindings for IPQ806x audio drivers.
Please don't send multiple separate changes in a single patch. One
change per patch.
> .../bindings/sound/qcom,max98357a-codec.txt | 23 ++++++++++++++++
You are reporting the vendor for this Maxim device as Qualcomm which
isn't right, please review the meaning of the vendor information in the
device tree binding strings.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-11 13:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-11 8:23 [Patch v2 02/11] ASoC: qcom: Add device tree binding docs Kenneth Westfield
2014-12-11 13:15 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2014-12-08 22:01 [Patch v2 00/11] ASoC: QCOM: Add support for ipq806x SOC Kenneth Westfield
2014-12-08 22:01 ` [Patch v2 02/11] ASoC: qcom: Add device tree binding docs Kenneth Westfield
2014-12-09 15:37 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).