From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D746C4167B for ; Sun, 1 Jan 2023 21:33:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229879AbjAAVdm (ORCPT ); Sun, 1 Jan 2023 16:33:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbjAAVdl (ORCPT ); Sun, 1 Jan 2023 16:33:41 -0500 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F6C4F28 for ; Sun, 1 Jan 2023 13:33:40 -0800 (PST) Received: by mail-ej1-x62e.google.com with SMTP id gh17so62911683ejb.6 for ; Sun, 01 Jan 2023 13:33:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yyX96uVGJMMaNM8wZZWyXIyRqapSrshMe1zf2VI54Gc=; b=gSw5fX1Bkm7fQmXRIRnGTyyos+zIm+kBLxXP81KQpsb3rLEabKuUAbHFc3zYDXnWbs AGjnENSsuIA9DPgm6QM/wXLIoq/IQ7jBnzxyDYNg/FGfwEKGIfg2x27FyhCI7Xo9OwTQ ygZUVFs79gcCVrwujTUUTHSf+GHYcGTa88YGaqkgeXAEShwLBYbyNHFh9bSxB+/WVmxW yrjGG0q3DeSv4SA2WYrtz2qLAmT67GyE5lMyTb16pO41/JofWyYesQ8PqUGBmsmqq8mq i77+4PyJq0tAeMMr58zyQRSZhBTyf4uirsCvZqH6BQaR9ULl21lVr8xoUKjTLYonDjXD 8BRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yyX96uVGJMMaNM8wZZWyXIyRqapSrshMe1zf2VI54Gc=; b=FV3CAW9sa4ligNGMoZfWPvEIXRchGtSOmeTcmFLcylcsbHMXwCz88/u5tCw5mULiEK 21ZK7c0dxmZOL9FAauz+pOrY4k0SznIaoEpEItiBAuRnazdeu/O6XD1PB9OWv+jdJxO6 LK+I3mRCFXkPRp/NELMrZVUgk0EULaKPwF8r0THfAok5KeEIV6Kxn9APTSV9VXrISPQ9 J24gCc2I59NOI6ZTJnQmXGaQxm46U6T1kBiavdi/y/ZzYzEQlnVEdKvZjmQCWSKJn79q iumd/W2psXUrU7/rDs+xuqTvmUp+aEjmFx7hn828b2/okp9wh174uEBI+dk2/Kh+sARE aD3g== X-Gm-Message-State: AFqh2koqVDQxyzEhrw+MPiKVeoJPXEJpMdETtT84smiC5wvV6xDtn3TU seg3r2CKi31opymYYLV5F/mDYWoVhN3iEpIU X-Google-Smtp-Source: AMrXdXuIzVKHbCr/cOQ9XZLjyA7akuauNPpkKOy2DJ228mNpxKjLLqaiW0w47WAi5TfUVRXgYtr0fg== X-Received: by 2002:a17:906:b043:b0:7c0:d23c:ead3 with SMTP id bj3-20020a170906b04300b007c0d23cead3mr33986334ejb.27.1672608819181; Sun, 01 Jan 2023 13:33:39 -0800 (PST) Received: from ?IPV6:2001:1c06:2302:5600:5825:7f8d:c381:cef4? (2001-1c06-2302-5600-5825-7f8d-c381-cef4.cable.dynamic.v6.ziggo.nl. [2001:1c06:2302:5600:5825:7f8d:c381:cef4]) by smtp.gmail.com with ESMTPSA id h21-20020a170906829500b00782e3cf7277sm12056805ejx.120.2023.01.01.13.33.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Jan 2023 13:33:38 -0800 (PST) Message-ID: Date: Sun, 1 Jan 2023 21:33:37 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v6 07/20] thermal/drivers/tsens: fix slope values for msm8939 Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui Cc: Shawn Guo , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org References: <20230101194034.831222-1-dmitry.baryshkov@linaro.org> <20230101194034.831222-8-dmitry.baryshkov@linaro.org> <7298fd96-14ec-c82b-8005-bb5dd912a055@linaro.org> From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01/01/2023 21:30, Dmitry Baryshkov wrote: > On 01/01/2023 22:24, Bryan O'Donoghue wrote: >> On 01/01/2023 19:40, Dmitry Baryshkov wrote: >>> +static int __init init_8939(struct tsens_priv *priv) { >>> +    priv->sensor[0].slope = 2911; >>> +    priv->sensor[1].slope = 2789; >>> +    priv->sensor[2].slope = 2906; >>> +    priv->sensor[3].slope = 2763; >>> +    priv->sensor[4].slope = 2922; >>> +    priv->sensor[5].slope = 2867; >>> +    priv->sensor[6].slope = 2833; >>> +    priv->sensor[7].slope = 2838; >>> +    priv->sensor[8].slope = 2840; >>> +    priv->sensor[9].slope = 2852; >> >> How are you coming up with the last value here ? >> >> https://github.com/android-linux-stable/msm-3.18/blob/60a8d8af3751b9dc22894fe68b3964ea94ae7888/arch/arm/boot/dts/qcom/msm8939-common.dtsi#L525 > > From this DTSi. There was a separate configuration for 8939 v3. And I > don't know why Qualcomm completely ignored it for later releases (3.14, > 3.18). > > https://git.codelinaro.org/clo/la/kernel/msm-3.10/-/blob/LA.BR.1.3.7.c26-03900-8976.0/arch/arm/boot/dts/qcom/msm8939-v3.0.dtsi#L613 > Fair enough Reviewed-by: Bryan O'Donoghue