From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22759C7EE22 for ; Tue, 9 May 2023 07:05:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233852AbjEIHE7 (ORCPT ); Tue, 9 May 2023 03:04:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235200AbjEIHEv (ORCPT ); Tue, 9 May 2023 03:04:51 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FADD4C31 for ; Tue, 9 May 2023 00:04:49 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-50bc2feb320so8690147a12.3 for ; Tue, 09 May 2023 00:04:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683615888; x=1686207888; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=R9je2FiauGBpFiGNJuwOsfynyz1TKYfPJaan1c/py7Y=; b=D4+9QhI/kNNxXPNutfq2ILahcxiAWKrUfsTo97PPROu9ivhwKFV3/E8RMciUASPo0n yG1kMKkT01JSU1bNXtmniTKcfILcFK80VlKurWmFbPGXg/flE4z1CvlcFOMkzmIX4Zl1 TvCANS3/Xh7Nu+stOIn3rmFvwtxwh16enf07X4dr1bor+KNugP2/YbXqbPSmkDSRYjuC A9hHL6oytNsbxf2gVoG9Jtzb8TwTmrXFTa6h5vOujBKmGlpDLFqVcDjbi1fnKPpzHs6n zsRwlyXLHNo742n0yqEWeTpUqJLi5NFWuMIQkGnWmYm4h5Xb7/C+Q1o+m8Njd1XBTx61 8YAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683615888; x=1686207888; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R9je2FiauGBpFiGNJuwOsfynyz1TKYfPJaan1c/py7Y=; b=I8LbCOLiS9+VMgeCsgng8sjVp6VY4pRqTSBuehtBaJUHPhofYojy4S8+zFZmpdlhfN gYzKzLhCddr5v7c3HM9NeNW56EvzRuV1RgeA9qL6xljDytR6Q4LUJMGP6jXn+W31aDKL E8C+ZUIqEeYHXCgbyC3qmYLcWOyDk22rj0ot4MfgrelAvb/x66Kt7nR2KpuCXylVwtVD A59uFtjiPZqqTZzElenxM0vLOOw0Bxx9IHA9GWzU2P0E5l/tQ/GXyTIRNqeuxXxIoaIU 2IIjdSuRdo6QwxGIZK3xeqeQV4uZfhwxs7CTeQKIVi+JWr1J+e8NbZ8kEQcuJ27oQsz9 dUXA== X-Gm-Message-State: AC+VfDyyL4nllqfO4gqaMuh8bB+na1wOp3qXW2Jfak9CDRcX8+hemhIo eyg9pi6Mw+TdNilex1YRZIwdnQ== X-Google-Smtp-Source: ACHHUZ6hzC1saOmkygWVMlKVmHxOKkKYHghk1vO57fI/ZQ+sGNQ4PG/m94tnvrs43zivvvCJqWc/XA== X-Received: by 2002:a05:6402:12d5:b0:50c:9582:e968 with SMTP id k21-20020a05640212d500b0050c9582e968mr9527951edx.36.1683615887756; Tue, 09 May 2023 00:04:47 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:d0d5:7818:2f46:5e76? ([2a02:810d:15c0:828:d0d5:7818:2f46:5e76]) by smtp.gmail.com with ESMTPSA id i12-20020aa7c70c000000b0050bd7267a5csm398739edq.58.2023.05.09.00.04.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 May 2023 00:04:47 -0700 (PDT) Message-ID: Date: Tue, 9 May 2023 09:04:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCHv2 6/6] arm64: dts: socfpga: add hwmon properties Content-Language: en-US To: dinh.nguyen@linux.intel.com, linux-hwmon@vger.kernel.org Cc: dinguyen@kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org, jdelvare@suse.com, linux@roeck-us.net References: <20230508212852.8413-1-dinh.nguyen@linux.intel.com> <20230508212852.8413-6-dinh.nguyen@linux.intel.com> From: Krzysztof Kozlowski In-Reply-To: <20230508212852.8413-6-dinh.nguyen@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/05/2023 23:28, dinh.nguyen@linux.intel.com wrote: > From: Dinh Nguyen > > Add the hardware monitoring properties for Stratix10 and Agilex. > > Signed-off-by: Dinh Nguyen > --- > v2: add platform specific platforms to DTS files > --- > .../boot/dts/altera/socfpga_stratix10.dtsi | 4 ++ > .../dts/altera/socfpga_stratix10_socdk.dts | 31 +++++++++ > arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 4 ++ > .../boot/dts/intel/socfpga_agilex_n6000.dts | 66 +++++++++++++++++++ > .../boot/dts/intel/socfpga_agilex_socdk.dts | 66 +++++++++++++++++++ > .../dts/intel/socfpga_agilex_socdk_nand.dts | 66 +++++++++++++++++++ > .../boot/dts/intel/socfpga_n5x_socdk.dts | 47 +++++++++++++ > 7 files changed, 284 insertions(+) > > diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi > index 41c9eb51d0ee..2526afa687d6 100644 > --- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi > +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi > @@ -633,6 +633,10 @@ svc { > fpga_mgr: fpga-mgr { > compatible = "intel,stratix10-soc-fpga-mgr"; > }; > + > + hwmon: temp-volt { Node names should be generic, so maybe just hwmon. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "intel,socfpga-stratix10-hwmon", "intel,socfpga-hwmon"; Test your bindings. Your bindings or this part do not match at all. Driver does not match it either. Best regards, Krzysztof