Re: [PATCH v3 4/4] arm64: dts: qcom: add base QCS8300 RIDE board

Dmitry Baryshkov
2024-11-30T01:46:26Z

On Fri, Nov 29, 2024 at 11:13:28AM +0800, Tingwei Zhang wrote:
> On 11/28/2024 9:29 PM, Dmitry Baryshkov wrote:
> > > +#include "qcs8300.dtsi"
> > > +/ {
> > > + model = "Qualcomm Technologies, Inc. QCS8300 Ride";
> > > + compatible = "qcom,qcs8300-ride", "qcom,qcs8300";
> > > + chassis-type = "embedded";
> > > +
> > > + aliases {
> > > + serial0 = &uart7;
> > > + };
> > > +
> > > + chosen {
> > > + stdout-path = "serial0:115200n8";
> > > + };
> > > +
> > > + clocks {
> > > + xo_board_clk: xo-board-clk {
> > > + compatible = "fixed-clock";
> > > + #clock-cells = <0>;
> > > + clock-frequency = <38400000>;
> > > + };
> > > +
> > > + sleep_clk: sleep-clk {
> > > + compatible = "fixed-clock";
> > > + #clock-cells = <0>;
> > > + clock-frequency = <32000>;
> > > + };
> > Move both clocks to the qcs8300.dtsi. If you wish, you can keep
> > frequencies in the board DT file.
> >
> Dmirty,
>
> Move xo clock and sleep clock to board DT from SoC DT are due to review
> comments in [1] and [2].
>
> As you and Krzysztof discussed in [3], there're pros and cons for different
> solutions. There are three possible ways.
>
> Put these two clocks in board DT is aligned with hardware. These two clocks
> are provided by PMIC instead of SoC.
>
> Put these two clocks in SoC DT can reduce duplication since they are not
> supposed to be changed on different board.
>
> Put these two clocks in SoC DT and set frequency in board DT.
>
> We need a unify way to deal with this kind of nodes and keep it consistent
> across Qualcomm SoC.
>
> Who shall make this decision?

After an offline discussion I've send [4].

[4] https://lore.kernel.org/linux-arm-msm/20241130-fix-board-clocks-v2-0-b9a35858657e@linaro.org/

>
> [1]https://lore.kernel.org/all/10914199-1e86-4a2e-aec8-2a48cc49ef14@kernel.org/
> [2]https://lore.kernel.org/all/be8b573c-db4e-4eec-a9a6-3cd83d04156d@kernel.org/
> [3]https://lore.kernel.org/all/4kopdkvbkrpcpzwteezm427ml5putqvzsnfkpmg76spsple7l5@mg7v3ihwxnit/
>
> > > + };
> > > +};
> > > +
>
>
> --
> Thanks,
> Tingwei

--
With best wishes
Dmitry