From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, broonie@kernel.org
Cc: robh@kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
lgirdwood@gmail.com
Subject: Re: [PATCH v3 4/7] ASoC: codecs: wcd938x: add basic controls
Date: Fri, 19 Mar 2021 11:03:09 -0500 [thread overview]
Message-ID: <fe430019-783c-d5ba-e79d-d48944c01f04@linux.intel.com> (raw)
In-Reply-To: <20210319092919.21218-5-srinivas.kandagatla@linaro.org>
> +static int wcd938x_ear_pa_put_gain(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_value *ucontrol)
> +{
> + struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol);
> + struct wcd938x_sdw_priv *wcd = snd_soc_component_get_drvdata(component);
> + struct wcd938x_priv *wcd938x = wcd->wcd938x;
> +
> + if (wcd938x->comp1_enable) {
> + dev_err(component->dev, "Can not set EAR PA Gain, compander1 is enabled\n");
> + return -EINVAL;
> + }
> +
> + snd_soc_component_write_field(component, WCD938X_ANA_EAR_COMPANDER_CTL,
> + WCD938X_EAR_GAIN_MASK,
> + ucontrol->value.integer.value[0]);
> +
> + return 0;
that goes back to my other comments, the earpiece is connected to the RX
interface, so what component would be used to set the gain here? the TX
one? But what tells you this component is active and ready to support
commands?
next prev parent reply other threads:[~2021-03-19 16:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 9:29 [PATCH v3 0/7] ASoC: codecs: add wcd938x support Srinivas Kandagatla
2021-03-19 9:29 ` [PATCH v3 1/7] ASoC: dt-bindings: wcd938x: add bindings for wcd938x Srinivas Kandagatla
2021-03-26 1:52 ` Rob Herring
2021-03-19 9:29 ` [PATCH v3 2/7] ASoC: codecs: wcd-clsh: add new version support Srinivas Kandagatla
2021-03-19 15:23 ` Pierre-Louis Bossart
2021-03-22 10:26 ` Srinivas Kandagatla
2021-03-19 9:29 ` [PATCH v3 3/7] ASoC: codecs: wcd938x: add basic driver Srinivas Kandagatla
2021-03-19 15:59 ` Pierre-Louis Bossart
2021-03-22 10:27 ` Srinivas Kandagatla
2021-03-19 9:29 ` [PATCH v3 4/7] ASoC: codecs: wcd938x: add basic controls Srinivas Kandagatla
2021-03-19 16:03 ` Pierre-Louis Bossart [this message]
2021-03-19 9:29 ` [PATCH v3 5/7] ASoC: codecs: wcd938x: add playback dapm widgets Srinivas Kandagatla
2021-03-19 9:29 ` [PATCH v3 6/7] ASoC: codecs: wcd938x: add capture " Srinivas Kandagatla
2021-03-19 9:29 ` [PATCH v3 7/7] ASoC: codecs: wcd938x: add audio routing Srinivas Kandagatla
2021-03-19 16:06 ` Pierre-Louis Bossart
2021-03-19 16:09 ` [PATCH v3 0/7] ASoC: codecs: add wcd938x support Pierre-Louis Bossart
2021-03-22 10:27 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe430019-783c-d5ba-e79d-d48944c01f04@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).