Re: [PATCH v7 2/4] Add SPAcc ahash support

[Markus Elfring <Markus.Elfring@web.de>]

…
> +++ b/drivers/crypto/dwc-spacc/spacc_ahash.c
> @@ -0,0 +1,980 @@
…
> +static int do_shash(struct device *dev, unsigned char *name,
…
> +{
…
> +	sdesc = kmalloc(size, GFP_KERNEL);
> +	if (!sdesc) {
> +		rc = -ENOMEM;
> +		goto do_shash_err;
> +	}
…
> +do_shash_err:
> +	crypto_free_shash(hash);
> +	kfree(sdesc);
> +
> +	return rc;
> +}
…

* You may use an additional label for better exception handling.

  Or

* Would you like to benefit more from the attribute “__free(kfree)”?
  https://elixir.bootlin.com/linux/v6.17.1/source/include/linux/slab.h#L476


…
> +/* Crypto engine hash operation */
> +static int spacc_hash_do_one_request(struct crypto_engine *engine, void *areq)
> +{
…
> +	tctx->tmp_sgl = kmalloc(sizeof(*tctx->tmp_sgl) * 2, GFP_KERNEL);
> +
> +	if (!tctx->tmp_sgl)

* Please omit a blank line between such statements.

* Can a kmalloc_array() call be helpful here?


…
> +			kfree(tctx->tmp_sgl);
> +			tctx->tmp_sgl = NULL;
> +			local_bh_disable();
> +			crypto_finalize_hash_request(engine, req, rc);
> +			local_bh_enable();
> +			return 0;
> +		}
…

Please avoid duplicate source code in such a function implementation.

Regards,
Markus