From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D9C6C4332F for ; Thu, 24 Nov 2022 09:49:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229633AbiKXJto (ORCPT ); Thu, 24 Nov 2022 04:49:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbiKXJtm (ORCPT ); Thu, 24 Nov 2022 04:49:42 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66060F72DA; Thu, 24 Nov 2022 01:49:41 -0800 (PST) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id E832024E154; Thu, 24 Nov 2022 17:49:39 +0800 (CST) Received: from EXMBX072.cuchost.com (172.16.6.82) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 24 Nov 2022 17:49:39 +0800 Received: from [192.168.125.106] (183.27.97.81) by EXMBX072.cuchost.com (172.16.6.82) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 24 Nov 2022 17:49:39 +0800 Message-ID: Date: Thu, 24 Nov 2022 17:50:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v2 1/8] dt-bindings: riscv: Add StarFive JH7110 SoC and VisionFive2 board Content-Language: en-US To: Emil Renner Berthing CC: "linux-riscv@lists.infradead.org" , "devicetree@vger.kernel.org" , Conor Dooley , Palmer Dabbelt , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Albert Ou , Ben Dooks , Thomas Gleixner , Marc Zyngier , Stephen Boyd , Michael Turquette , Philipp Zabel , "Linus Walleij" , "linux-kernel@vger.kernel.org" References: <20221118011714.70877-1-hal.feng@starfivetech.com> <20221118011714.70877-2-hal.feng@starfivetech.com> <202211190418.2AJ4IQjc072382@SH1-CSMTP-DB111.sundns.com> From: Hal Feng In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.97.81] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX072.cuchost.com (172.16.6.82) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 24 Nov 2022 10:20:32 +0100, Emil Renner Berthing wrote: > On Thu, 24 Nov 2022 at 06:56, Hal Feng wrote: > > > > On Sat, 19 Nov 2022 01:28:48 +0800, Emil Renner Berthing wrote: > > > On Fri, 18 Nov 2022 at 02:17, Hal Feng wrote: > > > > > > > > From: Emil Renner Berthing > > > > > > > > Add device tree bindings for the StarFive JH7110 RISC-V SoC [1] > > > > and the VisionFive2 board [2] equipped with it. > > > > > > > > [1]: https://doc-en.rvspace.org/Doc_Center/jh7110.html > > > > [2]: https://doc-en.rvspace.org/Doc_Center/visionfive_2.html > > > > > > > > Signed-off-by: Emil Renner Berthing > > > > Signed-off-by: Hal Feng > > > > --- > > > > Documentation/devicetree/bindings/riscv/starfive.yaml | 4 ++++ > > > > 1 file changed, 4 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml > > > > index 5b36243fd674..64008c57e31f 100644 > > > > --- a/Documentation/devicetree/bindings/riscv/starfive.yaml > > > > +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml > > > > @@ -22,6 +22,10 @@ properties: > > > > - const: beagle,beaglev-starlight-jh7100-r0 > > > > - const: starfive,jh7100 > > > > > > > > + - items: > > > > + - const: starfive,visionfive-v2 > > > > > > I think StarFive has switched to just calling it VisionFive 2 and not > > > V2. Please check up on this before committing to the compatible > > > string. > > > > > > Also there are going to be different revisions of the VisionFive 2 > > > board, so maybe consider adding eg. starfive,visionfive-2-v1.1 and > > > starfive,visionfive-2-v1,2b early. > > > > I checked that the official name of this board is "VisionFive 2". The > > board has version A and version B, which are different in gmac and phy > > chip. The version A board has one 1000M and one 100M Ethernet ports > > while the version B board has two 1000M Ethernet ports. In dts, they > > have different configuration parameters for gmac. So I would like to > > distinguish them by two compatibles as below in the next version. > > > > - items: > > - enum: > > - starfive,visionfive-2-va > > - starfive,visionfive-2-vb > > - const: starfive,jh7110 > > Cool. Though the silkscreen on my board says "VisionFive 2 V1.2B" so I > think it would be less confusing if you used that as the model, and > "starfive,visionfive-2-v1.2b" as the compatible string for the board. As far as I know, VisionFive 2 V1.3B is coming and all version B boards use the same configuration. It's unnecessary to add the detailed number of PCB version. > > > > Best regards, > > Hal > > > > > > > > > + - const: starfive,jh7110 > > > > + > > > > additionalProperties: true > >