Re: [PATCH 2/7] ata: ahci: mvebu: Support A8k compatible

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 10/7/20 5:45 PM, sven.auhagen@voleatech.de wrote:
> From: Miquel Raynal <miquel.raynal@bootlin.com>
> 
> The ahci_platform.c driver was historically the one bound to the A8k
> AHCI compatible string, but before adding a quirk for this compatible,
> it is probably cleaner to put all Marvell EBU code in one place: the
> ahci_mvebu.c driver.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

> ---
>  drivers/ata/ahci_mvebu.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/ata/ahci_mvebu.c b/drivers/ata/ahci_mvebu.c
> index 43bb2db59698..1cdc126882eb 100644
> --- a/drivers/ata/ahci_mvebu.c
> +++ b/drivers/ata/ahci_mvebu.c
> @@ -96,6 +96,11 @@ static int ahci_mvebu_armada_3700_config(struct ahci_host_priv *hpriv)
>  	return 0;
>  }
>  
> +static int ahci_mvebu_armada_8k_config(struct ahci_host_priv *hpriv)
> +{
> +	return 0;
> +}
> +
>  /**
>   * ahci_mvebu_stop_engine
>   *
> @@ -230,6 +235,10 @@ static const struct ahci_mvebu_plat_data ahci_mvebu_armada_3700_plat_data = {
>  	.host_flags = AHCI_HFLAG_SUSPEND_PHYS,
>  };
>  
> +static const struct ahci_mvebu_plat_data ahci_mvebu_armada_8k_plat_data = {
> +	.plat_config = ahci_mvebu_armada_8k_config,
> +};
> +
>  static const struct of_device_id ahci_mvebu_of_match[] = {
>  	{
>  		.compatible = "marvell,armada-380-ahci",
> @@ -239,6 +248,10 @@ static const struct of_device_id ahci_mvebu_of_match[] = {
>  		.compatible = "marvell,armada-3700-ahci",
>  		.data = &ahci_mvebu_armada_3700_plat_data,
>  	},
> +	{
> +		.compatible = "marvell,armada-8k-ahci",
> +		.data = &ahci_mvebu_armada_8k_plat_data,
> +	},
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(of, ahci_mvebu_of_match);
>