From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD815EB64DD for ; Fri, 28 Jul 2023 07:19:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234072AbjG1HTA (ORCPT ); Fri, 28 Jul 2023 03:19:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234040AbjG1HSu (ORCPT ); Fri, 28 Jul 2023 03:18:50 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 147CC2122 for ; Fri, 28 Jul 2023 00:18:49 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-51e2a6a3768so2308744a12.0 for ; Fri, 28 Jul 2023 00:18:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690528727; x=1691133527; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZFRs+1l4ttYgce/W/Q/lR0//anrGUYTWZshXgYuQpfM=; b=X+8YpOCRlNu+CrYzZ9s51R51phORgLLkvU1YXhrdW4w3DQXRasewx+yxyK/GVhvqv0 m6wo2m08SQArbieyg2c9eHYamZfJHMvQ9UMYU4EX7bqS7UsOWwi2wSpsgeopvZLgt1RD w2LMTxdQQrn6oenHpc2ZPpAlYtMuDy+TsEYOIo8gyykcJqYmkCtkC05G3M+MZvhuZeZn MwraUPRQUDxjDLIyH0g2yPlWHU/fQLHCbpDH4pLVw+2Iwm+HolXeILpXhjvWOcXJPBnE ZdtTKK9oXIu1mRsBQDqmTgeylHBOBDnikFUMkUw2GqVA3KYLHHoLXnJ7hsaTn2NAuudZ xyvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690528727; x=1691133527; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZFRs+1l4ttYgce/W/Q/lR0//anrGUYTWZshXgYuQpfM=; b=iF/MiacWviUlNOVC1jfq1WXHfyCvXNOreiEbmrzT2OJrTXV0cHtu28Zj346NkoFOzq 78hwUIQQXH+ggVW2nuJXZSKLYKQ/nia8kJLW+XgEtOD4nJWNrKd6S2dneSZfFKFQfWZn LUy3TFYz+q3I06lEId0pJVZFOsLlDMqYf/+wJHxhvm3KfCpGSlaltnCtGBbxlMmh99Nt A+Qnros+iNLunWG+fB6UD8HuDB9hDTiLNNLo0TIdPwZiX60CvgKU2BMy7RK5kRjjRiFG IWg/EX+2QV0J5QoVYAPmZ3+S4E3gY5h1te3yMtqwEksuEclbPucmMKA9J1Xqp5o6teeE QQcw== X-Gm-Message-State: ABy/qLZMNok9mxkyjYiJ/cvyzDJvLDzHlKVBXosqGMMAhmiEbuhib3af aQZ79+zRGl+KSMuBDSZ2c8nyRw== X-Google-Smtp-Source: APBJJlHB7YcDxfEFdwmeU91iDamcQPeuv4jgYP8CBYnnw95qVTyfL/9+3ouqOSWZtgQ1H53Yh82/3w== X-Received: by 2002:aa7:df89:0:b0:522:3aae:c69b with SMTP id b9-20020aa7df89000000b005223aaec69bmr918747edy.20.1690528727494; Fri, 28 Jul 2023 00:18:47 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id e8-20020a056402148800b0052227c4384esm1467532edv.34.2023.07.28.00.18.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 00:18:46 -0700 (PDT) Message-ID: Date: Fri, 28 Jul 2023 09:18:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 4/9] dt-bindings: clock: Add Marvell PXA1908 clock bindings Content-Language: en-US To: =?UTF-8?Q?Duje_Mihanovi=c4=87?= , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, afaerber@suse.com References: <20230727162909.6031-1-duje.mihanovic@skole.hr> <20230727162909.6031-5-duje.mihanovic@skole.hr> From: Krzysztof Kozlowski In-Reply-To: <20230727162909.6031-5-duje.mihanovic@skole.hr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27/07/2023 18:29, Duje Mihanović wrote: > Add dt bindings and documentation for the Marvell PXA1908 clock > controller. > > Signed-off-by: Duje Mihanović > --- ... > +/* apb (apbc) peripherals */ > +#define PXA1908_CLK_UART0 1 > +#define PXA1908_CLK_UART1 2 > +#define PXA1908_CLK_GPIO 3 > +#define PXA1908_CLK_PWM0 4 > +#define PXA1908_CLK_PWM1 5 > +#define PXA1908_CLK_PWM2 6 > +#define PXA1908_CLK_PWM3 7 > +#define PXA1908_CLK_SSP0 8 > +#define PXA1908_CLK_SSP1 9 > +#define PXA1908_CLK_IPC_RST 10 > +#define PXA1908_CLK_RTC 11 > +#define PXA1908_CLK_TWSI0 12 > +#define PXA1908_CLK_KPC 13 > +#define PXA1908_CLK_SWJTAG 17 > +#define PXA1908_CLK_SSP2 20 > +#define PXA1908_CLK_TWSI1 25 > +#define PXA1908_CLK_THERMAL 28 > +#define PXA1908_CLK_TWSI3 29 > +#define PXA1908_APBC_NR_CLKS 48 > + > +/* apb (apbcp) peripherals */ > +#define PXA1908_CLK_UART2 7 > +#define PXA1908_CLK_TWSI2 10 > +#define PXA1908_CLK_AICER 14 > +#define PXA1908_APBCP_NR_CLKS 14 > + > +/* axi (apmu) peripherals */ > +#define PXA1908_CLK_CCIC1 9 > +#define PXA1908_CLK_ISP 14 Why do you have gaps between IDs? The clock IDs are supposed to be continuous, otherwise it is not an ID. > +#define PXA1908_CLK_GATE_CTRL 16 Best regards, Krzysztof