From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 136E5C6FA90 for ; Mon, 26 Sep 2022 11:04:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234152AbiIZLEc (ORCPT ); Mon, 26 Sep 2022 07:04:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237084AbiIZLDb (ORCPT ); Mon, 26 Sep 2022 07:03:31 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C27C5EDF5 for ; Mon, 26 Sep 2022 03:32:21 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id a2so10109956lfb.6 for ; Mon, 26 Sep 2022 03:32:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=Ppgskzcs0IRjENYynELJGMW2eRkYjwxFUGvz8QmabCI=; b=xEHY9hKPN5+g0Up7Z5BW1HBukr47ui9VT78DO85ZNWGhMcdDMyDIE0WmywWPmNaT7+ pZBGM07yDZLikVxgxTkInBpmtdZcyyBUl5xVxVk6m7loWGeMBOMqSTcKlDdCFm6v2vSM MYEVA7kmnPU+5XoUuIU6a0POrj6mSD5BxPiQzSeRFd8qi040ALxHvqwjy5f6Q5VA3BLl wc0XkfFGRaio1x5DTDuMNNyhZH29mi4+cJoyn9ogl8ZOW41v+jUZg1vOFdtnNRDXW3em 3ieI5pJMlz7W9VOQadaWYl2708G/E7DqyrgLHYc7Bt8RorPYCjo7MQTlsHGdpUgNe/Zh mV2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=Ppgskzcs0IRjENYynELJGMW2eRkYjwxFUGvz8QmabCI=; b=fDWX27gZqmHWb2CBBc6dKQQNjFew0pEIT0HnBcDEjT8W/xtG28vs6w93K2GoxQEEc/ XSysXtwy80sbcaIhk+mZCi4vUbj9CM9hsW+ABARI/vz5Lz6PIQPd4MXQXCi5YgKTUp4/ 2IlhwSxKEo6yf6Euihx1woH0J37a4rLfdZVvjDyY5XETbzaylVC+dBZLiu4zlmzq3bv1 rGe62Hj0mPjdExApYSPYRa9GQnZVvisVacD8hPwJdyNtbG4bPB1SDzkRzNhqJVCXcci/ op9pZoaXvutA8taV3KraSN8Ok/4o4Q9DuiE3uWXQRzZhb47xVpNv0s+2CgcrHtVjYLvG bZew== X-Gm-Message-State: ACrzQf0RnDW8E1PN4dwhq5So4PL737A7Mdl1mX28DFToLY/VHkMPqhIc 1UUyMJKpu79mPJyFxyZ5qTiEBQ== X-Google-Smtp-Source: AMsMyM718lAHi/XQO9pRng3KyE8uJbsmjxvFCdTiup3iVL7kEiWEo2WeLb5ppkuAOSNb4uBtv0fp1Q== X-Received: by 2002:a05:6512:138e:b0:47f:77cc:327a with SMTP id p14-20020a056512138e00b0047f77cc327amr8872511lfa.277.1664188240965; Mon, 26 Sep 2022 03:30:40 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id v8-20020ac258e8000000b004947a12232bsm2486244lfo.275.2022.09.26.03.30.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 03:30:39 -0700 (PDT) Message-ID: Date: Mon, 26 Sep 2022 12:30:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v7 1/3] dt-bindings: arm: qcom: document qcom,msm-id and qcom,board-id Content-Language: en-US To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rob Herring , Kumar Gala , Dmitry Baryshkov , Rob Herring References: <20220830065744.161163-1-krzysztof.kozlowski@linaro.org> <20220830065744.161163-2-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220830065744.161163-2-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30/08/2022 08:57, Krzysztof Kozlowski wrote: > The top level qcom,msm-id and qcom,board-id properties are utilized by > bootloaders on Qualcomm MSM platforms to determine which device tree > should be used and passed to the kernel. > > The commit b32e592d3c28 ("devicetree: bindings: Document qcom board > compatible format") from 2015 was a consensus during discussion about > upstreaming qcom,msm-id and qcom,board-id fields. There are however still > problems with that consensus: > 1. It was reached 7 years ago but it turned out its implementation did > not reach all possible products. > > 2. Initially additional tool (dtbTool) was needed for parsing these > fields to create a QCDT image consisting of multiple DTBs, later the > bootloaders were improved and they use these qcom,msm-id and > qcom,board-id properties directly. > > 3. Extracting relevant information from the board compatible requires > this additional tool (dtbTool), which makes the build process more > complicated and not easily reproducible (DTBs are modified after the > kernel build). > > 4. Some versions of Qualcomm bootloaders expect these properties even > when booting with a single DTB. The community is stuck with these > bootloaders thus they require properties in the DTBs. > > Since several upstreamed Qualcomm SoC-based boards require these > properties to properly boot and the properties are reportedly used by > bootloaders, document them along with the bindings header with constants > used by: bootloader, some DTS and socinfo driver. > > Link: https://lore.kernel.org/r/a3c932d1-a102-ce18-deea-18cbbd05ecab@linaro.org/ > Co-developed-by: Kumar Gala > Signed-off-by: Kumar Gala > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Dmitry Baryshkov > Reviewed-by: Rob Herring > > --- > > Changes since v6: > 1. Update header with defines > 2. Add Rb tag Hi Bjorn, Any further comments on this? Can it be applied? Best regards, Krzysztof