Re: [PATCH] dt-bindings: mmc: st,sdhci: convert to DT schema

Krzysztof Kozlowski
2026-04-16T09:18:30Z

On Thu, Apr 09, 2026 at 07:43:16AM +0000, Charan Pedumuru wrote:
> +properties:
> + compatible:
> + oneOf:
> + - const: st,sdhci
> + - items:
> + - const: st,sdhci-stih407
> + - const: st,sdhci
> +
> + reg:
> + minItems: 1
> + maxItems: 2

replace maxItems with a list with description

> +
> + reg-names:
> + minItems: 1
> + maxItems: 2
> + items:
> + enum:

List order is not flexible. The only flexibility is presence of top-mmc-delay

> + - mmc
> + - top-mmc-delay
> +
> + clocks:
> + minItems: 1
> + maxItems: 2
> +
> + clock-names:
> + minItems: 1
> + maxItems: 2
> + items:
> + enum:

Same here

> + - mmc
> + - icn
> +
> + interrupts:
> + maxItems: 1
> +
> + interrupt-names:
> + const: mmcirq
> +
> + pinctrl-names:
> + const: default

Drop

> +
> + resets:
> + maxItems: 1
> + description: Phandle to reset line of host controller.

Drop description

> +
> + vqmmc-supply:
> + description: Regulator supplying I/O voltage (Vcc/Vdd for SD/eMMC).
> +
> + non-removable:
> + type: boolean
> + description:
> + Indicates a non-removable device (e.g., eMMC). Also used for mmcss config.
> +
> + bus-width:
> + description: Number of data lines.
> + enum: [1, 4, 8]
> +
> + max-frequency:
> + enum: [50000000, 100000000, 200000000]
> + default: 50000000
> + description:
> + Maximum bus frequency. Used to configure CCONFIG3 in mmcss.
> +
> + sd-uhs-sdr50:
> + type: boolean
> +
> + sd-uhs-sdr104:
> + type: boolean
> +
> + sd-uhs-ddr50:
> + type: boolean

No, drop all above. Look how MMC bindings are written.

> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - interrupts
> + - interrupt-names
> + - pinctrl-names
> +

Missing allOf with $ref to mmc-controller

> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/stih407-clks.h>
> + sdhci@9060000 {

Wrong name. Look at other examples. You might need to fix DTS.

Best regards,
Krzysztof