From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4770AC38A2D for ; Wed, 26 Oct 2022 17:22:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233760AbiJZRWQ (ORCPT ); Wed, 26 Oct 2022 13:22:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233757AbiJZRWO (ORCPT ); Wed, 26 Oct 2022 13:22:14 -0400 Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DB0E9A2A7 for ; Wed, 26 Oct 2022 10:22:11 -0700 (PDT) Received: by mail-qk1-x72b.google.com with SMTP id s17so11070961qkj.12 for ; Wed, 26 Oct 2022 10:22:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oLlW1kscCZqIaTOlPcJH/jgt0YbKOWqVS01M6qgp7Uw=; b=w/j7e/fNOCN2iVFnKD8fD8BvhEM2bJk4xOdewSXDEFnHOZGff4bZ5IRRwFooNK/vjC RLiABqYXJAOzFl9nB1Ripgvl6j73RDhtXxtZxKy1HUQjPS3roj9630mO1NdwfExyW2+d HXxquLZV361r+bxmEtPw3jUC5jkvTL0RwdZfeF/BIEMyFD2OGfDjeVP8ynKMTEyvvx+F hHREYvY8RKqLJB1wC9fMSMlldzP0FJ6airbjaRnek0EUrBeMRv08K247pG/GijAS5za6 K8+QAhtZhWb5xN/OVXIvTs3nJOuGnDqodc1MNQjfwsDZeWnnHRUSNK5VNxWL/P4yUdAd 3sLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oLlW1kscCZqIaTOlPcJH/jgt0YbKOWqVS01M6qgp7Uw=; b=LLQuvsffZiHku05a4Ch0GEdiYz8cqWcdZHaFrSlNkqWsoj0muP1ZDWnm7cj+Aqv1X9 RoZjWv/iTFLXZMsbd8hZdl2NJtEmy6GjXzXVj4jhjBiHpIv4JD0buvTBYcJZTdbHbfJj xdWltsLwvYJofu76PZ9hkrGfuhxALrDy8uqnn1hUnaShldufeyuqgLWq7K4LcH7lSw6u 2/6V7OVsWIcRQ4KFl5u1n8U7ru+tFIysn/yxTJHWWmUFxMNr3vgIB9UkPOxYBm0Xemtf VPdxGwqePsa9FgBypvpOohxlrv1BuGMY4XDVaOFDqfZZB5IC/EBovFyIUdsDcTdO8WJv zGrA== X-Gm-Message-State: ACrzQf0NDf5lBP/lQ1wTu8EX+bC+T8r7EdozNeA3iQJkq6ctMXnGPbsE zOmHCEpiUlV3+IRLkp40ilbtlQ== X-Google-Smtp-Source: AMsMyM6Kf2jYy3iJqZeqVyXShFrqXF8kTcxCcGJu4mG93deokS9fXIamGA2nuPqOdQnS49zUo6CUpQ== X-Received: by 2002:ae9:dd04:0:b0:6e0:ae86:b4 with SMTP id r4-20020ae9dd04000000b006e0ae8600b4mr31724032qkf.146.1666804930281; Wed, 26 Oct 2022 10:22:10 -0700 (PDT) Received: from [192.168.1.11] ([64.57.193.93]) by smtp.gmail.com with ESMTPSA id x22-20020a05620a0ed600b006b61b2cb1d2sm4130569qkm.46.2022.10.26.10.22.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Oct 2022 10:22:09 -0700 (PDT) Message-ID: Date: Wed, 26 Oct 2022 13:22:07 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [RFC 5/5] bluetooth: hci_mrvl: allow waiting for firmware load using notify-device Content-Language: en-US To: Matthias Schiffer , Arnd Bergmann , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski Cc: Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Amitkumar Karwar , Ganapathi Bhat , Sharvari Harisangam , Xinming Hu , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux@ew.tq-group.com References: From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/10/2022 09:15, Matthias Schiffer wrote: > Signed-off-by: Matthias Schiffer > --- > drivers/bluetooth/hci_mrvl.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/bluetooth/hci_mrvl.c b/drivers/bluetooth/hci_mrvl.c > index b7d764e6010f..dc55053574a9 100644 > --- a/drivers/bluetooth/hci_mrvl.c > +++ b/drivers/bluetooth/hci_mrvl.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -433,9 +434,25 @@ static int mrvl_serdev_probe(struct serdev_device *serdev) > return -ENOMEM; > > if (IS_ENABLED(CONFIG_OF)) { > + struct device_node *firmware_ready_node; > + struct device *firmware_ready; > + > mrvldev->info = of_device_get_match_data(&serdev->dev); > if (!mrvldev->info) > return -ENODEV; > + > + firmware_ready_node = of_parse_phandle(serdev->dev.of_node, > + "firmware-ready", 0); So you want us to go through five patches, find properties and OF-code, create in our minds bindings you think about and comment on that imaginary bindings. I think it should work otherwise - send bindings for all of your DT properties. Best regards, Krzysztof