From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tomer Maimon <tmaimon77@gmail.com>, Rob Herring <robh@kernel.org>
Cc: peter.chen@kernel.org, gregkh@linuxfoundation.org,
krzysztof.kozlowski+dt@linaro.org, xu.yang_2@nxp.com,
peng.fan@nxp.com, avifishman70@gmail.com, tali.perry1@gmail.com,
joel@jms.id.au, venture@google.com, yuenn@google.com,
benjaminfair@google.com, j.neuschaefer@gmx.net,
openbmc@lists.ozlabs.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-binding: usb: ci-hdrc-usb2: document Nuvoton NPCM supprt
Date: Sat, 23 Sep 2023 13:46:11 +0200 [thread overview]
Message-ID: <fea4b205-a0d8-9c40-4fa8-29340c41aed1@linaro.org> (raw)
In-Reply-To: <CAP6Zq1iUj8UfLZutyOVxbKgF42rMoF9ig3dViy7ApTHcqVoP7g@mail.gmail.com>
On 21/09/2023 15:17, Tomer Maimon wrote:
> Hi Rob,
>
> Again thanks for your suggestion I took a look at the
> drivers/usb/roles and I am not sure it answers NPCM ChipIdae case.
> For example, in the NPCM845 we have ten UDC ChipIdea modules (UDC0-9).
> Only UDC8 and UDC9 are muxed with USB host0 and USB host1.
> NPCM UDC and NPCM USB host are different HW modules therefore different drivers.
>
> The ChipIdea driver uses its own internal USB role function to switch
> between ChipIdea UDC and ChipIdea USB host and we can't replace it
> with a unique NPCM USB role function also we need to set the mux only
> at the probe stage.
>
> This is why I have added nuvoton,sysgcr property to the NPCM ChipIdea driver.
>
> With the above do you think I should do it differently?
Your entire rationale above explains drivers, so it is not proper
justification for bindings. How your probe stage has anything to do with
bindings? If drivers do not work or miss something, change them.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-23 11:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 16:59 [PATCH v1 0/2] usb: ChipIdea: add Nuvoton NPCM UDC support Tomer Maimon
2023-09-18 16:59 ` [PATCH v1 1/2] dt-binding: usb: ci-hdrc-usb2: document Nuvoton NPCM supprt Tomer Maimon
2023-09-18 20:18 ` Krzysztof Kozlowski
2023-09-19 5:14 ` Tomer Maimon
2023-09-19 12:39 ` Krzysztof Kozlowski
2023-09-19 13:31 ` Tomer Maimon
2023-09-19 16:28 ` Rob Herring
2023-09-20 9:11 ` Tomer Maimon
2023-09-21 13:17 ` Tomer Maimon
2023-09-23 11:46 ` Krzysztof Kozlowski [this message]
2023-09-18 16:59 ` [PATCH v1 2/2] usb: chipidea: Add support for NPCM Tomer Maimon
2023-09-19 7:45 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fea4b205-a0d8-9c40-4fa8-29340c41aed1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=j.neuschaefer@gmx.net \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=peng.fan@nxp.com \
--cc=peter.chen@kernel.org \
--cc=robh@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=xu.yang_2@nxp.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).