From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Icenowy Zheng <uwu@icenowy.me>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Kaehlcke <mka@chromium.org>,
Andre Przywara <andre.przywara@arm.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 2/6] dt-bindings: usb: Add binding for Genesys Logic GL850G hub controller
Date: Fri, 2 Dec 2022 17:59:38 +0100 [thread overview]
Message-ID: <feb6d0d3-706f-b726-dd13-9ed665a52f9d@linaro.org> (raw)
In-Reply-To: <2f0f31551d361cf23abdd2c4117f2feb84e2b1a8.camel@icenowy.me>
On 02/12/2022 17:54, Icenowy Zheng wrote:
> 在 2022-12-02星期五的 10:02 +0100，Krzysztof Kozlowski写道：
>> On 02/12/2022 09:16, Icenowy Zheng wrote:
>>> The Genesys Logic GL850G is a USB 2.0 Single TT hub controller that
>>> features 4 downstream ports, an internal 5V-to-3.3V LDO regulator
>>> (can
>>> be bypassed) and an external reset pin.
>>>
>>> Add a device tree binding for its USB protocol part. The internal
>>> LDO is
>>> not covered by this and can just be modelled as a fixed regulator.
>>>
>>> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
>>> ---
>>> Changes in v2:
>>> - Misc fixes suggested by Krzysztof, including property
>>> descriptions,
>>> single-item "items" and fixing the example's gpio property.
>>> - Fixed $id.
>>>
>> (...)
>>
>>> +
>>> +examples:
>>> + - |
>>> + usb {
>>> + dr_mode = "host";
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + hub: hub@1 {
>>> + compatible = "usb5e3,608";
>>> + reg = <1>;
>>> + reset-gpios = <&pio 7 2>;
>>
>> Use GPIO flags. What did you fix in the example?
>
> It used to be here, but using it needs another include, which I don't
> think it necessary here.
The header is necessary for the flags...
>
> Maybe I should just drop this line in the example?
It's useful. The example should be rather complete, not just compatible
and reg.
Different problem - you miss maxItems for the GPIOs.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-02 17:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 8:16 [PATCH v2 0/6] Rongpin RP-H6B support (and support for GL850G) Icenowy Zheng
2022-12-02 8:16 ` [PATCH v2 1/6] dt-bindings: vendor-prefixes: add Genesys Logic Icenowy Zheng
2022-12-02 8:16 ` [PATCH v2 2/6] dt-bindings: usb: Add binding for Genesys Logic GL850G hub controller Icenowy Zheng
2022-12-02 9:02 ` Krzysztof Kozlowski
2022-12-02 16:54 ` Icenowy Zheng
2022-12-02 16:59 ` Krzysztof Kozlowski [this message]
2022-12-02 17:00 ` Icenowy Zheng
2022-12-02 8:16 ` [PATCH v2 3/6] usb: misc: onboard_usb_hub: add Genesys Logic GL850G hub support Icenowy Zheng
2022-12-02 16:52 ` Matthias Kaehlcke
2022-12-02 8:16 ` [PATCH v2 4/6] vendor-prefixes: Add Shenzhen Rongpin Electronics Co., Ltd Icenowy Zheng
2022-12-02 8:16 ` [PATCH v2 5/6] dt-bindings: arm: sunxi: add Rongpin RP-H6B board Icenowy Zheng
2022-12-03 2:02 ` Samuel Holland
2022-12-02 8:16 ` [PATCH v2 6/6] arm64: dts: allwinner: h6: add Rongpin RP-H6C SoM and " Icenowy Zheng
2022-12-03 2:11 ` Samuel Holland
2022-12-03 5:15 ` Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=feb6d0d3-706f-b726-dd13-9ed665a52f9d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-usb@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=uwu@icenowy.me \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).