From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D6AEC46467 for ; Mon, 28 Nov 2022 21:29:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233836AbiK1V3x (ORCPT ); Mon, 28 Nov 2022 16:29:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233824AbiK1V3w (ORCPT ); Mon, 28 Nov 2022 16:29:52 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB1F629C88 for ; Mon, 28 Nov 2022 13:29:50 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id g7so19488529lfv.5 for ; Mon, 28 Nov 2022 13:29:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QgUJEUWiFBjFkvCREQ2uT+SLGIPmc2Hf0VU5w0JvR/c=; b=UxdkaeUBRqNiusYvr8YGGByVN8wZQaeL+N2kwb1H/9tef5Gr7NxxbKPRYzejFNcFDQ nqNw4hxyANkK4+PlfuU2yzI9X7KD8xe9/+DbqC3LDPGQsQDN2PBpFHfVYYVkY+kqlTRn bT6V+ydv3mytISXW83ip9xBJ3tPLMVpdO2Xa267Jne7pDvBWCIC1rSvQuRVS0ek92fS6 Ih9J3XtDktayhen5WNhA0sQt1H+mckSF7LV35dsG8hW9jawmAHKTYuRbpxGo00fEsD7R FrhgNtGRhPAN+4OKiApn/omyUD+AwiO0xsoceTteBVPZZ0hzLzeKXgMMJwUlJxVuDKAO eQkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QgUJEUWiFBjFkvCREQ2uT+SLGIPmc2Hf0VU5w0JvR/c=; b=6kVUzI+9AfD5I/MP3++KtnDq8ADb6ARFavIB2FV4OQFkpia6Ha0L/a5Nh5UP4if0dO wqRalxOA7oLgES2/j2jt5AcdMCBgBnw2U5IlmXoP+cMORE5/qFTVgHFXLRrP+26jgrbt ibTlE1t33XtbR4MJQcqwLX0wJ8cy9BL06rQRSJyvi4dFYli0s5aVEHfcgauYlcaviczc dXzOAT2t/H6N0jYvFrgiRYdh1AS5AUK6AusCNvcj2jZLxtne96cXOzsQXgoB4ZjeXAXI I6s8ERY85a9AvkTtnUU/0yAEx4sNmvIPhzA8SN/+gl00jHTjORAQR9XWA3Yw6dPBZIz7 0Mzw== X-Gm-Message-State: ANoB5pmXF9NwpJoJjib0I/D0Nsp3z31NsTsq+sb6JAWyZuqBCOuUYTb7 7bcgK8F+LPrAzm/tvYEh563r3Q== X-Google-Smtp-Source: AA0mqf5nk5f8aNwCyLodbExVLjLO5u1/kM7i/o+msvxhfe7KlSUOzlXTmEh8o6NEcKD7N/c/nF7LIg== X-Received: by 2002:ac2:52a2:0:b0:4ac:d6e4:41d4 with SMTP id r2-20020ac252a2000000b004acd6e441d4mr17007602lfm.253.1669670989231; Mon, 28 Nov 2022 13:29:49 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id a13-20020a056512374d00b004a05767bc07sm1877127lfs.28.2022.11.28.13.29.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 13:29:48 -0800 (PST) Message-ID: Date: Mon, 28 Nov 2022 22:29:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] arm64: dts: qcom: msm8916-wingtech-wt88047: Add flash LED Content-Language: en-US From: Krzysztof Kozlowski To: Stephan Gerhold Cc: "Lin, Meng-Bo" , linux-kernel@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Nikita Travkin , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, =?UTF-8?Q?Andr=c3=a9_Apitzsch?= , Pavel Machek References: <20221128051512.125148-1-linmengbo0689@protonmail.com> <43c24e7e-49b6-ff46-2f40-9413af7ac252@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/11/2022 22:23, Krzysztof Kozlowski wrote: > On 28/11/2022 19:30, Stephan Gerhold wrote: >> Hi Krzysztof, >> >> On Mon, Nov 28, 2022 at 09:56:47AM +0100, Krzysztof Kozlowski wrote: >>> On 28/11/2022 06:16, Lin, Meng-Bo wrote: >>>> WT88047 uses OCP 8110 Flash LED driver. Add it to the device tree. >>>> >>>> Signed-off-by: Lin, Meng-Bo >>>> --- >>>> .../dts/qcom/msm8916-wingtech-wt88047.dts | 22 +++++++++++++++++++ >>>> 1 file changed, 22 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts b/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts >>>> index 166bed05996f..a87be1d95b14 100644 >>>> --- a/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts >>>> +++ b/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts >>>> @@ -23,6 +23,20 @@ chosen { >>>> stdout-path = "serial0"; >>>> }; >>>> >>>> + flash-led-controller { >>>> + compatible = "ocs,ocp8110"; >>> >>> The compatible is not documented. Checkpatch warns about it. You need to >>> document devices before using them. >>> >> >> Unfortunately Pavel never applied the dt-bindings patch for this - only >> the driver patch was applied. André already sent a kind reminder [1] and >> two resends [2, 3] without success. Since it's a documentation-only >> patch, maybe you could take it through the dt-bindings tree? >> > > I'll ping Rob. Other way is to resend. You need to keep resending (maybe > together with DTS in such case) before this can go in. Applied by Rob: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=for-next&id=876c881f9f416f1a9071a80fb7daefe19c51186e Best regards, Krzysztof