From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ansuel Smith <ansuelsmth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dt-bindings: arm: msm: Convert kpss-gcc driver Documentation to yaml
Date: Sat, 30 Apr 2022 16:40:54 +0200 [thread overview]
Message-ID: <fec305d1-d4b3-3f9d-bc31-bc33490d1ad7@linaro.org> (raw)
In-Reply-To: <20220430060125.9124-4-ansuelsmth@gmail.com>
On 30/04/2022 08:01, Ansuel Smith wrote:
> Convert kpss-gcc driver Documentation to yaml.
> Add #clock-cells additional binding to required bindings and example
> as it's a required binding for clock-output-names.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
(...)
> +properties:
> + compatible:
> + items:
> + - enum:
> + - qcom,kpss-gcc-ipq8064
> + - qcom,kpss-gcc-apq8064
> + - qcom,kpss-gcc-msm8974
> + - qcom,kpss-gcc-msm8960
> + - const: qcom,kpss-gcc
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: phandle to pll8_vote
> + - description: phandle to pxo_board
> +
> + clock-names:
> + items:
> + - const: pll8_vote
> + - const: pxo
> +
> + clock-output-names:
> + const: acpu_l2_aux
It does not make sense having a constant output name. What is the
meaning this property in such case? The original binding did not enforce it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-30 14:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-30 6:01 [PATCH v2 0/3] Krait Documentation conversion Ansuel Smith
2022-04-30 6:01 ` [PATCH v2 1/3] dt-bindings: clock: Convert qcom,krait-cc to yaml Ansuel Smith
2022-04-30 6:01 ` [PATCH v2 2/3] dt-bindings: arm: msm: Convert kpss-acc driver Documentation " Ansuel Smith
2022-04-30 6:01 ` [PATCH v2 3/3] dt-bindings: arm: msm: Convert kpss-gcc " Ansuel Smith
2022-04-30 14:40 ` Krzysztof Kozlowski [this message]
2022-04-30 7:42 ` Ansuel Smith
2022-05-01 8:26 ` Krzysztof Kozlowski
2022-05-02 10:40 ` Ansuel Smith
2022-05-02 20:18 ` Krzysztof Kozlowski
2022-05-02 19:49 ` Ansuel Smith
2022-06-27 20:54 ` Bjorn Andersson
2022-05-02 15:33 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fec305d1-d4b3-3f9d-bc31-bc33490d1ad7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).