From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Fenglin Wu <quic_fenglinw@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Cc: quic_collinsd@quicinc.com, quic_subbaram@quicinc.com,
quic_kamalw@quicinc.com, jestar@qti.qualcomm.com,
quic_huliu@quicinc.com
Subject: Re: [PATCH v2 1/2] dt-bindings: input: qcom,pm8xxx-vib: add more PMIC support
Date: Tue, 18 Jul 2023 09:20:07 +0200 [thread overview]
Message-ID: <fec38f3a-f103-ff0f-138c-cffa3a808001@linaro.org> (raw)
In-Reply-To: <5b7e624b-5d06-826d-92d1-2a721b7c83b7@quicinc.com>
On 18/07/2023 09:06, Fenglin Wu wrote:
>
>
> On 7/18/2023 2:38 PM, Fenglin Wu wrote:
>>
>>
>> On 7/18/2023 2:33 PM, Krzysztof Kozlowski wrote:
>>> On 18/07/2023 08:26, Fenglin Wu wrote:
>>>> Add support for vibrator module inside Qualcomm PMI632, PM7250B, PM7325B
>>>> PMICs.
>>>>
>>>> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com>
>>>> ---
>>>
>>> I don't see changelog. No changes then?
>>>
>> Sorry, I updated the change log in the cover letter which didn't seems
>> to be sent to a wider audience, I will resend it by adding more
>> receivers in the to list
>>
>> Fenglin
>
> Just FYI,the change log was updated in the cover letter here:
> https://lore.kernel.org/linux-arm-msm/20230718062639.2339589-1-quic_fenglinw@quicinc.com/T/#m3819b50503ef19e0933a10bf797351a4af35537f
>
> Also the commit text and the driver change were also updated accordingly
> to address your review comment by removing 'pm7550ba-vib' compatible string.
Removing compatible was never my feedback. Did you read:
https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42
?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-18 7:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230718062639.2339589-1-quic_fenglinw@quicinc.com>
2023-07-18 6:26 ` [PATCH v2 1/2] dt-bindings: input: qcom,pm8xxx-vib: add more PMIC support Fenglin Wu
2023-07-18 6:33 ` Krzysztof Kozlowski
2023-07-18 6:38 ` Fenglin Wu
2023-07-18 7:06 ` Fenglin Wu
2023-07-18 7:20 ` Krzysztof Kozlowski [this message]
2023-07-18 7:59 ` Fenglin Wu
2023-07-18 8:02 ` Krzysztof Kozlowski
2023-07-27 7:10 ` Krzysztof Kozlowski
2023-07-27 7:54 ` Fenglin Wu
2023-07-27 8:29 ` Krzysztof Kozlowski
2023-07-27 10:51 ` Fenglin Wu
2023-07-18 10:51 ` Konrad Dybcio
2023-07-18 10:56 ` Fenglin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fec38f3a-f103-ff0f-138c-cffa3a808001@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jestar@qti.qualcomm.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_collinsd@quicinc.com \
--cc=quic_fenglinw@quicinc.com \
--cc=quic_huliu@quicinc.com \
--cc=quic_kamalw@quicinc.com \
--cc=quic_subbaram@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).