From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Ankit Sharma <quic_anshar@quicinc.com>,
cros-qcom-dts-watchers@chromium.org, agross@kernel.org,
andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_ashayj@quicinc.com,
quic_atulpant@quicinc.com, quic_rgottimu@quicinc.com,
quic_shashim@quicinc.com, quic_pkondeti@quicinc.com
Subject: Re: [PATCH v2] arm64: dts: qcom: sc7280: Add capacity and DPC properties
Date: Sat, 4 Nov 2023 12:52:19 +0100 [thread overview]
Message-ID: <feca8e74-6653-4cec-943d-47302431e1fc@linaro.org> (raw)
In-Reply-To: <20231103105440.23904-1-quic_anshar@quicinc.com>
On 11/3/23 11:54, Ankit Sharma wrote:
> The "capacity-dmips-mhz" and "dynamic-power-coefficient" are
> used to build Energy Model which in turn is used by EAS to take
> placement decisions. So add it to SC7280 soc.
>
> Signed-off-by: Ankit Sharma <quic_anshar@quicinc.com>
> ---Hi, thanks for this patch
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
I performed a quick grep in arch/arm64/boot/dts/qcom and noticed
that at least one of these values is missing for:
rg -l --files-without-match dynamic-power-coeff $(rg cpu@ -l) | sort
ipq5018.dtsi (homogeneous cluster)
ipq5332.dtsi (homogeneous cluster)
ipq6018.dtsi (homogeneous cluster)
ipq8074.dtsi (homogeneous cluster)
ipq9574.dtsi (homogeneous cluster)
msm8916.dtsi (homogeneous cluster)
msm8939.dtsi
msm8953.dtsi
msm8976.dtsi
msm8994.dtsi
msm8996.dtsi
msm8998.dtsi
qcs404.dtsi (homogeneous cluster)
qdu1000.dtsi (homogeneous cluster)
sa8775p.dtsi
sc7280.dtsi
sc8180x.dtsi
sc8280xp.dtsi
sdm630.dtsi
sm4450.dtsi
sm6125.dtsi
sm6375.dtsi
sm8350.dtsi
sm8450.dtsi
rg -l --files-without-match capacity-dmips $(rg cpu@ -l) | sort
ipq5018.dtsi (homogeneous cluster)
ipq5332.dtsi (homogeneous cluster)
ipq6018.dtsi (homogeneous cluster)
ipq8074.dtsi (homogeneous cluster)
ipq9574.dtsi (homogeneous cluster)
msm8916.dtsi (homogeneous cluster)
msm8939.dtsi
msm8994.dtsi
qcs404.dtsi (homogeneous cluster)
qdu1000.dtsi (homogeneous cluster)
sa8775p.dtsi
sc7280.dtsi
sm4450.dtsi
sm6375.dtsi
sm8350.dtsi
sm8450.dtsi
Where platforms with a single, homogeneous cluster likely don't
benefit from EAS..
Is there any chance you could dig up the correct values, for at least
some of these platforms? Or would you know whom to ask?
FWIW the one we're missing the most is sc8280xp..
Konrad
next prev parent reply other threads:[~2023-11-04 11:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 10:54 [PATCH v2] arm64: dts: qcom: sc7280: Add capacity and DPC properties Ankit Sharma
2023-11-04 11:52 ` Konrad Dybcio [this message]
2023-11-06 16:56 ` Doug Anderson
2023-11-06 21:52 ` Konrad Dybcio
2023-11-06 21:58 ` Doug Anderson
2023-11-06 16:53 ` Doug Anderson
2024-02-16 23:10 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=feca8e74-6653-4cec-943d-47302431e1fc@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_anshar@quicinc.com \
--cc=quic_ashayj@quicinc.com \
--cc=quic_atulpant@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_rgottimu@quicinc.com \
--cc=quic_shashim@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).