devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: Terry Hu <kejia.hu@codethink.co.uk>,
	Device Tree list <devicetree@vger.kernel.org>,
	jorgesanjuan <jorge.sanjuan@codethink.co.uk>,
	Thomas Preston <thomas.preston@codethink.co.uk>,
	linux-tegra <linux-tegra@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Beth White <beth.white@codethink.co.uk>
Subject: Re: RFC: tegra2/tegra3 automotive part changes
Date: Thu, 12 Jul 2018 09:56:52 -0600	[thread overview]
Message-ID: <fecd5597-1b04-6409-b87c-5cda54d43ce0@wwwdotorg.org> (raw)
In-Reply-To: <3916c0ea-964e-42ab-8bfd-8e8edc5110ee@codethink.co.uk>

On 07/12/2018 07:36 AM, Ben Dooks wrote:
> Hello, we are looking at up-streaming some of the work we have
> done on the tegra2 and tegra3 automotive devices. The automotive
> grade devices are close the commercial parts so we would like to
> discuss the core changes before submitting.
> 
> The changes are mostly with things like the clock setup and a
> few peripheral quirks (IIRC these are mostly MMC).
> 
> We are proposing to change the device-tree properties for the root
> node and any other affected devices from "nvidia,tegraXX" to a new
> "nvidia,tegraXXa". We would welcome discussion on whether to update
> all the devices at the start
> 
> An example of tegra30a.dtsi:
> 
> #include "tegra30.dtsi"
> 
> / {
>          compatible = "nvidia,tegra30a";
> 
>          clock@60006000 {
>                  compatible = "nvidia,tegra30a-car";
>          };
> }

This doesn't sound right. Auto and commercial parts are identical AFAIK; 
it's just qualification differences. Hence at most you'd add an extra 
compatible value and not remove the old one. Better might be to detect 
this at run-time from the fuses. I think we already do some of that 
already; search for speedo related code in arch/arm/mach-tegra/.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2018-07-12 15:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12 13:36 RFC: tegra2/tegra3 automotive part changes Ben Dooks
2018-07-12 13:50 ` Mikko Perttunen
2018-07-12 15:07   ` Ben Dooks
2018-07-12 15:56 ` Stephen Warren [this message]
2018-07-13  9:41   ` Ben Dooks
2018-07-13  9:58     ` Jon Hunter
2018-07-13 12:51       ` Ben Dooks
2018-07-13 16:53     ` Stephen Warren
2018-07-20 10:25       ` Ben Dooks
2018-07-24 19:25         ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fecd5597-1b04-6409-b87c-5cda54d43ce0@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=ben.dooks@codethink.co.uk \
    --cc=beth.white@codethink.co.uk \
    --cc=devicetree@vger.kernel.org \
    --cc=jorge.sanjuan@codethink.co.uk \
    --cc=kejia.hu@codethink.co.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thomas.preston@codethink.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).