From: Philipp Zabel <p.zabel@pengutronix.de>
To: Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Swapnil Jakhade <sjakhade@cadence.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Lokesh Vutla <lokeshvutla@ti.com>
Subject: Re: [PATCH v4 07/13] phy: cadence: cadence-sierra: Explicitly request exclusive reset control
Date: Thu, 04 Mar 2021 12:54:54 +0100 [thread overview]
Message-ID: <ff011eb9d811f149382311bef96ccde2e0deab25.camel@pengutronix.de> (raw)
In-Reply-To: <20210304044122.15166-8-kishon@ti.com>
On Thu, 2021-03-04 at 10:11 +0530, Kishon Vijay Abraham I wrote:
> No functional change. Since the reset controls obtained in
> Sierra is exclusively used by the Sierra device, use
> exclusive reset control request API calls.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/phy/cadence/phy-cadence-sierra.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c
> index 935f165404e4..44c52a0842dc 100644
> --- a/drivers/phy/cadence/phy-cadence-sierra.c
> +++ b/drivers/phy/cadence/phy-cadence-sierra.c
> @@ -514,14 +514,14 @@ static int cdns_sierra_phy_get_resets(struct cdns_sierra_phy *sp,
> {
> struct reset_control *rst;
>
> - rst = devm_reset_control_get(dev, "sierra_reset");
> + rst = devm_reset_control_get_exclusive(dev, "sierra_reset");
> if (IS_ERR(rst)) {
> dev_err(dev, "failed to get reset\n");
> return PTR_ERR(rst);
> }
> sp->phy_rst = rst;
>
> - rst = devm_reset_control_get_optional(dev, "sierra_apb");
> + rst = devm_reset_control_get_optional_exclusive(dev, "sierra_apb");
> if (IS_ERR(rst)) {
> dev_err(dev, "failed to get apb reset\n");
> return PTR_ERR(rst);
Oh, nevermind my comment on the previous patch.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
next prev parent reply other threads:[~2021-03-04 11:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 4:41 [PATCH v4 00/13] PHY: Add support in Sierra to use external clock Kishon Vijay Abraham I
2021-03-04 4:41 ` [PATCH v4 01/13] phy: cadence: Sierra: Fix PHY power_on sequence Kishon Vijay Abraham I
2021-03-04 11:56 ` Philipp Zabel
2021-03-04 4:41 ` [PATCH v4 02/13] phy: ti: j721e-wiz: Invoke wiz_init() before of_platform_device_create() Kishon Vijay Abraham I
2021-03-04 4:41 ` [PATCH v4 03/13] phy: cadence: cadence-sierra: Create PHY only for "phy" or "link" sub-nodes Kishon Vijay Abraham I
2021-03-04 4:41 ` [PATCH v4 04/13] phy: ti: j721e-wiz: Get PHY properties only for "phy" or "link" subnode Kishon Vijay Abraham I
2021-03-04 4:41 ` [PATCH v4 05/13] phy: cadence: cadence-sierra: Move all clk_get_*() to a separate function Kishon Vijay Abraham I
2021-03-04 4:41 ` [PATCH v4 06/13] phy: cadence: cadence-sierra: Move all reset_control_get*() " Kishon Vijay Abraham I
2021-03-04 11:54 ` Philipp Zabel
2021-03-04 4:41 ` [PATCH v4 07/13] phy: cadence: cadence-sierra: Explicitly request exclusive reset control Kishon Vijay Abraham I
2021-03-04 11:54 ` Philipp Zabel [this message]
2021-03-04 4:41 ` [PATCH v4 08/13] phy: cadence-torrent: Use a common header file for Cadence SERDES Kishon Vijay Abraham I
2021-03-04 4:41 ` [PATCH v4 09/13] phy: cadence: cadence-sierra: Add array of input clocks in "struct cdns_sierra_phy" Kishon Vijay Abraham I
2021-03-04 4:41 ` [PATCH v4 10/13] phy: cadence: cadence-sierra: Add missing clk_disable_unprepare() in .remove callback Kishon Vijay Abraham I
2021-03-04 4:41 ` [PATCH v4 11/13] dt-bindings: phy: phy-cadence-sierra: Add binding to model Sierra as clock provider Kishon Vijay Abraham I
2021-03-04 4:41 ` [PATCH v4 12/13] phy: cadence: phy-cadence-sierra: Model PLL_CMNLC and PLL_CMNLC1 as clocks (mux clocks) Kishon Vijay Abraham I
2021-03-05 19:47 ` Swapnil Kashinath Jakhade
2021-03-08 4:39 ` Kishon Vijay Abraham I
2021-03-04 4:41 ` [PATCH v4 13/13] phy: cadence: phy-cadence-sierra: Enable pll_cmnlc and pll_cmnlc1 clocks Kishon Vijay Abraham I
2021-03-05 19:48 ` Swapnil Kashinath Jakhade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff011eb9d811f149382311bef96ccde2e0deab25.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=robh+dt@kernel.org \
--cc=sjakhade@cadence.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).