From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8E63C433F5 for ; Sun, 17 Apr 2022 17:46:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234636AbiDQRsi (ORCPT ); Sun, 17 Apr 2022 13:48:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234237AbiDQRsh (ORCPT ); Sun, 17 Apr 2022 13:48:37 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7192736302; Sun, 17 Apr 2022 10:46:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0EFF8B809E3; Sun, 17 Apr 2022 17:46:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A800BC385A4; Sun, 17 Apr 2022 17:45:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650217558; bh=VkPYYsr5x5r7c4+l7JlyJX/Yd5KqB5sSgJ/zXSaOseo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JCo6nyxiiUA2mR2upbI050ANjFm/PZqRuitD4XzsWQ62DVGmvDyU9lmz9oKwjG2ly +AtIeoriiNAQqQf4tvR+REkdHneBKmWe2oGcqpqMMNEUsQeWyyz0CJVsWXZSwjqs07 zn8Tcc+5pf0ZBzF6vfRA6OszCn18n0NUFYI9C178YvncinZZ9tycRORNxmKUBwrI7A ZIuWzTgM1Sfjwn1SteNZhiLG1V1u1xOm2XWuIPyOWSUUye+zX6WvQVRoOTJFc+SdSb nWQQD+DR3SnSCSGB0nl2i4DWJKgIn/XQm2A99RYneN6pi6h/cJMXF5jhlv8FUT23Xb 6iE6LAzUqB6yQ== Message-ID: Date: Sun, 17 Apr 2022 19:45:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add Hardkernel ODROID-M1 board Content-Language: en-US To: Peter Geis Cc: Dongjin Kim , Heiko Stuebner , devicetree , arm-mail-list , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List References: <20220329094446.415219-1-tobetter@gmail.com> <20220329094446.415219-2-tobetter@gmail.com> <2a5f002f-8a61-e5b0-a574-ee99591c4c12@kernel.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/04/2022 14:07, Peter Geis wrote: >>> + dc_12v: dc-12v { >> >> Generic node name, so "regulator" or "regulator-0" > > Unfortunately, this advice breaks the regulator-fixed driver, which it > seems cannot cope with a bunch of nodes all named "regulator". What exactly cannot cope? You cannot have different device nodes with the same name but this is not a limitation of regulator but devicetree spec. > Setting the regulators as regulator-0 -1 -2 leads to fun issues where > the regulator numbering in the kernel doesn't match the node numbers. There are no "node numbers"... maybe you mean unit addresses? But there are none here. > It also makes it more fun when additional regulators need to be added > and everything gets shuffled around. Usually adding - in subsequent DTS files - means increasing the numbers so if you have regulator-[012] then just use regulator-[345] in other files. I see potential mess when you combine several DTSI files, each defining regulators, so in such case "some-name-regulator" (or reversed) is also popular approach. > If naming these uniquely to avoid confusion and collisions is such an > issue, why is it not caught by make W=1 dtbs_check? Patches are welcome. :) Best regards, Krzysztof