* [PATCH] ARM: dts: at91: sama7g5ek: enable pull-up on flexcom3 console lines
@ 2022-03-07 11:38 Eugen Hristev
2022-03-08 8:21 ` Tudor.Ambarus
0 siblings, 1 reply; 3+ messages in thread
From: Eugen Hristev @ 2022-03-07 11:38 UTC (permalink / raw)
To: nicolas.ferre
Cc: devicetree, linux-arm-kernel, linux-kernel, claudiu.beznea,
tudor.ambarus, robh+dt, Eugen Hristev
Flexcom3 is used as board console serial. There are no pull-ups on these
lines on the board. This means that if a cable is not connected (that has
pull-ups included), stray characters could appear on the console as the
floating pins voltage levels are interpreted as incoming characters.
To avoid this problem, enable the internal pull-ups on these lines.
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
arch/arm/boot/dts/at91-sama7g5ek.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/at91-sama7g5ek.dts b/arch/arm/boot/dts/at91-sama7g5ek.dts
index 08685a10eda1d..dd047a8523907 100644
--- a/arch/arm/boot/dts/at91-sama7g5ek.dts
+++ b/arch/arm/boot/dts/at91-sama7g5ek.dts
@@ -495,7 +495,7 @@ pinctrl_flx0_default: flx0_default {
pinctrl_flx3_default: flx3_default {
pinmux = <PIN_PD16__FLEXCOM3_IO0>,
<PIN_PD17__FLEXCOM3_IO1>;
- bias-disable;
+ bias-pull-up;
};
pinctrl_flx4_default: flx4_default {
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: at91: sama7g5ek: enable pull-up on flexcom3 console lines
2022-03-07 11:38 [PATCH] ARM: dts: at91: sama7g5ek: enable pull-up on flexcom3 console lines Eugen Hristev
@ 2022-03-08 8:21 ` Tudor.Ambarus
2022-04-13 8:38 ` Nicolas Ferre
0 siblings, 1 reply; 3+ messages in thread
From: Tudor.Ambarus @ 2022-03-08 8:21 UTC (permalink / raw)
To: Eugen.Hristev, Nicolas.Ferre
Cc: devicetree, linux-arm-kernel, linux-kernel, Claudiu.Beznea,
robh+dt
On 3/7/22 13:38, Eugen Hristev wrote:
> Flexcom3 is used as board console serial. There are no pull-ups on these
> lines on the board. This means that if a cable is not connected (that has
> pull-ups included), stray characters could appear on the console as the
> floating pins voltage levels are interpreted as incoming characters.
> To avoid this problem, enable the internal pull-ups on these lines.
>
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
> arch/arm/boot/dts/at91-sama7g5ek.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/at91-sama7g5ek.dts b/arch/arm/boot/dts/at91-sama7g5ek.dts
> index 08685a10eda1d..dd047a8523907 100644
> --- a/arch/arm/boot/dts/at91-sama7g5ek.dts
> +++ b/arch/arm/boot/dts/at91-sama7g5ek.dts
> @@ -495,7 +495,7 @@ pinctrl_flx0_default: flx0_default {
> pinctrl_flx3_default: flx3_default {
> pinmux = <PIN_PD16__FLEXCOM3_IO0>,
> <PIN_PD17__FLEXCOM3_IO1>;
> - bias-disable;
> + bias-pull-up;
> };
>
> pinctrl_flx4_default: flx4_default {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: at91: sama7g5ek: enable pull-up on flexcom3 console lines
2022-03-08 8:21 ` Tudor.Ambarus
@ 2022-04-13 8:38 ` Nicolas Ferre
0 siblings, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2022-04-13 8:38 UTC (permalink / raw)
To: Tudor Ambarus - M18064, Eugen Hristev - M18282
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Claudiu Beznea - M18063,
robh+dt@kernel.org
On 08/03/2022 at 09:21, Tudor Ambarus - M18064 wrote:
> On 3/7/22 13:38, Eugen Hristev wrote:
>> Flexcom3 is used as board console serial. There are no pull-ups on these
>> lines on the board. This means that if a cable is not connected (that has
>> pull-ups included), stray characters could appear on the console as the
>> floating pins voltage levels are interpreted as incoming characters.
>> To avoid this problem, enable the internal pull-ups on these lines.
>>
>> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
and queued for "fixes". Thanks!
Best regards,
Nicolas
>
>> ---
>> arch/arm/boot/dts/at91-sama7g5ek.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/at91-sama7g5ek.dts b/arch/arm/boot/dts/at91-sama7g5ek.dts
>> index 08685a10eda1d..dd047a8523907 100644
>> --- a/arch/arm/boot/dts/at91-sama7g5ek.dts
>> +++ b/arch/arm/boot/dts/at91-sama7g5ek.dts
>> @@ -495,7 +495,7 @@ pinctrl_flx0_default: flx0_default {
>> pinctrl_flx3_default: flx3_default {
>> pinmux = <PIN_PD16__FLEXCOM3_IO0>,
>> <PIN_PD17__FLEXCOM3_IO1>;
>> - bias-disable;
>> + bias-pull-up;
>> };
>>
>> pinctrl_flx4_default: flx4_default {
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-13 8:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-07 11:38 [PATCH] ARM: dts: at91: sama7g5ek: enable pull-up on flexcom3 console lines Eugen Hristev
2022-03-08 8:21 ` Tudor.Ambarus
2022-04-13 8:38 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).