devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Eugen Hristev - M18282 <Eugen.Hristev@microchip.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
	"Ludovic Desroches - M43218" <Ludovic.Desroches@microchip.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Mihai Sain - M19926 <Mihai.Sain@microchip.com>
Subject: Re: [PATCH] ARM: dts: at91: sama5d2_xplained: remove PA11__SDMMC0_VDDSEL from pinctrl
Date: Wed, 8 Dec 2021 14:06:26 +0100	[thread overview]
Message-ID: <ff254ab5-1d57-3aea-1232-4f26766eeb62@microchip.com> (raw)
In-Reply-To: <f943539b-bc95-35c9-a634-ad75f9df54b0@microchip.com>

On 08/12/2021 at 12:27, Eugen Hristev - M18282 wrote:
> On 12/8/21 1:22 PM, Nicolas Ferre wrote:
>> On 26/10/2021 at 15:20, Eugen Hristev wrote:
>>> From: Mihai Sain <mihai.sain@microchip.com>
>>>
>>> I/O voltage for eMMC is always 3.3V because PA11__SDMMC0_VDDSEL is
>>> tied with 10K resistor to GND. U13 switch S1 is always selected as
>>> voltage rail of 3.3V for VCCQ power pin from MPU controller and eMMC
>>> flash.
>>> Removing PA11 from pinctrl because it remains unused.
>>>
>>> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
>>
>> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> 
> You can also add my
> Reviewed-by: Eugen Hristev <eugen.hristev@microchip.com>
> 
> and also
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> because I sent the patch.

Sure Eugen: Done. Best regards,
   Nicolas

>>> ---
>>>    arch/arm/boot/dts/at91-sama5d2_xplained.dts | 5 ++---
>>>    1 file changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>>> b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>>> index b1e854f658de..9bf2ec0ba3e2 100644
>>> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>>> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>>> @@ -66,7 +66,7 @@ sdmmc0: sdio-host@a0000000 {
>>>                pinctrl-names = "default";
>>>                pinctrl-0 = <&pinctrl_sdmmc0_default>;
>>>                non-removable;
>>> -            mmc-ddr-1_8v;
>>> +            mmc-ddr-3_3v;
>>>                status = "okay";
>>>            };
>>> @@ -619,10 +619,9 @@ cmd_data {
>>>                            bias-disable;
>>>                        };
>>> -                    ck_cd_rstn_vddsel {
>>> +                    ck_cd_rstn {
>>>                            pinmux = <PIN_PA0__SDMMC0_CK>,
>>>                                 <PIN_PA10__SDMMC0_RSTN>,
>>> -                             <PIN_PA11__SDMMC0_VDDSEL>,
>>>                                 <PIN_PA13__SDMMC0_CD>;
>>>                            bias-disable;
>>>                        };
>>>
>>
>>
> 


-- 
Nicolas Ferre

      reply	other threads:[~2021-12-08 13:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26 13:20 [PATCH] ARM: dts: at91: sama5d2_xplained: remove PA11__SDMMC0_VDDSEL from pinctrl Eugen Hristev
2021-12-08 11:22 ` Nicolas Ferre
2021-12-08 11:27   ` Eugen.Hristev
2021-12-08 13:06     ` Nicolas Ferre [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff254ab5-1d57-3aea-1232-4f26766eeb62@microchip.com \
    --to=nicolas.ferre@microchip.com \
    --cc=Eugen.Hristev@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=Mihai.Sain@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).