From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25C63C43219 for ; Fri, 25 Nov 2022 14:49:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230113AbiKYOtQ (ORCPT ); Fri, 25 Nov 2022 09:49:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230085AbiKYOtP (ORCPT ); Fri, 25 Nov 2022 09:49:15 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE76F218A6 for ; Fri, 25 Nov 2022 06:49:14 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id r12so7269755lfp.1 for ; Fri, 25 Nov 2022 06:49:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xNPy40s2BPmi7d6v+ulfkIvVTaVgsEKVuTaAekdgNxg=; b=IlJ05o48+8OuRyWJoc3IhN7eIiMk98yN/eF/6MaEBN5+wjylbStpKcIbn5X7QveH7X 7NXABP5aoGsvaySi86ydt5sCb/KGRm+Dw+ECWZe45Kwl3o8EHW4ZTbDVpymhS0h2qDRn GQhkJPEvBOd/ooKkRE02SZVZaG6PSM5wfFBSUQOtjmWRobu3w7gfSyYTdJyJ2rHV+uAL zHU8wCDqszwD2nYgLXksic6mmtnsBO6LXcb3dsCZRtBRArGG3dKFPkVqEwwn8XMcimHn iq5oe6UMv9y1l/6sjdLod/Kyz1Tg/YCS3oh6IO1Li9jnsybwwtqWTawCA/zQe9KWCq4M aICg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xNPy40s2BPmi7d6v+ulfkIvVTaVgsEKVuTaAekdgNxg=; b=m3GP6H6d0igNFOWY4mAiuuT4/Yd+TwydDpPoOZns0NGQHbErndcRl8APaWuD5ZsG0n m5PVn1Lt5mGHh7y+PEf2/E49pwQMpNiuHxqIweLC7Ct0kkm1jiDOFFbkS6Dduo7Lay2v x3GkA6KpDYoVh8RB53bDQiMtqagzx3tM+e20+N2BachlJixe/jwtJwUWC0yOfhLuy0HO vd/9m46y/4FHuP3Hwq9TpkdDQtMmms4YK5SYUu6Xx3Ilzj8epcPCpRLvkREQvxOGyJ3a uO8di9ansc3XqtMGn5xk9E/RDzew7Xt+V2JDihb/Ln+NujqVXi94407x+HeWi9oDiHxa pilg== X-Gm-Message-State: ANoB5pnmS+Y9mi2Rh4VtSPzkD6zCLIN7IAck59ZuTijVgRNYya9i88Z9 PqUwKQ24miHSfblMrjx5maklRQ== X-Google-Smtp-Source: AA0mqf4bce/D1OJeUf4UCKOv4zGJQnRoVTveEJVWArehvP51fU5aC7O5xk7KIGrSeEQmFBAgmaEZpg== X-Received: by 2002:ac2:51b6:0:b0:4ae:8510:646f with SMTP id f22-20020ac251b6000000b004ae8510646fmr13550031lfk.432.1669387753066; Fri, 25 Nov 2022 06:49:13 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id v12-20020a056512348c00b004994c190581sm555549lfr.123.2022.11.25.06.49.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 06:49:12 -0800 (PST) Message-ID: Date: Fri, 25 Nov 2022 15:49:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850 Content-Language: en-US To: Sam Protsenko Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Sriranjani P , Chanho Park References: <20221125112201.240178-1-krzysztof.kozlowski@linaro.org> <20221125112201.240178-4-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/11/2022 15:38, Sam Protsenko wrote: > On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski > wrote: >> >> Exynos850 has dedicated clock for accessing SYSREGs. Allow it, even >> though Linux currently does not enable them and relies on bootloader. >> > > Not sure if this description is correct. Of course, there is no driver > for "samsung,exynos850-sysreg" compatible at the moment, so the next > compatible from the list ("syscon") is used for Exynos850. And > "syscon" driver (drivers/mfd/syscon.c) actually does control the > clocks. I remember adding "clocks" property to Exynos850 dts to fix > actual problem. Also, the "clocks" property is not described in > Documentation/devicetree/bindings/mfd/syscon.yaml, didn't really check > if it's ok or it's just missing. > > Other than that comment: > > Reviewed-by: Sam Protsenko > >> Signed-off-by: Krzysztof Kozlowski Ah, then commit msg is not good. I'll update it and maybe the clocks should be required for Exynos850? Best regards, Krzysztof